Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: I5/g2OrUKPHX3/z1mMo+t0vURMI86KgCxJUflk5T+ku6G2nUaVZ4r7OYvJfAuHisPghVytygJE
 +0kvZWL0xY+w==
IronPort-SDR: 7/qhnrTE8F52QUrj2cNi185t2jut9xND9SEOHzcRmsPXv5GsfNRw65ZjV2Hr9Xj7SP1LBMcUEk
 oyH+9a10HeSw==
Subject: Re: [PATCH v8 09/13] perf stat: implement control commands handling
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <0781a077-aa82-5b4a-273e-c17372a72b93@linux.intel.com>
 <5ed69a1e-052a-9790-7642-cb9c9a53d786@linux.intel.com>
 <20200623145458.GG2619137@krava>
 <9bf22a7b-0b56-c55f-c8b2-60c8e6ed0ef9@linux.intel.com>
 <20200625121218.GG2719003@krava>
From:   Alexey Budankov <alexey.budankov@linux.intel.com>
Organization: Intel Corp.
Message-ID: <b3c7ab03-d2ba-ac60-fd45-42cfb5b57a28@linux.intel.com>
Date:   Thu, 25 Jun 2020 17:52:17 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <20200625121218.GG2719003@krava>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 25.06.2020 15:12, Jiri Olsa wrote:
> On Wed, Jun 24, 2020 at 04:39:11PM +0300, Alexey Budankov wrote:
>>
>>
>> On 23.06.2020 17:54, Jiri Olsa wrote:
>>> On Wed, Jun 17, 2020 at 11:41:30AM +0300, Alexey Budankov wrote:
>>>>
>>>> Implement handling of 'enable' and 'disable' control commands
>>>> coming from control file descriptor. process_evlist() function
>>>> checks for events on control fds and makes required operations.
>>>> If poll event splits initiated timeout interval then the reminder
>>>> is calculated and still waited in the following poll() syscall.
>>>>
>>>> Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
>>>> ---
>>>>  tools/perf/builtin-stat.c | 67 +++++++++++++++++++++++++++++----------
>>>>  1 file changed, 50 insertions(+), 17 deletions(-)
>>>>
>>>> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
>>>> index f88d5ee55022..cc56d71a3ed5 100644
>>>> --- a/tools/perf/builtin-stat.c
>>>> +++ b/tools/perf/builtin-stat.c
>>>> @@ -492,6 +492,31 @@ static bool process_timeout(int timeout, unsigned int interval, int *times)
>>>>  	return print_interval(interval, times);
>>>>  }
>>>>  
>>>> +static bool process_evlist(struct evlist *evlist, unsigned int interval, int *times)
>>>> +{
>>>> +	bool stop = false;
>>>> +	enum evlist_ctl_cmd cmd = EVLIST_CTL_CMD_UNSUPPORTED;
>>>> +
>>>> +	if (evlist__ctlfd_process(evlist, &cmd) > 0) {
>>>> +		switch (cmd) {
>>>> +		case EVLIST_CTL_CMD_ENABLE:
>>>> +			pr_info(EVLIST_ENABLED_MSG);
>>>> +			stop = print_interval(interval, times);
>>>
>>> why is interval printed in here?
>>>
>>>> +			break;
>>>> +		case EVLIST_CTL_CMD_DISABLE:
>>>> +			stop = print_interval(interval, times);
>>>
>>> and here?
>>>
>>> it should be called from the main loop when the interval time is elapsed no?
>>
>> It is called from the main loop too and it is also additionally called here
>> to provide indication and counter values on commands processing times.
> 
> so it prints interval out of order?

Looks like it does. The only issue with it I see is change in times value.

~Alexey

> 
> jirka
>