Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: KPcOeI/8DTmo3bVrbUv8lk3IHC54bAofWyAVz8R6YVNZRvw6GgSDNuVe+ysQ11Z8N3UgivZKmi
 dQ6tiUkg7rsQ==
IronPort-SDR: LM8O3ScfvF0Dfi6sQXb7LRZTKXcIDsQhk3psk3/8vJIsQjuKUd/hy2mG+Bu0+MpMPjyQTggR8J
 e8Q5lvy8I0NA==
Subject: Re: [PATCH v8 09/13] perf stat: implement control commands handling
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <0781a077-aa82-5b4a-273e-c17372a72b93@linux.intel.com>
 <5ed69a1e-052a-9790-7642-cb9c9a53d786@linux.intel.com>
 <20200623145442.GE2619137@krava>
 <5d6bab4b-d743-609e-e08c-8eabcb9adfef@linux.intel.com>
 <20200625121453.GH2719003@krava>
From:   Alexey Budankov <alexey.budankov@linux.intel.com>
Organization: Intel Corp.
Message-ID: <a3730551-54f8-8ca0-8be6-35e9fd845e08@linux.intel.com>
Date:   Thu, 25 Jun 2020 17:58:06 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <20200625121453.GH2719003@krava>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 25.06.2020 15:14, Jiri Olsa wrote:
> On Wed, Jun 24, 2020 at 05:10:10PM +0300, Alexey Budankov wrote:
>>
>> On 23.06.2020 17:54, Jiri Olsa wrote:
>>> On Wed, Jun 17, 2020 at 11:41:30AM +0300, Alexey Budankov wrote:
>>>
>>> SNIP
>>>
>>>>  
>>>>  	while (1) {
>>>>  		if (forks)
>>>> @@ -581,8 +617,17 @@ static int dispatch_events(bool forks, int timeout, int interval, int *times, st
>>>>  		if (done || stop || child)
>>>>  			break;
>>>>  
>>>> -		nanosleep(ts, NULL);
>>>> -		stop = process_timeout(timeout, interval, times);
>>>> +		clock_gettime(CLOCK_MONOTONIC, &time_start);
>>>> +		if (!(evlist__poll(evsel_list, time_to_sleep) > 0)) { /* poll timeout or EINTR */
>>>> +			stop = process_timeout(timeout, interval, times);
>>>> +			time_to_sleep = sleep_time;
>>>> +		} else { /* fd revent */
>>>> +			stop = process_evlist(evsel_list, interval, times);
>>>> +			clock_gettime(CLOCK_MONOTONIC, &time_stop);
>>>> +			diff_timespec(&time_diff, &time_stop, &time_start);
>>>> +			time_to_sleep -= time_diff.tv_sec * MSEC_PER_SEC +
>>>> +					time_diff.tv_nsec / NSEC_PER_MSEC;
>>>
>>> should we check time_to_sleep > time_diff first?
>>
>> Probably and if time_diff > time_to_sleep then time_to_sleep = 0 ?
> 
> or extra call to process_timeout? if we dont want to call evlist_poll
> with 0 timeout

poll() man page says it is ok to call poll with 0 timeout so 
process_timeout() and initialization of time_to_sleep will be
done in common flow.

~Alexey