Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   B K Karthik <bkkarthik@pesu.pes.edu>
Date:   Thu, 25 Jun 2020 11:35:17 -0400
To:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH 1/1] staging: media: soc_camera: Adding parentheses to macro
 defination at line 241, Clearing alignment issues at lines 410 and 1270,
 fixing return values at EPOLLERR
Message-ID: <20200625153516.fibpfsodnogrimlh@pesu-pes-edu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="fhzbuehlmb54oq5j"
Content-Disposition: inline
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--fhzbuehlmb54oq5j
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

staging: media: soc_camera: soc_camera.c: Clearing coding-style problem
"Macros with complex values should be enclosed in parentheses" in line 241 =
by adding parentheses.
staging: media: soc_camera: soc_camera.c: Clearing coding-style problem
"Alignment should match open parenthesis" by adding tab spaces in line 410.
staging: media: soc_camera: soc_camera.c: Clearing coding-style problem
"return of an errno should typically be negative" by adding a "-" in front =
of EPOLLER in line 812.
staging: media: soc_camera: soc_camera.c: Clearing coding-style problem
"Alignment should match open parenthesis" by adding tab spaces in line 1270.

Signed-off-by: B K Karthik <karthik.bk2000@live.com>
---
 drivers/staging/media/soc_camera/soc_camera.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/media/soc_camera/soc_camera.c b/drivers/stagin=
g/media/soc_camera/soc_camera.c
index 39f513f69b89..66a14ebd8093 100644
--- a/drivers/staging/media/soc_camera/soc_camera.c
+++ b/drivers/staging/media/soc_camera/soc_camera.c
@@ -238,8 +238,8 @@ unsigned long soc_camera_apply_board_flags(struct soc_c=
amera_subdev_desc *ssdd,
 }
 EXPORT_SYMBOL(soc_camera_apply_board_flags);
=20
-#define pixfmtstr(x) (x) & 0xff, ((x) >> 8) & 0xff, ((x) >> 16) & 0xff, \
-	((x) >> 24) & 0xff
+#define pixfmtstr(x) ((x) & 0xff, ((x) >> 8) & 0xff, ((x) >> 16) & 0xff, \
+	((x) >> 24) & 0xff)
=20
 static int soc_camera_try_fmt(struct soc_camera_device *icd,
 			      struct v4l2_format *f)
@@ -407,7 +407,7 @@ static int soc_camera_dqbuf(struct file *file, void *pr=
iv,
 }
=20
 static int soc_camera_create_bufs(struct file *file, void *priv,
-			    struct v4l2_create_buffers *create)
+			    		struct v4l2_create_buffers *create)
 {
 	struct soc_camera_device *icd =3D file->private_data;
 	int ret;
@@ -806,10 +806,10 @@ static __poll_t soc_camera_poll(struct file *file, po=
ll_table *pt)
 {
 	struct soc_camera_device *icd =3D file->private_data;
 	struct soc_camera_host *ici =3D to_soc_camera_host(icd->parent);
-	__poll_t res =3D EPOLLERR;
+	__poll_t res =3D -EPOLLERR;
=20
 	if (icd->streamer !=3D file)
-		return EPOLLERR;
+		return -EPOLLERR;
=20
 	mutex_lock(&ici->host_lock);
 	res =3D ici->ops->poll(file, pt);
@@ -1267,7 +1267,7 @@ static int soc_camera_i2c_init(struct soc_camera_devi=
ce *icd,
 	}
=20
 	subdev =3D v4l2_i2c_new_subdev_board(&ici->v4l2_dev, adap,
-				shd->board_info, NULL);
+						shd->board_info, NULL);
 	if (!subdev) {
 		ret =3D -ENODEV;
 		goto ei2cnd;
--=20
2.20.1


--fhzbuehlmb54oq5j
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEEpIrzAt4LvWLJmKjp471Q5AHeZ2oFAl70xDQACgkQ471Q5AHe
Z2oZlAv/bmnvULtnv3yC5oXsH9CF4NejDM305ZbwMYLCm0k5INVKHk2hgumFNw/v
mHDKoKT+D7vujqhWAlVh/l996TVlIbTAntl2W76FoJ0xBsZ4C4Qczn0GOKpDE08N
kQKuqtUCRv1Cb9Uz+e8yJJJ68O3Lhhb82NKEc9oI5YzwfC1sge97L05xcAmHqGRn
lkl2aNouT4hAm03kIl0aSM8mT3Ik3lkECcT9tncwaSa9iHwxXI/XW8B9yZaXDvDA
HEIJjpHHqtii5srCdxkQn8MR5cvYOWvocxx6leyqZrq3lo6bPJpIT4+zwqanKFPM
jl2VHSqHO7h/3nS04NVnUrS0ONon8REFoIU5iKLlN0lnwL1XY+XHNqNlbqpknb8s
/6+ah50oOevSmjjMGXE19JSr46GRgaDcSYcbV9ODQFziFtr3U40j7BssOqveWVDw
bXojJE1ObgFwcq7OjXJhKIy+OsjJf0Rp195iIVpWmrudGb670/sIQdaAXo/H4ocn
DyfxNma/
=OdLO
-----END PGP SIGNATURE-----

--fhzbuehlmb54oq5j--