Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1667768ybt; Thu, 25 Jun 2020 11:12:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLaHMoPWHyF0zP/t7cfIbD/sYC/T00LMm0QhjB/+U7WgAhT3GTh11NphXkQZ3HUiTUTJkr X-Received: by 2002:a05:6402:228d:: with SMTP id cw13mr5273806edb.343.1593108729893; Thu, 25 Jun 2020 11:12:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593108729; cv=none; d=google.com; s=arc-20160816; b=pAlBu5M1qeEKvm4D5G/toG+Y37Vo0M6WGRW1QNDNSTGnqQfABIxX27kdsPRQK3N1cC io99GZxPtvJFX75N5aFR7zMxX1c+WPI876XF6vFP3U0GYTtUE6BYTATS4PBQYpp/QB6a ERHT4jpa36f8Ljb3bmkFwZ+xdFeDNAnHFlvjJ5d966u9sqIzhZlazGdvyHi6cMAyUby+ 5EdXUF8Sdf/ZkD3RnQXhixZvJki9JWe8W+iyvJftEATQnweMLTSl/0q9lvegt+2QRKoy jHAwmdSIiWEiE79w1ThYHEkyqTQ8+y1NpuY30mgPDwr5mnACx9Y34V+kcC6BowOGZi+6 t8vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=g9QiSwq19sXofJNP4zWEiOYuaORFZwqDfSnj7dFLYV0=; b=vzkLnX7Sb1Rpp0XF4KQFkv+FiNjJTKyDQzEPOJp3BO7SuGgjmvSc/2cfNYMFTzrO6B JQzr60g3BJlZ524LzIq7gRj6JJA3w6duIJGk3R3Jsy26IU7tJwfXtIZj76HLvEFP1w86 iZlL5rh5mc1cCwcAuzldmvOyIE55py2O8abW3nMHplmEhVr6T7uGS8ARTWAhm8VBNAPX otYKdpPXLYl6acBhQq79SPgQKuFXNAQxp2Kvbi+I/XWHHS0sAvzvcUxufgXgsqC+8Sew QY0fxs/+MBQpaxAYS3d5Knep8dXISSr/DoK5M/WO9oHtOQg/v4vFEnXG/X/zmagE13V3 /RQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m23si10089774edq.346.2020.06.25.11.11.45; Thu, 25 Jun 2020 11:12:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406026AbgFYPpK (ORCPT + 99 others); Thu, 25 Jun 2020 11:45:10 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:20125 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405962AbgFYPpA (ORCPT ); Thu, 25 Jun 2020 11:45:00 -0400 X-Originating-IP: 90.76.143.236 Received: from localhost (lfbn-tou-1-1075-236.w90-76.abo.wanadoo.fr [90.76.143.236]) (Authenticated sender: antoine.tenart@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id D579F24000E; Thu, 25 Jun 2020 15:44:57 +0000 (UTC) From: Antoine Tenart To: davem@davemloft.net, andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com Cc: Antoine Tenart , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com Subject: [PATCH net-next 7/8] net: phy: mscc: remove useless page configuration in the config init Date: Thu, 25 Jun 2020 17:42:10 +0200 Message-Id: <20200625154211.606591-8-antoine.tenart@bootlin.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200625154211.606591-1-antoine.tenart@bootlin.com> References: <20200625154211.606591-1-antoine.tenart@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In the middle of vsc8584_config_init and vsc8514_config_init, the page is set to 'standard'. This is the default value, and the page isn't set to another value before. Those pages configuration can be safely removed. Signed-off-by: Antoine Tenart --- drivers/net/phy/mscc/mscc_main.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/net/phy/mscc/mscc_main.c b/drivers/net/phy/mscc/mscc_main.c index f625109df00a..04e1ef791cec 100644 --- a/drivers/net/phy/mscc/mscc_main.c +++ b/drivers/net/phy/mscc/mscc_main.c @@ -1443,8 +1443,6 @@ static int vsc8584_config_init(struct phy_device *phydev) if (ret) return ret; - phy_write(phydev, MSCC_EXT_PAGE_ACCESS, MSCC_PHY_PAGE_STANDARD); - val = phy_read(phydev, MSCC_PHY_EXT_PHY_CNTL_1); val &= ~(MEDIA_OP_MODE_MASK | VSC8584_MAC_IF_SELECTION_MASK); val |= (MEDIA_OP_MODE_COPPER << MEDIA_OP_MODE_POS) | @@ -1892,11 +1890,6 @@ static int vsc8514_config_init(struct phy_device *phydev) phy_unlock_mdio_bus(phydev); - ret = phy_write(phydev, MSCC_EXT_PAGE_ACCESS, MSCC_PHY_PAGE_STANDARD); - - if (ret) - return ret; - ret = phy_modify(phydev, MSCC_PHY_EXT_PHY_CNTL_1, MEDIA_OP_MODE_MASK, MEDIA_OP_MODE_COPPER << MEDIA_OP_MODE_POS); -- 2.26.2