Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [EXT] [PATCH] qed: add missing error test for
 DBG_STATUS_NO_MATCHING_FRAMING_MODE
To:     Colin King <colin.king@canonical.com>,
        Ariel Elior <aelior@marvell.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@marvell.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Michal Kalderon <mkalderon@marvell.com>,
        <netdev@vger.kernel.org>
CC:     <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20200624101302.8316-1-colin.king@canonical.com>
From:   Igor Russkikh <irusskikh@marvell.com>
Message-ID: <a562bb9e-f158-3cdb-f969-fcbf88a2fad8@marvell.com>
Date:   Thu, 25 Jun 2020 19:32:28 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.0
MIME-Version: 1.0
In-Reply-To: <20200624101302.8316-1-colin.king@canonical.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Colin!

Thanks for catching this, indeed this was missed!

> 
>  	/* DBG_STATUS_INVALID_FILTER_TRIGGER_DWORDS */
>  	"The filter/trigger constraint dword offsets are not enabled for 
> recording",
> -
> +	/* DBG_STATUS_NO_MATCHING_FRAMING_MODE */
> +	"No matching framing mode",
> 

Could you please however change the string to

	"No matching framing mode found for the enabled blocks/Storms - use less
dwords for blocks data",

If you don't have much time, I can repost this for you. With this change it'll
 be in sync with our internal error descriptions.

Thanks
  Igor