Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1675484ybt; Thu, 25 Jun 2020 11:22:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzKNPtt6rWO0BeL9mWLhPQrf/Cb4fAl4P3zglXHn37GpnKQAbj1kRrKaMNTlKkuZiWBW9OC X-Received: by 2002:a17:906:ce32:: with SMTP id sd18mr2393060ejb.228.1593109347990; Thu, 25 Jun 2020 11:22:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593109347; cv=none; d=google.com; s=arc-20160816; b=G9tDGUHNApPGEjO9mKxAAFkl+vr/tNoeGJxSo5Up1QD40tfl9h0p2fsfVy5gC2VCP3 ioayVykHNnc66dLMszbC5WzofFjTa70Fj0xQttc82A7K4v2N1lbi3UaC5EuFWbjvae60 R3qyLj3gjTvV5QFhhg1DQDz4J2ID0QtDQ4BkFhXP2LhscAaRipx+jfLGoBd6a28hAkPn qTpbHHBv2LFf/MFa4rSXLKgAKiK5U2GGX2DrCWEfDhrBY+lIjRLKefWn/HYKHGv3F5gL 6OEiRXOC/iGDczxWRvOQ257ubraVYH0e3AtwIAcbf0/gtqqMngfTLefT6/WLzbZ0s57K nfMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=NYOgVuiA9UN2uQYd8lfSDF3wYZ/KZURBOdSPM+8Kz2Q=; b=B+AWj0B0IQ0/ZzMAttuDm0AH5Q6O0S2unxOj7QhxcIS21R1woPH2nxKQ5luze60uQJ 5PRDYN0AGwrQZ6u0eK13EM99G0UFUdY6VGMWjTVK6ZzGXmnhNj5kOddzer3jkys1zWov nUl3HQs7ljuXffIIpVi1XKgIrrYQmponfqH647B+kh5BTAUZbCZSKoQ246lqn0wUlrN1 uID18xbqZFOOqza7Fu0KEDFMHymbY+BSr8MzHGseT5Ze5cx2hs2mQDWLzMXsk4MqvPss +aRZLSEOYtyHJx0MB8Li0DSu+ewxYoKRMyEbJdyV54Us+jHYExB0q96jsdvoO6fdRX9Y 5ZtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uaBmBng9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h21si3343085edw.233.2020.06.25.11.22.03; Thu, 25 Jun 2020 11:22:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uaBmBng9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406306AbgFYQwQ (ORCPT + 99 others); Thu, 25 Jun 2020 12:52:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:37514 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404001AbgFYQwP (ORCPT ); Thu, 25 Jun 2020 12:52:15 -0400 Received: from localhost (p54b332a0.dip0.t-ipconnect.de [84.179.50.160]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E7020206BE; Thu, 25 Jun 2020 16:52:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593103935; bh=3IC/qxq+c3azNGHSnoz9SjkclgpX1yfKjOq4gbNl2cw=; h=From:To:Cc:Subject:Date:From; b=uaBmBng98knRwyN1mqjYqhvZ6pcsfMfXV4rpDqN0LaLuTBR6kcRFAooVnnn3qTPyc iTlNEMsX9bWCwaN7sP2a7qa3pJy7VFMqSGyT90l9XoueRnHkG3pQCodcZveXUbDSRC 2+sN466a8GT0UWkyXHtEayRS+/fheo8XI28MVVdo= From: Wolfram Sang To: linux-wireless@vger.kernel.org Cc: Wolfram Sang , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , Kalle Valo , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH] iwlwifi: yoyo: don't print failure if debug firmware is missing Date: Thu, 25 Jun 2020 18:52:10 +0200 Message-Id: <20200625165210.14904-1-wsa@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Missing this firmware is not fatal, my wifi card still works. Even more, I couldn't find any documentation what it is or where to get it. So, I don't think the users should be notified if it is missing. If you browse the net, you see the message is present is in quite some logs. Better remove it. Signed-off-by: Wolfram Sang --- This is only build tested because I wanted to get your opinions first. I couldn't find any explanation about yoyo, so I am entering unknown territory here. drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c index 7987a288917b..f180db2936e3 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c +++ b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c @@ -468,7 +468,7 @@ void iwl_dbg_tlv_load_bin(struct device *dev, struct iwl_trans *trans) if (!iwlwifi_mod_params.enable_ini) return; - res = request_firmware(&fw, "iwl-debug-yoyo.bin", dev); + res = firmware_request_nowarn(&fw, "iwl-debug-yoyo.bin", dev); if (res) return; -- 2.20.1