Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1676552ybt; Thu, 25 Jun 2020 11:24:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/xI781TbBqSUQ1uiaCotLk32dzrUzuYRH7aj3fh0l09jFV+KiQ0zbOkMhXCqdcFTt13kq X-Received: by 2002:a17:906:95d9:: with SMTP id n25mr1177901ejy.437.1593109441204; Thu, 25 Jun 2020 11:24:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593109441; cv=none; d=google.com; s=arc-20160816; b=QilynmC9jzKtZSepgkqxz8VGqlbVNC+GnajKdZjQPfnLKNe9TlY9Xl0d7Q4mFlanDx WPMhYaWkOEyyKh56sxjJPpcY9Usw9/v7p4ek8cTLzfBJjetAmkhUvca0SlYbnRY1qSYP lnelGevcQvNBQDECJ6kHK3wgsNNtORjhTKNe0bGQ2Op/fL+uAbiFj6HsS57jJ/ei50dI /xIdIdcwLd+iJ/A7IJOhJVHsSflHJA4KC93Hv7BBnughJ4zTTvZAd4JTZgkEGKlcpu4s CPkOHd40+BMpSD36IaeDXQynlu811Rurju0TIeCa+1/wGDCkidCaMvq040X3vAed0a0i JUnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=WunZ9lBiliNx0LwIQA6MxATA9myFT/PnnP48EdzF9T8=; b=DQyJsacTkGDxOLk5Q84+WrDrvSTSF/zD/ibucQ0CWb419lOTT/zKWiurH6QiP/xPUN gTu/Pooeo7XniFGghB+TilXhgEbHpB/Be79sZryUtYj9obTIHwJXzuiCPh2pkYqjrzeg hdkBcd1wOSj7Z6zXxUbR0eqIaoSJMykDsBe1hfxvIiiIBZDsDzl8i6dGSY0aMS0mH1a7 ctHG2RCvqcvNlktDQUGedVh/HFs3PU76mqyQaZoacNbN/35rL7BFqmqn5GGQzxq6yitg CEmaMO7imly5dh2EuwdYyfIWd4a+aeqJElE762JBUskrn0et9npviP11wzILi9TbOfjA hcPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f22si4928226edw.472.2020.06.25.11.23.38; Thu, 25 Jun 2020 11:24:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391013AbgFYQr3 (ORCPT + 99 others); Thu, 25 Jun 2020 12:47:29 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:60716 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390448AbgFYQr3 (ORCPT ); Thu, 25 Jun 2020 12:47:29 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1joV27-002EOb-Qr; Thu, 25 Jun 2020 18:47:27 +0200 Date: Thu, 25 Jun 2020 18:47:27 +0200 From: Andrew Lunn To: Antoine Tenart Cc: davem@davemloft.net, f.fainelli@gmail.com, hkallweit1@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com Subject: Re: [PATCH net-next 5/8] net: phy: mscc: do not access the MDIO bus lock directly Message-ID: <20200625164727.GN442307@lunn.ch> References: <20200625154211.606591-1-antoine.tenart@bootlin.com> <20200625154211.606591-6-antoine.tenart@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200625154211.606591-6-antoine.tenart@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 25, 2020 at 05:42:08PM +0200, Antoine Tenart wrote: > This patch improves the MSCC driver by using the provided > phy_lock_mdio_bus and phy_unlock_mdio_bus helpers instead of locking and > unlocking the MDIO bus lock directly. The patch is only cosmetic but > should improve maintenance and consistency. > > Signed-off-by: Antoine Tenart Reviewed-by: Andrew Lunn Andrew