Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 25 Jun 2020 19:07:37 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     Alexey Budankov <alexey.budankov@linux.intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 12/13] perf record: implement control commands handling
Message-ID: <20200625170737.GJ2719003@krava>
References: <0781a077-aa82-5b4a-273e-c17372a72b93@linux.intel.com>
 <f48c5f58-96ea-b1f0-a7e6-55315a292bce@linux.intel.com>
 <20200623145434.GD2619137@krava>
 <3107d9cd-03ec-34aa-4226-393547c55517@linux.intel.com>
 <173bf24f-1db4-b496-c258-4e98536d23a5@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <173bf24f-1db4-b496-c258-4e98536d23a5@linux.intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jun 24, 2020 at 05:55:02PM +0300, Alexey Budankov wrote:
> 
> On 24.06.2020 17:00, Alexey Budankov wrote:
> > 
> > On 23.06.2020 17:54, Jiri Olsa wrote:
> >> On Wed, Jun 17, 2020 at 11:43:58AM +0300, Alexey Budankov wrote:
> >>>
> >>> Implement handling of 'enable' and 'disable' control commands
> >>> coming from control file descriptor.
> >>>
> >>> Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
> >>> ---
> >>>  tools/perf/builtin-record.c | 16 ++++++++++++++++
> >>>  1 file changed, 16 insertions(+)
> >>>
> >>> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> >>> index d0b29a1070a0..0394e068dde8 100644
> >>> --- a/tools/perf/builtin-record.c
> >>> +++ b/tools/perf/builtin-record.c
> >>> @@ -1527,6 +1527,7 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)
> >>>  	bool disabled = false, draining = false;
> >>>  	int fd;
> >>>  	float ratio = 0;
> >>> +	enum evlist_ctl_cmd cmd = EVLIST_CTL_CMD_UNSUPPORTED;
> >>>  
> >>>  	atexit(record__sig_exit);
> >>>  	signal(SIGCHLD, sig_handler);
> >>> @@ -1830,6 +1831,21 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)
> >>>  				alarm(rec->switch_output.time);
> >>>  		}
> >>>  
> >>> +		if (evlist__ctlfd_process(rec->evlist, &cmd) > 0) {
> >>> +			switch (cmd) {
> >>> +			case EVLIST_CTL_CMD_ENABLE:
> >>> +				pr_info(EVLIST_ENABLED_MSG);
> >>> +				break;
> >>> +			case EVLIST_CTL_CMD_DISABLE:
> >>> +				pr_info(EVLIST_DISABLED_MSG);
> >>> +				break;
> >>> +			case EVLIST_CTL_CMD_ACK:
> >>> +			case EVLIST_CTL_CMD_UNSUPPORTED:
> >>> +			default:
> >>> +				break;
> >>> +			}
> >>> +		}
> >>
> >> so there's still the filter call like:
> >>
> >>                         if (evlist__filter_pollfd(rec->evlist, POLLERR | POLLHUP) == 0)
> >>                                 draining = true;
> >>
> >> it will never be 0 if the control fds are stil alive no?
> > 
> > Due to change in filter_pollfd() and preceding evlist__ctlfd_process() call
> > now control fd is not counted by filter_pollfd().
> And evlist__ctlfd_process() still should be called second time right
> after evlist_poll() but prior filter_polfd().

aaah it's set to zero in here:

        if (entries[ctlfd_pos].revents & (POLLHUP | POLLERR))
                evlist__finalize_ctlfd(evlist);
        else
                entries[ctlfd_pos].revents = 0;

yea, that's bad.. another reason to call it a hack

jirka

> 
> ~Alexey
> 
> > 
> > However event fds with .revents == 0 are not counted either and this breaks
> > the algorithm thus something more is still required to cover this gap.
> > 
> > ~Alexey
> > 
> >>
> >> jirka
> >>
>