Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1731985ybt; Thu, 25 Jun 2020 12:43:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9nTledlmZxLUo3YMiTtBhLOHeQNOs0A8JskCGzjVOXhZWjsMEfq+FHQZnCCHSeQ2mMUoN X-Received: by 2002:a17:906:364a:: with SMTP id r10mr21224966ejb.122.1593114180063; Thu, 25 Jun 2020 12:43:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593114180; cv=none; d=google.com; s=arc-20160816; b=GF2U5HSVK4o2MnyW2QXKlzHZPs1Sqwc79b5T0uV5kRiiQBrHsoaJMuu7jdRegJs1cY Bz8m239QLlxuzgJsQFT8ygDwxLCyiwAJ6URFm2Slg7KHIxqBv9m44Lsxhb9b89XqvVow q9lvkal0Kq49eaTGh0D7pcddNpKS1i1g71L/ezkTqw0DNNxDDQT0Ndqrd8rnznHN6/m0 6xdUjVoE/WJTA8nhSVSUSv2BlwS3FvStvb8w4sX8xY6pjp6e9lOhGn3lZWAdspU7G5pr 1rniONtgKUwTsv9TIf7Tu2GQ/T+/BFqM78O5jwdsxbiScsozZ6tTpULgGKB9+7uZV9mi 0GpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=2vQ9bUdPI18phu0ZvrZGPKKRHDotUeV+1GKmxIFf3SI=; b=z1y2519i74QVIbjfJE15gM8vIcX6C7RKq3EQRWOmzZJuhUR9d/2z/aj0rxa1VKfZer nJCl1AzufigMfTu7UgpMJ+EBCjtHTLs5adY4bnZmWmmhl9TMJdPmJSuIb5K6L3XQ6eQQ jQFkzYF+sMwCHublkSm6kYoY35vF1zBFfDs3YxJLqfdlYWPWoWUQ0/fRMiAo6VO/M+Rw gQ3S5MdElLtiZTVIZpbxSyfBx/oQCmJztwGH3tP4hBPKYlyPlROcYtI7F3zUT01WGch2 u7gV9sSrxgbAwUI0ESvtBUrKY4Ss+GnitZ/EChtmVD0Ghuc2h5TsHt50oNKRNEdifwMT GwHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oi20si14822241ejb.571.2020.06.25.12.42.31; Thu, 25 Jun 2020 12:43:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406591AbgFYTis (ORCPT + 99 others); Thu, 25 Jun 2020 15:38:48 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:35500 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406069AbgFYTis (ORCPT ); Thu, 25 Jun 2020 15:38:48 -0400 Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 05PJWkxr043707; Thu, 25 Jun 2020 15:38:45 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 31ux03v69j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Jun 2020 15:38:45 -0400 Received: from m0187473.ppops.net (m0187473.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 05PJX8sV044689; Thu, 25 Jun 2020 15:38:44 -0400 Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com with ESMTP id 31ux03v687-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Jun 2020 15:38:44 -0400 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 05PJLTAb030530; Thu, 25 Jun 2020 19:38:42 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma06ams.nl.ibm.com with ESMTP id 31uusjj3dw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Jun 2020 19:38:42 +0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 05PJcdvl65470898 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Jun 2020 19:38:39 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 42EC4A4054; Thu, 25 Jun 2020 19:38:39 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E44ABA405C; Thu, 25 Jun 2020 19:38:38 +0000 (GMT) Received: from osiris (unknown [9.171.67.222]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Thu, 25 Jun 2020 19:38:38 +0000 (GMT) Date: Thu, 25 Jun 2020 21:38:37 +0200 From: Heiko Carstens To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-mm@kvack.org, Vasily Gorbik , Christian Borntraeger , Andrew Morton , Gerald Schaefer Subject: Re: [PATCH RFC] s390x/vmem: get rid of memory segment list Message-ID: <20200625193837.GA5050@osiris> References: <20200625150029.45019-1-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200625150029.45019-1-david@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687 definitions=2020-06-25_15:2020-06-25,2020-06-25 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 impostorscore=0 cotscore=-2147483648 bulkscore=0 adultscore=0 mlxlogscore=911 mlxscore=0 priorityscore=1501 spamscore=0 suspectscore=1 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006250115 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 25, 2020 at 05:00:29PM +0200, David Hildenbrand wrote: > This smells like a leftover from ancient times, let's get rid of it. We > can now convert vmem_remove_mapping() into a void function - everybody > ignored the return value already. This buys us what? Except that we get rid of a bit of code?