Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp101411ybt; Thu, 25 Jun 2020 16:27:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy4GNBR1ZdvMFUOkwlxwZAQroVYLPZEr4d9Zx034wB53Vcqs3kVDg2G1TCwibuE143P5q6H X-Received: by 2002:a17:906:46cd:: with SMTP id k13mr171775ejs.312.1593127667562; Thu, 25 Jun 2020 16:27:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593127667; cv=none; d=google.com; s=arc-20160816; b=0irMam8u5E5BdIXS0IOWs3dGP1i5/taLTDqJq/Or6V26DjesyzxCjRM/ui1Tq1qMYs rMw+M7/S/LZpHbNLwdTJktnvWMonLsntiSVEMY+7ZEYCBBwrK1SFdE7CTdrI3Pda1TqY 3rVwJW1HcVcjvXKUedoRMk75wDWzaN4FNRBQ9eyiOxo95LKjStFdGEBYrFIUFgsK3Dvk 6xKhNQtGcxeco5Io35qsO/+2e3IU51hsPXJzu+1dTspLnJ5ieei6enl3NN65EUgZ5QIp GDu61CPhn9WAUHmvNuXpzxDlrDHL08XdhVEzwiqFV7bHpFvItNeb/FoI6C6+/KmIEN30 oKag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=nHvKfTnfJH0FHMSqyb1Yt7iToN5XmMPS8DWEQ3t4O90=; b=IIZv6Vm3sB9Xp6mQdKDzsIIzq2IoXjkd9wQSWlNdo13xodhgOWeJqWi70ekXATfKH2 gjTP15xjCqUF5viNTHAoVlLfhV31zqRI6z6p0nnmWqNw+u4LB1TqeXkCAoaNh55D5IWi 6p4K7CYxxK9z9aA/qjZEDWwUi74plQH8xIh6Gs76QVVclFLV6zz1KuxCp+gSrbyO0pAL O7x5J5JOAufD+ac/zKJSC+77DR/qVdNF/cT3F6aqm4zW+LV72Qdoa+TlvhcgA2YOUlaW 8vMWws5EdC5EZPx5bzGKQbLp6AY6nqHtHW69+1n7e0un6BezyR0Of/LOeZmwhDDFA0Gp nPWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e22si1245883ejb.66.2020.06.25.16.26.45; Thu, 25 Jun 2020 16:27:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390828AbgFYUMT (ORCPT + 99 others); Thu, 25 Jun 2020 16:12:19 -0400 Received: from mga12.intel.com ([192.55.52.136]:41702 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390575AbgFYUMQ (ORCPT ); Thu, 25 Jun 2020 16:12:16 -0400 IronPort-SDR: /KpMIHEjmyAHOTCOvbS5/Yp1Ov+t7NdXpvyIREgM9huyBHP34b3h4jYD2Kvj8bxiBv5DcalEbV hngo9hoh2FhQ== X-IronPort-AV: E=McAfee;i="6000,8403,9663"; a="124712828" X-IronPort-AV: E=Sophos;i="5.75,280,1589266800"; d="scan'208";a="124712828" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2020 13:12:14 -0700 IronPort-SDR: 3/h5lshevaYkf9k9GfMxmGa4KC/GEZ+r0sxQ5Ojx9FL0kZ60xlkU7/3/1ZSwkzqLJilXV+Pfzz MbpKSRgy37Sw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,280,1589266800"; d="scan'208";a="479596179" Received: from drews-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.49.247]) by fmsmga006.fm.intel.com with ESMTP; 25 Jun 2020 13:12:02 -0700 Date: Thu, 25 Jun 2020 23:11:56 +0300 From: Jarkko Sakkinen To: Borislav Petkov Cc: x86@kernel.org, linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Christopherson , Jethro Beekman , Serge Ayoun , akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com, asapek@google.com, cedric.xing@intel.com, chenalexchen@google.com, conradparker@google.com, cyhanish@google.com, dave.hansen@intel.com, haitao.huang@intel.com, josh@joshtriplett.org, kai.huang@intel.com, kai.svahn@intel.com, kmoy@google.com, ludloff@google.com, luto@kernel.org, nhorman@redhat.com, npmccallum@redhat.com, puiterwijk@redhat.com, rientjes@google.com, tglx@linutronix.de, yaozhangx@google.com Subject: Re: [PATCH v33 08/21] x86/sgx: Initialize metadata for Enclave Page Cache (EPC) sections Message-ID: <20200625201156.GA15394@linux.intel.com> References: <20200617220844.57423-1-jarkko.sakkinen@linux.intel.com> <20200617220844.57423-9-jarkko.sakkinen@linux.intel.com> <20200625101441.GC20319@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200625101441.GC20319@zn.tnic> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 25, 2020 at 12:14:41PM +0200, Borislav Petkov wrote: > On Thu, Jun 18, 2020 at 01:08:30AM +0300, Jarkko Sakkinen wrote: > > +static inline struct sgx_epc_section *sgx_get_epc_section( > > + struct sgx_epc_page *page) > > Just let it stick out - breaking lines on arg opening brace are the > ugliest. Also: > > bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning") > > Thx. > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette OK, I put everything into one line. /Jarkko