Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp107854ybt; Thu, 25 Jun 2020 16:37:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwEFEw/994NPBxKMIiV8/qqmF2pR4Pm0XhiCcxAFukHujAX2/DhJX/GDGNhpg6eYHRLjDgv X-Received: by 2002:a05:6402:22a5:: with SMTP id cx5mr711607edb.246.1593128263550; Thu, 25 Jun 2020 16:37:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593128263; cv=none; d=google.com; s=arc-20160816; b=BOOoCLmnwJHNVDkVjQeiZpGVQdwZxaogunJX/u0Qj28gcgPHk6ZSjHETxY9U7CKw4c Apvg8/5o5aTKSX2/E3x2C+04CwCG4Mt+xo99PnxjY5eFDOYtu73C1kbd5AtkdJo08XkJ AE5AJXGUs68X3FyD5hR+5VIXFxQ7a5vxY0AbS+m+V3bMdVz2ZwKQiaIBKa3EwbOD7P6H 2cHA9rFenr85dLvcUxHwbelUCscu9y2GduCvDgRexV1omcjB8jmCPm26PxDYy8qKcmBp TzsQlLfI33PMfPNRMccU4cB/lBH6qlYiYwtWy5jv9VVAsrFiLL3ZTmQGI6i59R3hAYsg XxWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id; bh=f/MxA/RfSVhadLBtnVnzuA+Lz/0a0EPiXjuvyGnykbc=; b=C7bcR3RCIVL1GNgfOpTtcCLAxpTQp+NO1CFb5gWnV2eLAq5+Vu7BorpyfxwBs0YK2m zcauW0xZ4OJZndRB0jQEecmcFuOszUq316icJlJ8ciKTK5spocvTa1rgch7FX8JDbdRt y1KhGyKv1hkQL4QDgmBdUp3aC246Ii9sUXUJktnuv+ki4VTdvBIaBSKPLIsBshb7WHOn dIlRi785si5+co659lFVtWJOzLhvcrwLm0VGZI9E1SiEW7Jkeu2UrqWJdCEi1Oznrl36 4uGhFE2exbByGMY2M6LvuGDn+g1Ot+I3RipmUrafme3g1dDUAESTdGOVKcV4HgRZJ+ah 54vQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k14si4216847ejs.400.2020.06.25.16.37.20; Thu, 25 Jun 2020 16:37:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405919AbgFYVUi (ORCPT + 99 others); Thu, 25 Jun 2020 17:20:38 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:46974 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403817AbgFYVUh (ORCPT ); Thu, 25 Jun 2020 17:20:37 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 05PL1x5A103989; Thu, 25 Jun 2020 17:20:34 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 31vts12r79-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Jun 2020 17:20:33 -0400 Received: from m0098409.ppops.net (m0098409.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 05PLKXta157749; Thu, 25 Jun 2020 17:20:33 -0400 Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 31vts12r6g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Jun 2020 17:20:33 -0400 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 05PL5eQ7003898; Thu, 25 Jun 2020 21:20:31 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma03fra.de.ibm.com with ESMTP id 31uusgh33s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Jun 2020 21:20:30 +0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 05PLKSB962849460 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Jun 2020 21:20:28 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 94A5542049; Thu, 25 Jun 2020 21:20:28 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5587F4204C; Thu, 25 Jun 2020 21:20:27 +0000 (GMT) Received: from localhost.localdomain (unknown [9.85.142.225]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 25 Jun 2020 21:20:27 +0000 (GMT) Message-ID: <1593120026.27152.400.camel@linux.ibm.com> Subject: Re: [PATCH 09/12] ima: Use correct type for the args_p member of ima_rule_entry.lsm elements From: Mimi Zohar To: Tyler Hicks , Dmitry Kasatkin Cc: James Morris , "Serge E . Hallyn" , Lakshmi Ramasubramanian , Prakhar Srivastava , linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org Date: Thu, 25 Jun 2020 17:20:26 -0400 In-Reply-To: <20200623003236.830149-10-tyhicks@linux.microsoft.com> References: <20200623003236.830149-1-tyhicks@linux.microsoft.com> <20200623003236.830149-10-tyhicks@linux.microsoft.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687 definitions=2020-06-25_16:2020-06-25,2020-06-25 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 cotscore=-2147483648 adultscore=0 mlxscore=0 malwarescore=0 clxscore=1015 phishscore=0 suspectscore=0 spamscore=0 impostorscore=0 priorityscore=1501 mlxlogscore=999 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006250120 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-06-22 at 19:32 -0500, Tyler Hicks wrote: > Make args_p be of the char pointer type rather than have it be a void > pointer that gets casted to char pointer when it is used. It is a simple > NUL-terminated string as returned by match_strdup(). > > Signed-off-by: Tyler Hicks Thanks! Mimi