Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp113514ybt; Thu, 25 Jun 2020 16:48:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyoGycDvJhiRO6esSM63PJk+FzFxo88ame3yKuSjitklj+dexFnFoeEoyC7Z7udeSkc9WvO X-Received: by 2002:a05:6402:6c4:: with SMTP id n4mr691856edy.353.1593128906632; Thu, 25 Jun 2020 16:48:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593128906; cv=none; d=google.com; s=arc-20160816; b=mrAk1o9NK2Xyap/74D06HvrO7+bE5YGWFNyyhImeMneEsSCybRuzag/ytGJdqiJ2f3 w92LNRWNdNrc4tnQg/Dpzv4DsB2v9TLCpC/TTENekui11deiNwY+7seQKvL1rW2EziHj BTXnIMqlAJpHuo0adAXBVFLTMsVAoUXj65cxYbC7FdBKaLVuqs5RsDECyNMYS5um9UNs l792u3VPTUj1LlxvWmIcQS8zXwntZna+w9YNmBUJKghFrsyiAg/z8O5zh12YUduPxDOE P3B9aXULXiyzm64yQl2ydkC+pw/gS0KRo/qJFvtr42sYMdlNoNkLgUb83Xx9f94s4Zjc Nkrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=HiC4BtBcvypNi0TT+uKmaMyQomfNIooMQQ9SMeSvJuE=; b=P71N8mNcdFBa78EOgBQJS2pv2PKKENGstJVrZrPGIBEVQaWk9eCcd2PdZisJalnf6P XsIHLy1eclSyOjDrKc1JqA4/J1xYLGZzpG3RhzWP/9zcaru1pTWgMfifGQC4YaG7inje tkPKseTEtu7LOjWenYmoZgQi3hCGApHU/PYPKUxC4wnZw4sTBn+lf57i27A2nsCRsUil cYktUSEW3yCGtqVHZ9gTRmivyGe4dDJVNHk0+RDZHmTg2LwtO8jPo1kGBsFeWGb8o1Wn SBPaJ6a0sGC1opCXJ/0cihJeu5MPs4NYXdwWM1WV9OgXBskg7sstIPQLF9tli2qITAAS Zh6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=hQeh5IvC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f12si9014113ejx.143.2020.06.25.16.48.03; Thu, 25 Jun 2020 16:48:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=hQeh5IvC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404523AbgFYWVd (ORCPT + 99 others); Thu, 25 Jun 2020 18:21:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403905AbgFYWVa (ORCPT ); Thu, 25 Jun 2020 18:21:30 -0400 Received: from mail-ua1-x92f.google.com (mail-ua1-x92f.google.com [IPv6:2607:f8b0:4864:20::92f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F269C08C5C1 for ; Thu, 25 Jun 2020 15:21:30 -0700 (PDT) Received: by mail-ua1-x92f.google.com with SMTP id l24so2394185uar.10 for ; Thu, 25 Jun 2020 15:21:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HiC4BtBcvypNi0TT+uKmaMyQomfNIooMQQ9SMeSvJuE=; b=hQeh5IvCT9+c5THqtc6WWb2AHU0aYgWF5ReZ+qFjCCpfIqgW19aaZnB90R90eRy0XI aqqBosgZeXnP5zp2JACRzpjqBvLLkUVWfrSy6pNESy7bXlN8NAGyTcPtiDfqcYQkAXxh Dtax+BMxyCZeltX5LaizJxMHd1OeZVgKaCSgM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HiC4BtBcvypNi0TT+uKmaMyQomfNIooMQQ9SMeSvJuE=; b=ezZxIlE/0O21AOnQIMEKuA/tJyH062iyJ7ge7x8CK5fxyk74PAFcjhoipKF18fbwD1 Bewp5fqzBj5spwJff1FSzCIURsPB70cvNZgh2sr4kGMxaR4PO76qC3zUvFl/ujEN6sCk OJytkXG0dAHCDfmFqG8yrCRPo9S0be0MeDtdv/quQhiUn2K6fI+VQRKvQL+3Bp1I7rJb eodzNiQjteTzKJoBxxcn0gAzjd4Mvm4geRbT0RnznVVH3/ixMwdKOXmGad8yXl9LO6eM EIS9ngVLPMu9gF2EubdhRldIde3ZHKeItzLe2R0JUIGXxzaR0+1ckNTYSV+/n6O1DXX2 sz8Q== X-Gm-Message-State: AOAM533o99qOQNJZd8eNoBeX+yGnrHKl9ATIdH6Z00K8Gds7X6ms8/p7 uiCoIVCGF0tVqbzaMznEf761VltwiV0= X-Received: by 2002:ab0:7849:: with SMTP id y9mr105655uaq.56.1593123689085; Thu, 25 Jun 2020 15:21:29 -0700 (PDT) Received: from mail-vs1-f52.google.com (mail-vs1-f52.google.com. [209.85.217.52]) by smtp.gmail.com with ESMTPSA id e14sm1010421vsa.33.2020.06.25.15.21.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jun 2020 15:21:27 -0700 (PDT) Received: by mail-vs1-f52.google.com with SMTP id o15so4435468vsp.12 for ; Thu, 25 Jun 2020 15:21:27 -0700 (PDT) X-Received: by 2002:a05:6102:20c8:: with SMTP id i8mr347826vsr.106.1593123686688; Thu, 25 Jun 2020 15:21:26 -0700 (PDT) MIME-Version: 1.0 References: <1593087419-903-1-git-send-email-kalyan_t@codeaurora.org> In-Reply-To: <1593087419-903-1-git-send-email-kalyan_t@codeaurora.org> From: Doug Anderson Date: Thu, 25 Jun 2020 15:21:15 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v2] drm/msm/dpu: add support for dither block in display To: Kalyan Thota Cc: dri-devel , linux-arm-msm , freedreno , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Rob Clark , Sean Paul , "Kristian H. Kristensen" , mkrishn@codeaurora.org, travitej@codeaurora.org, nganji@codeaurora.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Jun 25, 2020 at 5:17 AM Kalyan Thota wrote: > > This change enables dither block for primary interface > in display. > > Enabled for 6bpc in the current version. > > Changes in v1: > - Remove redundant error checks (Rob). > > Signed-off-by: Kalyan Thota > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 39 +++++++++++++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 63 +++++++++++++++++++++---- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 28 +++++++++++ > 3 files changed, 121 insertions(+), 9 deletions(-) Tested-by: Douglas Anderson