Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp119231ybt; Thu, 25 Jun 2020 16:59:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxMQi1/ZzoTEUs77aarBWiPNAszMOQhzBRA9QiNKDB74NIrB25CCN9uI+YVdsGQvxKEv1/m X-Received: by 2002:a17:906:35cd:: with SMTP id p13mr258692ejb.172.1593129559976; Thu, 25 Jun 2020 16:59:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593129559; cv=none; d=google.com; s=arc-20160816; b=Dl34KM7rjwlNOZfZg20IFhAibPTunOzWyGqeqqRPJwbI/EhU/UtPK/Qs2iDSSn7Cin O99h3fdTsitfkGDUrAcMBcoNUMZSksczV+7TlaZxw+YnYGO5SMQcYC3nJAxIzgloEdNb dQ/ynOH80eWX8xugrBjs9hvY2gYHwOapngiPBwgxjKK/Bhltjz0co8dAtnDRjYxP+tjd BE4B291ym4rIjvUy0ymv+argOpBHrc1OrSVuTDGYiwiIyFtid+JyzRDkt5PwqaAunyPi Dr5rSVgzS4wMG8Vn+piBhD8/Ltzs16X+ATSThcaEMNBhE950ky+WKD6cfHOISMrkodsR czeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=wcg6bLKAHJ0/BxsC+brekPNOiBl21FKQYq+hY1Ge/R8=; b=ZiSueHEAURcKUz1ybi3IyhZ7I4AwFNrANz7QwSTZ+mXlhUhVPSHPM+1BXx0+fIm1+L 71d+Gl7btagHkhYoilN30STGfGy/ecBphKO8jAA4NbqDnK9KuFXvUvxB1SXfqXDXZBwv ttOcbc8lzYC2VxjH1RbVpznK7kZ34066ans4wcWL7rJBewSIEwCaJ/0n79MTBVY8xDn4 12O1bOQZ7v5B/eYVTwqaw/eG1HKlcdnzDqPjEpuw0W/d9FPRDvG2C1Hn2Te8kbLiSJIC sMKejITPQK1m05ySft/xXDOLjyYXoIIVwPIQnHENK2CtK0G6g68uQ58O9tCAE6Zdx0i7 /I0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="BC5QnNm/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k4si3406542eds.446.2020.06.25.16.58.57; Thu, 25 Jun 2020 16:59:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="BC5QnNm/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390907AbgFYX0f (ORCPT + 99 others); Thu, 25 Jun 2020 19:26:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390262AbgFYX0e (ORCPT ); Thu, 25 Jun 2020 19:26:34 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEEC0C08C5DB for ; Thu, 25 Jun 2020 16:26:34 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id u185so1752000pfu.1 for ; Thu, 25 Jun 2020 16:26:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wcg6bLKAHJ0/BxsC+brekPNOiBl21FKQYq+hY1Ge/R8=; b=BC5QnNm/L9fi0/7m8QzEN2dxwRm+UEWAUD0wfyKtJN3dH3RSF2OfNu+WtclANsPrj0 tccUpSmsJU6AXH4UrZsO6uoZhCt2UkUkc+F3mD5CpUKXZYyuWLUNOGBNl2XGZYTF3WZr ijY/VFyXQ74HchwLZNMFyPvcLQOxOcA/UoQ0M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wcg6bLKAHJ0/BxsC+brekPNOiBl21FKQYq+hY1Ge/R8=; b=r8Sh7lndVNQAQCedDQbcaMziCc/pX94iRAEUUzOY0A1jqNAWabFzPOr59t+S2HTlSo H2+DTGd/Ou8umnYRyQCU1UyLysqSQFjHPhnj7/Ov6Llye0NwibIjE2/HnoAIlu/z7bg8 hZTCgDUiRwmOhnVkvsx35ZbbBP5aM0XltXybgajYmXqsjuuFEwNbcECMV3H1k6sE8eMH yxODcWe4MfFaNCpedlfJv0qgyfLFbyn3dVvmH0XFQWZZ2gnSXl9vRyjYehqfwanUmBTt S2PNFVydheyZFPn20SIzd4dXclhVj6wg5ndqUyGXWLhqAe5/j9KnbQ+KNzfYLTTj5PuL nXVQ== X-Gm-Message-State: AOAM533Y6N6vFLU2u8Qsfa1SPPtu/4gUbj/R0jlDsoZNwUsph0pMV9UT n5Eo2Wr1VZZYT0JhPDRUCgKNZAsLm/E= X-Received: by 2002:a63:182:: with SMTP id 124mr232820pgb.288.1593127594156; Thu, 25 Jun 2020 16:26:34 -0700 (PDT) Received: from apsdesk.mtv.corp.google.com ([2620:15c:202:1:e09a:8d06:a338:aafb]) by smtp.gmail.com with ESMTPSA id f207sm8901936pfa.107.2020.06.25.16.26.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 16:26:33 -0700 (PDT) From: Abhishek Pandit-Subedi To: marcel@holtmann.org, Oliver Neukum , linux-bluetooth@vger.kernel.org Cc: chromeos-bluetooth-upstreaming@chromium.org, linux-pm@vger.kernel.org, Abhishek Pandit-Subedi , Johan Hedberg , linux-kernel@vger.kernel.org Subject: [PATCH] Bluetooth: btusb: Comment on unbalanced pm reference Date: Thu, 25 Jun 2020 16:26:27 -0700 Message-Id: <20200625162544.1.Iea2fbf7a284191c0f09c2ffbe8c14b872d0f68b2@changeid> X-Mailer: git-send-email 2.27.0.111.gc72c7da667-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a comment clarifying that a PM reference in btusb_qca_cmd_timeout is not unbalanced because it results in a device reset. Signed-off-by: Abhishek Pandit-Subedi --- drivers/bluetooth/btusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index f8a71fdabb3d1b..0e143c0cecf2a1 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -581,6 +581,7 @@ static void btusb_qca_cmd_timeout(struct hci_dev *hdev) return; bt_dev_err(hdev, "Multiple cmd timeouts seen. Resetting usb device."); + /* This is not an unbalanced PM reference since the device will reset */ err = usb_autopm_get_interface(data->intf); if (!err) usb_queue_reset_device(data->intf); -- 2.27.0.111.gc72c7da667-goog