Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 4/4] KVM: SVM: Rename svm_nested_virtualize_tpr() to
 nested_svm_virtualize_tpr()
To:     Joerg Roedel <joro@8bytes.org>, Paolo Bonzini <pbonzini@redhat.com>
Cc:     Sean Christopherson <sean.j.christopherson@intel.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Joerg Roedel <jroedel@suse.de>
References: <20200625080325.28439-1-joro@8bytes.org>
 <20200625080325.28439-5-joro@8bytes.org>
From:   Krish Sadhukhan <krish.sadhukhan@oracle.com>
Message-ID: <3d8aa359-a43c-a080-5d62-3bf1300e1ee1@oracle.com>
Date:   Thu, 25 Jun 2020 16:28:21 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <20200625080325.28439-5-joro@8bytes.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 6/25/20 1:03 AM, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
>
> Match the naming with other nested svm functions.
>
> No functional changes.
>
> Signed-off-by: Joerg Roedel <jroedel@suse.de>
> ---
>   arch/x86/kvm/svm/svm.c | 6 +++---
>   arch/x86/kvm/svm/svm.h | 2 +-
>   2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
> index e0b0321d95d4..b0d551bcf2a0 100644
> --- a/arch/x86/kvm/svm/svm.c
> +++ b/arch/x86/kvm/svm/svm.c
> @@ -3040,7 +3040,7 @@ static void update_cr8_intercept(struct kvm_vcpu *vcpu, int tpr, int irr)
>   {
>   	struct vcpu_svm *svm = to_svm(vcpu);
>   
> -	if (svm_nested_virtualize_tpr(vcpu))
> +	if (nested_svm_virtualize_tpr(vcpu))
>   		return;
>   
>   	clr_cr_intercept(svm, INTERCEPT_CR8_WRITE);
> @@ -3234,7 +3234,7 @@ static inline void sync_cr8_to_lapic(struct kvm_vcpu *vcpu)
>   {
>   	struct vcpu_svm *svm = to_svm(vcpu);
>   
> -	if (svm_nested_virtualize_tpr(vcpu))
> +	if (nested_svm_virtualize_tpr(vcpu))
>   		return;
>   
>   	if (!is_cr_intercept(svm, INTERCEPT_CR8_WRITE)) {
> @@ -3248,7 +3248,7 @@ static inline void sync_lapic_to_cr8(struct kvm_vcpu *vcpu)
>   	struct vcpu_svm *svm = to_svm(vcpu);
>   	u64 cr8;
>   
> -	if (svm_nested_virtualize_tpr(vcpu) ||
> +	if (nested_svm_virtualize_tpr(vcpu) ||
>   	    kvm_vcpu_apicv_active(vcpu))
>   		return;
>   
> diff --git a/arch/x86/kvm/svm/svm.h b/arch/x86/kvm/svm/svm.h
> index 003e89008331..8907efda0b0a 100644
> --- a/arch/x86/kvm/svm/svm.h
> +++ b/arch/x86/kvm/svm/svm.h
> @@ -365,7 +365,7 @@ void svm_set_gif(struct vcpu_svm *svm, bool value);
>   #define NESTED_EXIT_DONE	1	/* Exit caused nested vmexit  */
>   #define NESTED_EXIT_CONTINUE	2	/* Further checks needed      */
>   
> -static inline bool svm_nested_virtualize_tpr(struct kvm_vcpu *vcpu)
> +static inline bool nested_svm_virtualize_tpr(struct kvm_vcpu *vcpu)
>   {
>   	struct vcpu_svm *svm = to_svm(vcpu);
>   
Should the name be changed to svm_nested_virtualized_tpr ?  Because 
svm_nested_virtualize_tpr implies that the action of the function is to 
virtualize the TPR.