Date: Wed, 29 Mar 2006 00:41:22 +0200
From: Alessandro Zummo <alessandro.zummo@towertech.it>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: Added support for ds1672 control
Message-ID: <20060329004122.64e91176@inspiron>
In-Reply-To: <08A09790-5D74-4089-AA7B-6AB5628A19DD@kernel.crashing.org>
References: <Pine.LNX.4.44.0603281507050.20373-100000@gate.crashing.org>
	<20060328234027.26b5602b@inspiron>
	<08A09790-5D74-4089-AA7B-6AB5628A19DD@kernel.crashing.org>
Organization: Tower Technologies
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1111
Lines: 42

On Tue, 28 Mar 2006 16:04:20 -0600
Kumar Gala <galak@kernel.crashing.org> wrote:

> Not sure if I follow you here.  I think you are suggesting for  
> ds1672_get_control to look like:
> 
> static int ds1672_get_control(struct i2c_client *client, u8 *status)
> {
>          unsigned char addr = DS1672_REG_CONTROL;
> 
>          struct i2c_msg msgs[] = {
>                  { client->addr, 0, 1, &addr },          /* setup  
> read ptr */
>                  { client->addr, I2C_M_RD, 1, status },  /* read  
> control */
>          };
> ...
> }

 yes.


> which is fine.  Any suggestions on what to do on an error in the  
> sysfs attrib function?

 i2c_transfer will give the errno to return back.
 This remembers me that I forgot to do that in other drivers :(

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Turin, Italy

  http://www.towertech.it

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/