Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] dt-bindings: mfd: Add DT compatible string
 "google,cros_ec_uart"
To:     Bhanu Prakash Maiya <bhanumaiya@chromium.org>,
        linux-arm-kernel@lists.infradead.org
Cc:     Benson Leung <bleung@chromium.org>,
        Guenter Roeck <groeck@chromium.org>,
        linux-kernel@vger.kernel.org, "Lee Jones )" <lee.jones@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Raul E Rangel <rrangel@chromium.org>,
        Furquan Shaikh <furquan@chromium.org>,
        Duncan Laurie <dlaurie@google.com>,
        Eric Peers <epeers@google.com>, devicetree@vger.kernel.org,
        Bhanu Prakash Maiya <bhanumaiya@google.com>
References: <20200625131432.1.Icb23b633700f1ef4d123e3f21fd26fad21a3f207@changeid>
 <20200625131432.2.Icfeab15fa04daaffc61280faf5a75cd9b23ee822@changeid>
From:   Enric Balletbo i Serra <enric.balletbo@collabora.com>
Message-ID: <8ef4bb35-b2c8-ffdf-cefc-38c0d43d89e9@collabora.com>
Date:   Fri, 26 Jun 2020 10:42:29 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <20200625131432.2.Icfeab15fa04daaffc61280faf5a75cd9b23ee822@changeid>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Bhanu,

Thank you for the patch.

On 25/6/20 23:34, Bhanu Prakash Maiya wrote:
> Add DT compatible string in
> Documentation/devicetree/bindings/mfd/cros_ec.txt
> 
> Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@google.com>
> ---
> 
>  Documentation/devicetree/bindings/mfd/cros-ec.txt | 9 +++++++--

txt bindings are somewhat deprecated now, this specific binding was already
converted to the new json-schema, although didn't land yet, you should base your
changes on that, you can pick the following patch:

https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20200306085513.76024-1-ikjn@chromium.org/

Also, the kernel test robot, reported a build problem, so fix the problems on
the second version.

Thanks,
 Enric


>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/cros-ec.txt b/Documentation/devicetree/bindings/mfd/cros-ec.txt
> index 4860eabd0f729..ec8c5d7ecc266 100644
> --- a/Documentation/devicetree/bindings/mfd/cros-ec.txt
> +++ b/Documentation/devicetree/bindings/mfd/cros-ec.txt
> @@ -3,7 +3,7 @@ ChromeOS Embedded Controller
>  Google's ChromeOS EC is a Cortex-M device which talks to the AP and
>  implements various function such as keyboard and battery charging.
>  
> -The EC can be connect through various means (I2C, SPI, LPC, RPMSG) and the
> +The EC can be connect through various means (I2C, SPI, UART, LPC, RPMSG) and the
>  compatible string used depends on the interface. Each connection method has
>  its own driver which connects to the top level interface-agnostic EC driver.
>  Other Linux driver (such as cros-ec-keyb for the matrix keyboard) connect to
> @@ -17,6 +17,10 @@ Required properties (SPI):
>  - compatible: "google,cros-ec-spi"
>  - reg: SPI chip select
>  
> +Required properties (UART):
> +- compatible: "google,cros-ec-uart"
> +- reg: UART baudrate, flowcontrol
> +
>  Required properties (RPMSG):
>  - compatible: "google,cros-ec-rpmsg"
>  
> @@ -72,5 +76,6 @@ spi@131b0000 {
>  	};
>  };
>  
> -
>  Example for LPC is not supplied as it is not yet implemented.
> +
> +Example for UART is not supplied as it is not yet implemented.
>