Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Vabhav Sharma (OSS)" <vabhav.sharma@oss.nxp.com>
To:     Greg KH <gregkh@linuxfoundation.org>,
        "Vabhav Sharma (OSS)" <vabhav.sharma@oss.nxp.com>
CC:     "jslaby@suse.com" <jslaby@suse.com>,
        "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Varun Sethi <V.Sethi@nxp.com>
Subject: RE: [PATCH] tty: serial: fsl_lpuart: minimum baud rate support
Thread-Topic: [PATCH] tty: serial: fsl_lpuart: minimum baud rate support
Thread-Index: AQHWS6uMK90atu7fKkiLW+wqBK+01g==
Date:   Fri, 26 Jun 2020 11:18:42 +0000
Message-ID: <VI1PR04MB48009D6DE5C96EFB7FF559F7F3930@VI1PR04MB4800.eurprd04.prod.outlook.com>
References: <1593078545-11272-1-git-send-email-vabhav.sharma@oss.nxp.com>
 <20200625100410.GA3327034@kroah.com>
 <VI1PR04MB4800F6C28186CE70F3E1D197F3920@VI1PR04MB4800.eurprd04.prod.outlook.com>
 <20200625105256.GA3335222@kroah.com>
In-Reply-To: <20200625105256.GA3335222@kroah.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [103.49.154.18]
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: b73f394d-f30f-4d5d-bd18-08d819c2aef4
x-ms-traffictypediagnostic: VI1PR04MB4335:
x-ms-exchange-sharedmailbox-routingagent-processed: True
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <VI1PR04MB43357E2CEDE2F6C5366F5B87B2930@VI1PR04MB4335.eurprd04.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-forefront-prvs: 0446F0FCE1
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: gjcIpodNWLqOrfjGnBGC0OvKw5trJdej3MQlt3XlcOW8dWAaEFEGBA9gA7u2j7uR1l8UIcUrXX/BsN26DfGKI/3kadW4V5geQoz03mKsz+0QC9EFhKbf640GWtCaZnu1jXdaZXL2V4qd9vxfxDTgi9HVFJbZApRadyjrqhgNvFtaqRkv9UBsKqgypH/aTPOUysta/iQa0yA4lEa+0i95T+/krJ06WRJINqMMQqsDTAMMaV7QHVgA1mANYjK8zu14wz1OAtnVGBUR0UfgOCqYQmgIsMuztvAaqkJrK3sLc4mI5fjS0W5ljh/Eo5gHq6RXohsHGEcIS+cFPnSb7pl7CQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB4800.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(136003)(396003)(366004)(376002)(39860400002)(66946007)(8676002)(53546011)(66556008)(71200400001)(66446008)(66476007)(316002)(86362001)(64756008)(54906003)(4326008)(83380400001)(2906002)(26005)(8936002)(7696005)(33656002)(186003)(9686003)(110136005)(6506007)(478600001)(5660300002)(55016002)(52536014)(76116006);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata: 2CIHuDmVjW5YjEaB5vCLsY+0fcgO40QgLYC2UcH8QP8SgnDo92/hlhhiT8ptB2/A2emJo//JPqky93yxp/VKm30ZtTXD40x515tZiwE6+vfxS4Cziapv6YxvxT5BDZENCFzcmd6esxTYYbbAQbaro+ChCZmhSFC9asf1HYvCD09a51UE+LJOcbHQXx3geC1TONLQcKfK8Y84OMcEfZgay2/xz4aoWDN0geGFMup4nQBAkOUBi/GXLLtXxb4nqUvrsFHLtwySIaZgP6Ng7ZmWWRDFIFgvZZwnzccYqSZxcaMiakI0roZnhfKkGg+b9TxR0ZW7wUqRVb21BFQU56EROYOuZOaCve0GPzQG9mpQLQL0CJmXpScKktQU7kGM2W0L0wCnL84gk3shPqKMULW5DKlNrBACH97hOOA/hTIVqw3BWQRiipedf6KgHKELK2vD45TSnW2RPCKDSpka29+RGxNj3rBMZnWXHNLpCLmc23E=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4800.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b73f394d-f30f-4d5d-bd18-08d819c2aef4
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jun 2020 11:18:42.1740
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: O66TgWHhVTpYxkp69xKpQfa3+cRktqVL9f9MpnEbBIFvOAn1onXIPa/+saqEYkxIJzJA52Y0oNr2mKaD9C5rtQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4335
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Thursday, June 25, 2020 4:23 PM
> To: Vabhav Sharma (OSS) <vabhav.sharma@oss.nxp.com>
> Cc: jslaby@suse.com; linux-serial@vger.kernel.org; linux-
> kernel@vger.kernel.org; Varun Sethi <V.Sethi@nxp.com>
> Subject: Re: [PATCH] tty: serial: fsl_lpuart: minimum baud rate support
>=20
> On Thu, Jun 25, 2020 at 10:12:54AM +0000, Vabhav Sharma (OSS) wrote:
> >
> >
> > > -----Original Message-----
> > > From: Greg KH <gregkh@linuxfoundation.org>
> > > Sent: Thursday, June 25, 2020 3:34 PM
> > > To: Vabhav Sharma (OSS) <vabhav.sharma@oss.nxp.com>
> > > Cc: jslaby@suse.com; linux-serial@vger.kernel.org; linux-
> > > kernel@vger.kernel.org; Varun Sethi <V.Sethi@nxp.com>; Vabhav
> Sharma
> > > <vabhav.sharma@nxp.com>
> > > Subject: Re: [PATCH] tty: serial: fsl_lpuart: minimum baud rate
> > > support
> > >
> > > On Thu, Jun 25, 2020 at 03:19:05PM +0530, Vabhav Sharma wrote:
> > > > From: Vabhav Sharma <vabhav.sharma@nxp.com>
> > > >
> > > > The formula for the baud rate is
> > > > baud rate =3D "baud clock / ((OSR+1) =D7 SBR)
> > > >
> > > > Algorithm used in function lpuart32_serial_setbrg() only changes
> > > > the SBR. Even with maxmum value put in, OSR stays at 0x7 and the
> > > > lowest baud rate would be ~ 2600 bps
> > > >
> > > > Update the algorithm to allow driver operation at 1200,2400 or
> > > > 600 bps
> > > >
> > > > Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
> > > > ---
> > > >  drivers/tty/serial/fsl_lpuart.c | 4 ++++
> > > >  1 file changed, 4 insertions(+)
> > > >
> > > > diff --git a/drivers/tty/serial/fsl_lpuart.c
> > > > b/drivers/tty/serial/fsl_lpuart.c index 90298c4..0fd0fa5f 100644
> > > > --- a/drivers/tty/serial/fsl_lpuart.c
> > > > +++ b/drivers/tty/serial/fsl_lpuart.c
> > > > @@ -1925,6 +1925,10 @@ static void __lpuart32_serial_setbrg(struct
> > > uart_port *port,
> > > >  			tmp_sbr++;
> > > >  		}
> > > >
> > > > +		if (tmp_sbr > UARTBAUD_SBR_MASK) {
> > > > +			continue;
> > > > +		}
> > >
> > > Always use scripts/checkpatch.pl on your patches so you do not get
> > > grumpy emails from maintainers telling you to use
> > > scripts/checkpatch.pl on your patches...
> > Indeed, I run the script before sending patch ./scripts/checkpatch.pl
> > 0001-tty-serial-fsl_lpuart-minimum-baud-rate-support.patch
> > total: 0 errors, 0 warnings, 10 lines checked
> >
> > 0001-tty-serial-fsl_lpuart-minimum-baud-rate-support.patch has no
> obvious style problems and is ready for submission.
>=20
> Ok, then something is wrong as there is obviously a coding style issue wi=
th
> your submission, as you can see with a manual review of it, right?
>=20
> greg k-h
I see, Unnecessary usage of brace for single statement.
Thank you