Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vabhav Sharma <vabhav.sharma@oss.nxp.com>
To:     gregkh@linuxfoundation.org, jslaby@suse.com,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     v.sethi@nxp.com, Vabhav Sharma <vabhav.sharma@nxp.com>
Subject: [PATCH v2] tty: serial: fsl_lpuart: minimum baud rate support
Date:   Fri, 26 Jun 2020 16:50:34 +0530
Message-Id: <1593170434-13524-1-git-send-email-vabhav.sharma@oss.nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from uefi-OptiPlex-790.ap.freescale.net (92.120.0.71) by SG2PR06CA0220.apcprd06.prod.outlook.com (2603:1096:4:68::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3109.23 via Frontend Transport; Fri, 26 Jun 2020 11:26:08 +0000
X-Mailer: git-send-email 1.9.1
X-Originating-IP: [92.120.0.71]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: a2ea0ad5-963e-4dcf-11b9-08d819c3ba16
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3919:
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VI1PR0402MB3919E3C333B9DD62A0837F22B2930@VI1PR0402MB3919.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-Forefront-PRVS: 0446F0FCE1
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 64cyEayee3Fnnykd/Ammn6H0f27sKLusTewBtnjDgVoZVEkuT5jeoL0TYkdm1cx+CUJYoCgQkgRe/GvYlesI2xeSgI9Ir4oJYoK4AvygaLIRzfGkZWljpT+wrZKx0LVzkC++R7gPI6W+TUXoFysULJi4WnhoF/4qrveKY9AbcVfKMUnE0O+bEBHeszlvXe4VDnygkwqhRtAqgynUfNNr5JlURQjak6XuU1zycHPRJy/5mdi6ijgzz8PCPYVCMi0x1mSYDynGOnU8hd6ZbElss/+DIiCh1xRWkwxH4MaM7fvrNW4u1bqkpO7IAQGS0WZc
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB4800.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(366004)(396003)(346002)(376002)(39860400002)(4744005)(83380400001)(316002)(5660300002)(66476007)(16526019)(186003)(86362001)(26005)(66946007)(6512007)(66556008)(2906002)(8676002)(6486002)(478600001)(6506007)(8936002)(52116002)(956004)(44832011)(2616005)(4326008)(6666004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: upLKRB/a3Sl9t1Ue/M+ml/K2q7RuGXRx1mxbDP4t6G4ldVmZBbTH+2eU5asaU5qml+Hg07JzSBvD1CNSyU3+Pqa4OpshW4y/f1B3zJqCENNAkpB0ez2hSd1NseYwgd7XHU8mNFN7lZPMRw9+uD86Ei73Hp8DQo0a6+RKxILfS1lOvIaA0e43PLTaB5o7HHQ1ZDldgMHAQ2VBNJIuN14cT7Od1JGQ9V9VRpHO0xqBevsm+hj7tGi9646uZvNwIXTDqhRKhhlv2jmyldu8h5+gNnnYnccy5tFeiSG6wQKEADoDb+lOEQYibSm+dAsxksUPIgX9TLaOS2eJqU1LrweTJ2Cps5yhJ9+GQ4RhiIswfYxiHsNVDXc5ZnJR5yqdqCLJmZTrsKRTNHyH5Tbo7TUhTEjtrzTBVBVyb3OlfaGSQU3wZte0N+JfIspdM0Rhxixp4EQUOSIbWvrITqetg+QqkrcuKFiMV2KdcCzJ68R2qHA=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a2ea0ad5-963e-4dcf-11b9-08d819c3ba16
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4800.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2020 11:26:10.7069
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 66xXmHhZUAI/lvf0KmzDSolS0ajbhDcBPkvpfyLT3lzJ8NCf1EEt3UQRIWWPykrqeVwDuTk2WyEiECj2uXUn8A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3919
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Vabhav Sharma <vabhav.sharma@nxp.com>

The formula for the baud rate is
baud rate = "baud clock / ((OSR+1) × SBR)

Algorithm used in function lpuart32_serial_setbrg() only changes
the SBR. Even with maxmum value put in, OSR stays at 0x7 and the
lowest baud rate would be ~ 2600 bps

Update the algorithm to allow driver operation at 1200,2400 or 600 bps

Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
---
V2:
 - Incorporated review comment from Greg
---
 drivers/tty/serial/fsl_lpuart.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index 90298c4..7ca6422 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -1925,6 +1925,9 @@ static void __lpuart32_serial_setbrg(struct uart_port *port,
 			tmp_sbr++;
 		}
 
+		if (tmp_sbr > UARTBAUD_SBR_MASK)
+			continue;
+
 		if (tmp_diff <= baud_diff) {
 			baud_diff = tmp_diff;
 			osr = tmp_osr;
-- 
2.7.4