Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp524567ybt; Fri, 26 Jun 2020 05:25:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy86XuhyO5waJkC8olJmOJLCerB80CJIYwcsTkwyVmRmSZh56kZW1hjgEoliSux3BTxphOq X-Received: by 2002:a17:906:a1cc:: with SMTP id bx12mr2204190ejb.461.1593174341524; Fri, 26 Jun 2020 05:25:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593174341; cv=none; d=google.com; s=arc-20160816; b=tdrfoSZzGhCI1qqeAEznCKVHVsi6UqPhN2T7MfWJNf3MnNXegQ1DyyLnK9LEH+x9Q1 Z7z9W0zxL7k1VRGq3b8AQy/jBSz9fOUIjKNTKtmGKUBTnAO5iZGvIW0UJvtEO8KHEpBr OI/DTngAjU9iIwWsTAXtlBzu5cKcWDFhXkOlWrID9W6UDKEd6FdtEVLAq66sMXNOF/xx 7Dea+kvOMcssvzSktBRNQpLWT7yJ29ImilZotEN576b/0NJivRv3RObAmbMbc36f0AX/ VG6Xj21LPTnQE1XjAHZknrbNNYk3uTkyNjjdogldqZnviIsesUwPlSfl9xO+ApmFYZyw 5JNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=XqpPxaLgj+8G3qgnOsLPntGf7hGD9ApNPwp5v2TWMCw=; b=eOenBLBeIVhurwYSGS2xFMyPJxpqK2cmCne869v/zbg4oV2sVzGuPRM4DLbLMEYgT/ K+FqcWaAPGYntgNIc23H2g4uQCKTIeK6fEJmLqPR/wM6hsxPCFQrmUg+bB+hAQUlnE+v oOUjtyPMR5GDNyBajk8znKvrwSgSXyVk1VpY9FCj4kzzOvV+D4ql6Hm6i5e7A/lDVZr/ WCaNEjsjCtfwAxwDGPjPfpA4xCR3XjD8+HQh/ivV6ld52425xP+o+lRcLSDmWevYbrcl Rl72h9Sh1nZMaGk8FRlx0NFP2j6UpVgmlEdfKBeqvMSsc6rClYl9JZ84HKwvXPSxsxKU nr1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=09dL5Lpy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c5si17381353edq.283.2020.06.26.05.25.18; Fri, 26 Jun 2020 05:25:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=09dL5Lpy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728665AbgFZLbp (ORCPT + 99 others); Fri, 26 Jun 2020 07:31:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725945AbgFZLbo (ORCPT ); Fri, 26 Jun 2020 07:31:44 -0400 Received: from merlin.infradead.org (unknown [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A3A2C08C5C1 for ; Fri, 26 Jun 2020 04:31:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XqpPxaLgj+8G3qgnOsLPntGf7hGD9ApNPwp5v2TWMCw=; b=09dL5Lpym7OYljru2ezzOlhRNJ Xir+2tMqnbUO7AwRhu3Jf0rheheOCJ7WklQ3JfCBQt2j5kBBlagCPVvQ1+yG5BNKcIIswc6StQW+x Y3G5z/0Tp8gA9FmdYglEkeK+p3qZOLLWcPYW+caJ3WVSb0OhDKTOk7LWdwysS00La156k6O2MJP+O BvsaIBsEe4GaNFkR5vXcPdp0WD1A2NQXptgHk8B06JTiwXsaZAGZKDiySjZJy5HLOtlzXLGpT1pno 2Ay7JJs51WHiAYqLNNLeqNaikjkTbPGCkLQV9+C0CIE7xRQEKdVLbQVksdY+6n/XEpUVszuo62uir jL/euvFg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jomZX-0004Va-J5; Fri, 26 Jun 2020 11:31:08 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id DC1B530280D; Fri, 26 Jun 2020 13:31:01 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id CDAD729C4228B; Fri, 26 Jun 2020 13:31:01 +0200 (CEST) Date: Fri, 26 Jun 2020 13:31:01 +0200 From: Peter Zijlstra To: Joerg Roedel Cc: Joerg Roedel , x86@kernel.org, hpa@zytor.com, Dave Hansen , Andy Lutomirski , Andrew Morton , Steven Rostedt , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] x86/mm: Pre-allocate p4d/pud pages for vmalloc area Message-ID: <20200626113101.GG4817@hirez.programming.kicks-ass.net> References: <20200626093450.27741-1-joro@8bytes.org> <20200626110731.GC4817@hirez.programming.kicks-ass.net> <20200626111711.GO14101@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200626111711.GO14101@suse.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 26, 2020 at 01:17:11PM +0200, Joerg Roedel wrote: > On Fri, Jun 26, 2020 at 01:07:31PM +0200, Peter Zijlstra wrote: > > Can't we now remove arch_sync_kernel_mappings() from this same file? > > Only if we panic on allocation failure. I think we do that in plenty places already, so sure ;-)