Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 26 Jun 2020 13:32:15 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Joerg Roedel <jroedel@suse.de>
Cc:     Joerg Roedel <joro@8bytes.org>, x86@kernel.org, hpa@zytor.com,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] x86/mm: Pre-allocate p4d/pud pages for vmalloc area
Message-ID: <20200626113215.GG117543@hirez.programming.kicks-ass.net>
References: <20200626093450.27741-1-joro@8bytes.org>
 <20200626110731.GC4817@hirez.programming.kicks-ass.net>
 <20200626111711.GO14101@suse.de>
 <20200626113101.GG4817@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200626113101.GG4817@hirez.programming.kicks-ass.net>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jun 26, 2020 at 01:31:01PM +0200, Peter Zijlstra wrote:
> On Fri, Jun 26, 2020 at 01:17:11PM +0200, Joerg Roedel wrote:
> > On Fri, Jun 26, 2020 at 01:07:31PM +0200, Peter Zijlstra wrote:
> > > Can't we now remove arch_sync_kernel_mappings() from this same file?
> > 
> > Only if we panic on allocation failure.
> 
> I think we do that in plenty places already, so sure ;-)

That is, this is boot time only, right? clone() would return -ENOMEM, as
it's part of the normal page-table copy.