Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp554209ybt; Fri, 26 Jun 2020 06:08:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwheiFZmpSTRgB//b75hipB5IO27e7QWY+tTAxgNdYvAMieFXhHqZRs2042zmmv7WJqBS9 X-Received: by 2002:aa7:ccd5:: with SMTP id y21mr3157215edt.91.1593176901408; Fri, 26 Jun 2020 06:08:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593176901; cv=none; d=google.com; s=arc-20160816; b=dlkrxUUjkggWh3abtTRXGpWkPzBVJ+qm7+UqM96NrgT+Oez3PTbrdosS74rcBUXGou +usdLhJdS66ryKD6n2QXoC86wPi65IktTAHrfCPiIV6OGltI9HtzdVStclpDXXnwsor4 G9SHdq9YWIvbaR0r7VD1ridJ5zgTswQnUSlsy4w5SfehcUCYls4BWr1q4jwtpWvo/JbQ 3ljGH5HFj62ITpGXdP1kU+KlIDMviZVOwiH3ydVXMi5BWrS/OyEj+Erifn3TaSutJdw/ zcrSoUfdpvflSu1NKxA4LKj1h0yGuIeULjxxkdqu0kQwEmPrp9IASpKeu4XZX/G9L+Eu V25g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=YTKb0UeG+qPRJPpdcm4YXWRuqmqvPg+QAyQ4w0Tgt64=; b=BDI/KSM1dT8d6Zi9XgSmnGlQ17Lz26srdZ/1g6HHYdQ6GN879oBofH3Tvd4+xPCnBC 4DmigldDQWjyka61/8uIwpxSNEJZ5P+6ek6stIANW2RaDjELCWDFimGuSk06usvMgpzO cK98eX/8yLTNmASkJHa9i1WEJZXXdtCNV8O1k4dx+pRY+ip6dFkUEVIrxBk4QaNBfHOI oCLUAwurtb3dl5tEAe1Xv4kJmJvMo0SzW85RhI2t9OUuYpcDYiZ+ZExHczxynCErskiv filGBNuIjBtAW6gZ89DTGUh/bb43o77bDPYxTn1+zvP9xLU+UE3xgjyiJuntL+N9ujfk fokw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@es-iitr-ac-in.20150623.gappssmtp.com header.s=20150623 header.b=F4KzxXab; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=iitr.ac.in Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lc19si5156277ejb.584.2020.06.26.06.07.58; Fri, 26 Jun 2020 06:08:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@es-iitr-ac-in.20150623.gappssmtp.com header.s=20150623 header.b=F4KzxXab; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=iitr.ac.in Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728427AbgFZNHM (ORCPT + 99 others); Fri, 26 Jun 2020 09:07:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726678AbgFZNHL (ORCPT ); Fri, 26 Jun 2020 09:07:11 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25C6CC08C5DB for ; Fri, 26 Jun 2020 06:07:10 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id 35so4277597ple.0 for ; Fri, 26 Jun 2020 06:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=es-iitr-ac-in.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=YTKb0UeG+qPRJPpdcm4YXWRuqmqvPg+QAyQ4w0Tgt64=; b=F4KzxXabIaQ/V+cRgDzKaNDAHMGi0nD4P6kwkSSe/9BfI9D3an7T61LJCpDDCJ6KH9 U3JxENO3EP4tm1LbD1KMX2Oq9vmu0HHu3blm9GE0m4UWlcM/sYA2JTWoD9s7VXVKM39o 9l6R2SP2pDdy37jRUmnkcy/7/xzfOpPbA8TrAvI1x7+AeJUhpwGtElhYXJO4V4pAmxf2 aeCxhWL0w0W6+ezj7EZ5BVuFYw5Xx2fYUP+wsXzhYj0CmnhEVmchyC7/l2ZVUqYDaODM CJTEytHQk6bqY1nFYjqRJTh18mN8QoOvgwO2ijKjCKy32cRhaLk5/5bTxoLn8o8BdGGW wxOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=YTKb0UeG+qPRJPpdcm4YXWRuqmqvPg+QAyQ4w0Tgt64=; b=LLCZxZZXGtCf8QKBuBipg5CIncqnHFk1m/6IyMa6bq6jKh6vTbalrF2dKI6e7yvMbc jyxha2C4QaefMYWNVF1h7Ekii82XODbQLzqNPX/t6XjhASbjC4/7fo6plvsLel7BUeiS GGVjDSLbjCNeUWM0FQU58bcV7qwFTTRCSsRdVbNuIMWGw1qfBNNoqYoW5E0YjDup0de2 PLdS2a2jhTJwnmQS37EFRHnkrWFrBACUwehE7gomKwxMuBO/vdvDLXmNkmxFp5kEBWdb PFM5ZiVKUu2lVNxGvEwi6N/nA0ssnNhQQHH74VEoWr+J89gp64MU9K3jxYVCkDq6m5Zk NvEQ== X-Gm-Message-State: AOAM531Hhs9Iz3lwk5Psfq+an2l1S84nqeHkNMBw0Z+p/t6cX0Z0FkIC Heyp3VZUJhrf8D51dDlodqh1sw== X-Received: by 2002:a17:90a:191b:: with SMTP id 27mr3541616pjg.158.1593176829537; Fri, 26 Jun 2020 06:07:09 -0700 (PDT) Received: from kaaira-HP-Pavilion-Notebook ([103.113.213.178]) by smtp.gmail.com with ESMTPSA id x77sm26840289pfc.4.2020.06.26.06.07.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 06:07:09 -0700 (PDT) From: Kaaira Gupta To: Helen Koike , Shuah Khan , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Kieran Bingham , hverkuil@xs4all.nl Cc: Kaaira Gupta Subject: [PATCH v7 0/3] media: Add colors' order and other info over test image Date: Fri, 26 Jun 2020 18:36:57 +0530 Message-Id: <20200626130700.2453-1-kgupta@es.iitr.ac.in> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patchset aims to add a method to display the correct order of colors for a test image generated. It does so by adding a function which returns a string of correct order of the colors for a test pattern. It then adds a control in vimc which displays the string over test image. It also displays some other information like saturation, hue, contrast brightness and time since the stream started over test image generated by vimc. Changes since v6: In patch 3: - Use switch case instead of if() - reorder declarartions. Changes since v5: In patch 2: - Add missing EXPORT_SYMBOL_GPL() In patch 3: - Renamed varaibles. - use u64 instead of int for getting current time in nanoseconds. - Use enum instead of numbers to describe the state of osd_mode control in code. Changes since v4: - Add another patch which changes char argument to const char in function tpg_gen_text() - Return const char * from function tpg_g_color_order() in patch 2 In 3rd patch: - Check font in probe() instead of s_stream() - Use dev_err instead of pr_err - Fix errors in commit message. - Base VIMC_CID_SHOW_INFO on VIVID_CID_OSD_TEXT_MODE Changes since v3: In 1st patch: -Improved formatting of returned string. In 2nd patch: - Add CID prefix in control name and change it to a more generic name. - Rename bool variable to a generic name. - Disable text rendering instead of stopping stream if no font found. - Display more info like VIVID in VIMC. Changes since v2: In 1st patch: - Create a 'define' to prevent repetition of the common color sequence string. - Use 'fallthrough' on case statement to prevent repetition of code. Changes since v1: - Divided the patch into two patches. - Returned NULL for patterns whose color order cannot be defined. (Reported-by: kernel test robot ) - Made separate switch cases for separate test patterns (Reported-by: kernel test robot ) - Renamed variables from camelcase to use '_' - prefixed 'media' to the patches. Kaaira Gupta (3): media: tpg: change char argument to const char media: tpg: Add function to return colors' order of test image media: vimc: Add a control to display info on test image drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 40 +++++++++-- drivers/media/test-drivers/vimc/Kconfig | 2 + drivers/media/test-drivers/vimc/vimc-common.h | 1 + drivers/media/test-drivers/vimc/vimc-core.c | 10 +++ drivers/media/test-drivers/vimc/vimc-sensor.c | 70 +++++++++++++++++++ include/media/tpg/v4l2-tpg.h | 3 +- 6 files changed, 118 insertions(+), 8 deletions(-) -- 2.17.1