Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp698114ybt; Fri, 26 Jun 2020 09:22:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxGvv9z1xdjMSnfAUOvgefvUufW3wnMnFEZcvavgC0xs+Rqw5g+d/GHNilxrQG4kpVW73D6 X-Received: by 2002:a05:6402:202a:: with SMTP id ay10mr4357484edb.0.1593188558382; Fri, 26 Jun 2020 09:22:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593188558; cv=none; d=google.com; s=arc-20160816; b=SYURlnF38ffKyiMl17FXohETCuxbtDr7ZTcri7MLBNzmnuObsR46PRy+tjNrsIESHV ZB56mQi0X52IeBHXxV2gNf1GduWGCAKfBSA3tvVONdnVL2QUtMkM8lHUpcAVhtSD6Imz If8lAUUzt2wOk399PMbePqftzgP9TIDuw6XmDucgAVnUXaDQRfzpEW3hGt/owA89zuvS rCzUE/Xdg0ZY7P8T8OQqYCFCqVPHtSNpIA8lA4kKlPXEw0eWRri3gbd1xy/CyAzmKzvO FgBxmUm9athBDFuSzux6JiaW023zGOsrV8dH5oqC/MaPFDaAJZWI6ApMqjyB+fRT3bHH H6LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version; bh=MNm+H1+3sM7GJldTJWjv6LjcZS6SRDYkMSwCAQwPsus=; b=eGUgczWUuGay19YTkqrYfDmIwYFItUFGnqGU0PWxrtCOJxmiyaCqRCHBEw8/wJCwZo oOX0ggfgWLLKlMOVR73UiG8lkcP7Kvw9CMnP7PDtaNvdFcYgy2RjPiyURi9i/F/qxNOD nwbY2qWaKexlCUdn9XYapzYAFSAconqrULVhCHkqNyohJqliTLGNecPNRW8hEUu6Mxx7 ZCu1ReqTW7ToauSVhE/iu/3HK/YEokGOF0Y3ZCcbgq2+GKSvNVZLPeQxlvVU6gFuSJjA JAw45Xp4yvRXg5ZHXG2P4DEMBC+gvF03W3PIRK3oXN1u76NlsNqFp50Vhw6RRGM1bIG7 2MaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d1si4801766edo.202.2020.06.26.09.22.15; Fri, 26 Jun 2020 09:22:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729291AbgFZOh6 convert rfc822-to-8bit (ORCPT + 99 others); Fri, 26 Jun 2020 10:37:58 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:37499 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725970AbgFZOh5 (ORCPT ); Fri, 26 Jun 2020 10:37:57 -0400 Received: from mail-qv1-f42.google.com ([209.85.219.42]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MzTCy-1itrBk1WDo-00vL9G for ; Fri, 26 Jun 2020 16:37:56 +0200 Received: by mail-qv1-f42.google.com with SMTP id g11so4585886qvs.2 for ; Fri, 26 Jun 2020 07:37:56 -0700 (PDT) X-Gm-Message-State: AOAM531EVzHfX5WdPmL4qSLTyKtNAqGEgYv5bQjAx/D9gLdCkpIVCXZE RlgBnCf34o8d1/CJLFk45QqHE2ZrnXGjj2cR1Ok= X-Received: by 2002:a0c:f385:: with SMTP id i5mr3580097qvk.4.1593182275276; Fri, 26 Jun 2020 07:37:55 -0700 (PDT) MIME-Version: 1.0 References: <20200626130525.389469-1-lee.jones@linaro.org> <20200626130525.389469-6-lee.jones@linaro.org> In-Reply-To: <20200626130525.389469-6-lee.jones@linaro.org> From: Arnd Bergmann Date: Fri, 26 Jun 2020 16:37:39 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 05/10] misc: lkdtm: Always provide prototype for lkdtm_DOUBLE_FAULT() To: Lee Jones Cc: gregkh , Linux ARM , "linux-kernel@vger.kernel.org" , Kees Cook Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Provags-ID: V03:K1:Wohm3fhlLguIrcTt0zsqN5SZMg7n/fBN7rHkHv2J09vid5ngTJM ebubAYVS2+8i6Qa4owdKoiS49QRI3JxPyXRcZqmdS3Rv0ZfHVbon3G8XjRA1etJ3uzCsxPs Hkh9rxapRRunXmeeSmeZgD9iai2Z7tcBgKzHnjS7w1akoZwzPJp+nCnmSjmd9825hOPEIsK qK5BiQzxKFeBfNmqb7CHg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:I6PBN6WgPis=:pXet1GDyFEoFIKskEWLZQv cwfd3iZxRiGt4xDoF351ie+7fX/gApz3VGTKh8+ZDAeW0ahgeGEWf7NicRSsb38feLmzYHKES 8Kx3MJ/c8UrBUiQkYxiOm1Br2IAu3z20Cw0SGs/+etorQMch6vNc/yVxGIkBQ6bNE6eeZddzj dP7OHERVK21C7NMpMbwYcxX931tF0eZzCABaI8BTB4SXd2SKaobIQpr1u9TNy2mRhndHrfEOs Yi/86erWFbO0KlZYGV5a/KLIbDuZf4+NtUmUh8gYh3OD+zNY7DSM/ywTcNYTbjNWNlWn5uzz4 gUrWODyjOE9VaiE74rUn6gOsJrIWCrskKUrDqOE2+krmLdPJ8iaO/4Ahjq/jmJJJahL/pi4jB 61WR6xyzW5E5R9EV/ZFmD77nyP7uTcbutbhavU8SqXxJq5MHMSNyzkNat4vdyEsVntYadnjDb rBMOWiRdstPFY0ibwUl32jY9o04sW74sq/YkXt3JmI9MAyvSyGfSjyaE8GfLA8kV52vjDcK4u 57eou5dpQ4qFZTKA+fdtVX9pVcQXqVWrSvRI54l+GIPvhDCOHlUAqlKBB5sjRRLgwQ6Cm/K9q lSe6kgu+twL3m4lqqtgolRmnif3I/Vk93C3D2Zz9VrRuJ3UXbeqWzo2os7AgMT/lcBhMbb550 ujLvChPDI8Gy7pVGUMb5Y76WrVgPDUPW1twlyBDUlJhvWdmMyzpbG/63GOfD/yoNb2Isi3KiF gpAV4BcMCHiuC14UPfQeyLVd1nIDeH3SlV72aMdqLMKh1K7Vpm9U0a6l4Os4ZbP2Kg7+UJ2EP HLp9xH0u86sNSiP2F1erriJH/gMsMJL0cJ6DRfDb6LT7MQCpSk= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 26, 2020 at 3:05 PM Lee Jones wrote: > > lkdtm_DOUBLE_FAULT() already has internal logic to handle > !CONFIG_X86_32. Compiling out the prototype actually prevents > that logic from being useful. > > Fixes the following W=1 warning: > > drivers/misc/lkdtm/bugs.c: At top level: > drivers/misc/lkdtm/bugs.c:420:6: warning: no previous prototype for ‘lkdtm_DOUBLE_FAULT’ [-Wmissing-prototypes] > 420 | void lkdtm_DOUBLE_FAULT(void) > | ^~~~~~~~~~~~~~~~~~ > > Cc: Kees Cook > Signed-off-by: Lee Jones Acked-by: Arnd Bergmann