Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964845AbWC1XtH (ORCPT ); Tue, 28 Mar 2006 18:49:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964848AbWC1XtH (ORCPT ); Tue, 28 Mar 2006 18:49:07 -0500 Received: from mx0.towertech.it ([213.215.222.73]:5856 "HELO mx0.towertech.it") by vger.kernel.org with SMTP id S964845AbWC1XtF (ORCPT ); Tue, 28 Mar 2006 18:49:05 -0500 Date: Wed, 29 Mar 2006 01:48:51 +0200 From: Alessandro Zummo To: Kumar Gala Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH][UPDATE] rtc: Added support for ds1672 control Message-ID: <20060329014851.0f54da89@inspiron> In-Reply-To: References: <20060329004122.64e91176@inspiron> Organization: Tower Technologies X-Mailer: Sylpheed Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1026 Lines: 44 On Tue, 28 Mar 2006 16:55:01 -0600 (CST) Kumar Gala wrote: > +/* following are the sysfs callback functions */ > +static ssize_t show_control(struct device *dev, struct device_attribute *attr, char *buf) > +{ > + struct i2c_client *client = to_i2c_client(dev); > + char *state = "enabled"; > + u8 control; > + int err; > + > + err = ds1672_get_control(client, &control); > + if (err) > + return err; shouldn't this be if (err < 0) return err; ? > + /* read control register */ > + err = ds1672_get_control(client, &control); > + if (err) { > + dev_err(&client->dev, "%s: read error\n", __FUNCTION__); > + goto exit_detach; > + } ditto. -- Best regards, Alessandro Zummo, Tower Technologies - Turin, Italy http://www.towertech.it - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/