Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200523031608.17918-1-wu000273@umn.edu> <8d81a91b-4c1d-d0e1-60d0-a68f6ef65bd0@collabora.com>
In-Reply-To: <8d81a91b-4c1d-d0e1-60d0-a68f6ef65bd0@collabora.com>
From:   Mat King <mathewk@google.com>
Date:   Fri, 26 Jun 2020 10:01:43 -0600
Message-ID: <CAL_quvRZ9jiDxsRsVjXnU3VdT7C3MUsnm+=M+j6JhoV9d_ntCQ@mail.gmail.com>
Subject: Re: [PATCH] platform/chrome: fix a double-unlock issue
To:     Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc:     wu000273@umn.edu, Benson Leung <bleung@chromium.org>,
        Guenter Roeck <groeck@chromium.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        kjlu@umn.edu, Jett Rink <jettrink@chromium.org>,
        Mathew King <mathewk@chromium.org>,
        Enrico Granata <egranata@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jun 25, 2020 at 2:26 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Hi Qiushi,
>
> Thank you for your patch.
>
> On 23/5/20 5:16, wu000273@umn.edu wrote:
> > From: Qiushi Wu <wu000273@umn.edu>
> >
> > In function cros_ec_ishtp_probe(), "up_write" is already called
> > before function "cros_ec_dev_init". But "up_write" will be called
> > again after the calling of the function "cros_ec_dev_init" failed.
> > Thus add a call of the function =E2=80=9Cdown_write=E2=80=9D in this if=
 branch
> > for the completion of the exception handling.
> >
> > Fixes: 26a14267aff2 ("platform/chrome: Add ChromeOS EC ISHTP driver")
> > Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Tested-by: Mathew King <mathewk@chromium.org>
Signed-off-by: Mathew King <mathewk@chromium.org>

>
> The change looks good to me, but I'd like someone having the hardware giv=
ing a
> Tested-by tag, so cc'ing some chromeos people. They must be also interest=
ed on
> backport this patch.

Tested on a device with ish based cros EC. Looks good to me.
>
> > ---
> >  drivers/platform/chrome/cros_ec_ishtp.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/chrome/cros_ec_ishtp.c b/drivers/platform=
/chrome/cros_ec_ishtp.c
> > index 93a71e93a2f1..41d60af618c9 100644
> > --- a/drivers/platform/chrome/cros_ec_ishtp.c
> > +++ b/drivers/platform/chrome/cros_ec_ishtp.c
> > @@ -660,8 +660,10 @@ static int cros_ec_ishtp_probe(struct ishtp_cl_dev=
ice *cl_device)
> >
> >       /* Register croc_ec_dev mfd */
> >       rv =3D cros_ec_dev_init(client_data);
> > -     if (rv)
> > +     if (rv) {
> > +             down_write(&init_lock);
> >               goto end_cros_ec_dev_init_error;
> > +     }
> >
> >       return 0;
> >
> >