Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964849AbWC1X5y (ORCPT ); Tue, 28 Mar 2006 18:57:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964850AbWC1X5x (ORCPT ); Tue, 28 Mar 2006 18:57:53 -0500 Received: from mx0.towertech.it ([213.215.222.73]:38283 "HELO mx0.towertech.it") by vger.kernel.org with SMTP id S964849AbWC1X5x (ORCPT ); Tue, 28 Mar 2006 18:57:53 -0500 Date: Wed, 29 Mar 2006 01:57:38 +0200 From: Alessandro Zummo To: Kumar Gala Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH][UPDATE] rtc: Added support for ds1672 control Message-ID: <20060329015738.5dbbb22d@inspiron> In-Reply-To: References: <20060329004122.64e91176@inspiron> <20060329014851.0f54da89@inspiron> Organization: Tower Technologies X-Mailer: Sylpheed Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 877 Lines: 39 On Tue, 28 Mar 2006 17:52:00 -0600 Kumar Gala wrote: > > > > shouldn't this be > > if (err < 0) > > return err; > > It could be, but doesn't need to. ds1672_get_control either returns > 0 (success) or non-zero (-EIO) for failure. > > >> + /* read control register */ > >> + err = ds1672_get_control(client, &control); > >> + if (err) { > >> + dev_err(&client->dev, "%s: read error\n", __FUNCTION__); > >> + goto exit_detach; > >> + } > > > > ditto. > > ditto. ok. will apply, thanks. -- Best regards, Alessandro Zummo, Tower Technologies - Turin, Italy http://www.towertech.it - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/