Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 26 Jun 2020 14:44:37 -0300
From:   Jason Gunthorpe <jgg@mellanox.com>
To:     Ralph Campbell <rcampbell@nvidia.com>
Cc:     nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Jerome Glisse <jglisse@redhat.com>,
        John Hubbard <jhubbard@nvidia.com>,
        Christoph Hellwig <hch@lst.de>, Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH] nouveau: fix page fault on device private memory
Message-ID: <20200626174437.GD23821@mellanox.com>
References: <20200626172626.19207-1-rcampbell@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200626172626.19207-1-rcampbell@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from mlx.ziepe.ca (206.223.160.26) by YT1PR01CA0130.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Fri, 26 Jun 2020 17:44:46 +0000
Received: from jgg by mlx with local (Exim 4.93)        (envelope-from <jgg@mellanox.com>)      id 1josOz-000CDi-47; Fri, 26 Jun 2020 14:44:37 -0300
X-Originating-IP: [206.223.160.26]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: cc045b89-bd08-49fc-2aca-08d819f89da6
X-MS-TrafficTypeDiagnostic: VI1PR0502MB3952:
X-Microsoft-Antispam-PRVS: <VI1PR0502MB3952F617D08583C8F582CE1ACF930@VI1PR0502MB3952.eurprd05.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-Forefront-PRVS: 0446F0FCE1
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: wbTkcA26ThGsRJQ9327uechon7CeRXEwoB3Hc1QRa36Xu9pHzIEA6tLN6FdD9TvM4QPIh0yfSmVlxUFrV7t+I7Ijdng5MyaMFnJxubKFU5faE0+Aa8/cIl32toGrqWWqLZuPPYeUf5O+Er2/3XVQRcyAcKtlAOzBQ+IIQ2JqW8DVqAP3VRBsDEyqu00YlcwaWaB3iaSyYBBr+/4MjS45OzYyfoGcLVCgvVEWePMq0pt3DVZMWwDf1JgqLDOrK7d06HYnm6TPeUzXnRGitX9u9zjKUvnBCCeTTHlwewdEPBaLD3EugYDMhOoAO1FpMPBnd/bBA2qxtWSP0Fa293z2sQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR05MB4141.eurprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(136003)(39860400002)(376002)(366004)(346002)(1076003)(33656002)(5660300002)(186003)(8936002)(316002)(54906003)(426003)(9746002)(9786002)(8676002)(83380400001)(36756003)(2616005)(4326008)(478600001)(2906002)(6916009)(26005)(86362001)(66556008)(66476007)(66946007)(4744005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: 1IRK14b/81P07ItXzkHWDjvy0M4n9WE2rA0W3BzR9P4dvUJnV6vDdaYNLp/OXtkBaXUmWJr+Ko4w+AFIMjd2TNJc5BCChttBN1oqSLi5dJfE3sSKrYhKnjcR1W5daqvPdiuo32mrv+gREEcX9/xRzxnoyXCkAtSAr2ZzsEtkzMltvqbXCXZ5N4bsLSW+xruP/cAvsFMkedteJLoERhAgQf7hXXIJSojsGhqR1kN4IjXS4UwLuzBRJTfIZYXizRm8DinI9OFltmeNPO9YDlk7oD3jvPoxsxw/gz/3dhBNKzkZRvsYI+sHGm7SfCJAlj7u/u9tsXMNrljo3iYrIDVyv2TdyPTTx/nQOpi7mx0sil/i30DtxpWDBegYE0a/YxLIptNT3Z9satL9BRnez3QuJsQ0duItsD8LEfN/PlEgMh5h2Aq9TJQPl5rUskPyEDeslcolSTPeCozKVvEx8DuWJRrney2/sB0NRk9STPdBBKxGeDC0ePQIU5hKGNs40u0B
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc045b89-bd08-49fc-2aca-08d819f89da6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR05MB4141.eurprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2020 17:44:46.1721
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K8SSWib8rQjBSX8t3SD2c7YaAgPxLpiVxDrYR2p3EnT37TMMJltiJkomkryi1hDaqQjCFfiJfw5tArQm23igew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0502MB3952
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 26, 2020 at 10:26:26AM -0700, Ralph Campbell wrote:
> If system memory is migrated to device private memory and no GPU MMU
> page table entry exists, the GPU will fault and call hmm_range_fault()
> to get the PFN for the page. Since the .dev_private_owner pointer in
> struct hmm_range is not set, hmm_range_fault returns an error which
> results in the GPU program stopping with a fatal fault.
> Fix this by setting .dev_private_owner appropriately.
> 
> Fixes: 08ddddda667b ("mm/hmm: check the device private page owner in hmm_range_fault()")
> Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>
> ---
> 
> This is based on Linux-5.8.0-rc2 and is for Ben Skeggs nouveau tree.
> It doesn't depend on any of the other nouveau/HMM changes I have
> recently posted.

Makes sense to me

Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>

Jason