Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp845940ybt; Fri, 26 Jun 2020 13:01:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJysLUjxBBHbT6hRnTmcpYTIdnLaMX6zSVSCCea3KdvWU+OFqEVJ0VHg0dvRL3l8jUXuMRb4 X-Received: by 2002:a17:906:a892:: with SMTP id ha18mr4174630ejb.462.1593201673713; Fri, 26 Jun 2020 13:01:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593201673; cv=none; d=google.com; s=arc-20160816; b=HzvAzJrVh2/lWJMCDIHqfGpVJj4vTeAVYurPPn0uJeGVGr0I90NsJtNlaeTMaWBBX4 gwrUhKyE+rpTTSarfCZK3imjfjNQC7J8ekLz5pD7vAWZiIrpLaJnrio2dqVFKJ7ZWHIO 4PBvt5jTwVNykDh6e1zpwwWtxXWkECJQB+mjFV9ps1pTK+3PKK79aKiWCEY4vjSFRXUU FynhKZlyru0nNlY521cFFsTblR5oXclU63ncNh/MPyW8111l0Tq5/2mNZtIkgh+4umO+ E5F4IKQaojGWCUdpX4E23mq75Sy+bfu0rlJrtMSmzE2HTg/o3sWmcx6Zg1yhbZ84BIPL wNsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=Vdg+PWepOgaEOUVq6sAyT965NlAiaEQC1jJkZ1a4wdc=; b=dM0KOqt8B285sdGV6ZSvv9yRjamJR+72InInisOiqwT83oakEJJ2Jv8tylPfBzaDaO 0kWHGftK0PUAWwxDXoQWaSATGUPGFqacZ5YZexo9U1a3MYjgrP2b2rlR89zRZIlhJOQT D2w1ClTf48+YDabIQVCVA8KDqshpElsPVDgQmxowTpkmRoS7+hQyQxF9DoaagV4bVGG+ D8lsLk7/85Y8XqBMb4whF8MUBEKV+ZoopAzRXQrsJJSfLVTBb8Up+ooTQWSex+Dkn4qx LhQQhoKCyV/arq/fAKBM5Ava1Pm+oOeVt/z0rJRjA93LbSmedZcw8urW5uLoa6jxsTtD Y0Sg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 8si7956254ejx.659.2020.06.26.13.00.49; Fri, 26 Jun 2020 13:01:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725864AbgFZUAd (ORCPT + 99 others); Fri, 26 Jun 2020 16:00:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725803AbgFZUAd (ORCPT ); Fri, 26 Jun 2020 16:00:33 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EFBFC03E979; Fri, 26 Jun 2020 13:00:33 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D72CF118EE359; Fri, 26 Jun 2020 13:00:32 -0700 (PDT) Date: Fri, 26 Jun 2020 13:00:29 -0700 (PDT) Message-Id: <20200626.130029.89317239393030387.davem@davemloft.net> To: horatiu.vultur@microchip.com Cc: nikolay@cumulusnetworks.com, roopa@cumulusnetworks.com, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org Subject: Re: [PATCH net-next v3 0/2] bridge: mrp: Extend MRP netlink interface with IFLA_BRIDGE_MRP_CLEAR From: David Miller In-Reply-To: <20200626073349.3495526-1-horatiu.vultur@microchip.com> References: <20200626073349.3495526-1-horatiu.vultur@microchip.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 26 Jun 2020 13:00:33 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Horatiu Vultur Date: Fri, 26 Jun 2020 09:33:47 +0200 > This patch series extends MRP netlink interface with IFLA_BRIDGE_MRP_CLEAR. > To allow the userspace to clear all MRP instances when is started. The > second patch in the series fix different sparse warnings. > > v3: > - add the second patch to fix sparse warnings These changes are completely unrelated. The sparse stuff should probably be submitted to 'net'. And I have to ask why you really need a clear operation. Routing daemons come up and see what routes are installed, and update their internal SW tables to match. This not only allows efficient restart after a crash, but it also allows multiple daemons to work cooperatively as an agent for the same forwarding/routing table. Your usage model limits one daemon to manage the table and that limitation is completely unnecessary. Furthermore, even in a one-daemon scenerio, it's wasteful to throw away all the work the previous daemon did to load the MRP entries into the bridge. Thanks.