Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp902043ybt; Fri, 26 Jun 2020 14:33:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyO1M7PD6bI37CYBP/kqQQVeQhqfUyoKRAkSec0E6xeAvT6YCQqzTxEWsPYIDzFXImTzJO8 X-Received: by 2002:a17:906:88d:: with SMTP id n13mr4481042eje.349.1593207226648; Fri, 26 Jun 2020 14:33:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593207226; cv=none; d=google.com; s=arc-20160816; b=db/ckHTUJxDRk+/Fv9rfLSBk/8PWzU7zaftB2zecJ2mk1ROZUqv7lwbuL/sXdX/n77 TaU3ph2Ly7eZtsVlVaF1vzZYwyaGFHI0q4eDOr/WGY0eogjS3+d30kqqE+A6DdN9nxFZ Ga6JGiFZujvp4HfnD7NN0T3s6xXAEMmhWcopL+urPR7ehJiznp5SEjILtbOxd7qSyEUd Qirvf1G7fzstqhNqDHSjdrmKXiIkEaRZVJffVY023T/QtpEuBQkPbgigBgNqC0rPelME 8IGhbboVyEp4e3U/ApCZjMOXnoSTs5GFBCQQCI0xP6LETT7Mz3PQzXzeSI4ezjBS304T FoMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=isGI70+czOYX8LYvRhZpcPAvKyFNKEPZ2af3yPbAFwI=; b=D59/ZVhJbOJLXly6ch+JWQPqYW3Gblkuiz8+exSNVZrxTn3LOlHQ6HhLFD5vgd32Ec SzxgA9mzGYvS4/Hm242xYWXTrqYcKnw7KQ8a9s+ETUhCqIHTcKwg6xg3yt/wWHfqZqkO Ap4uTOxbbBI3+raX5rP0srqGlmweGmvls7fh28/lpfb/KhglsSiMqxm9DfTyD3UyQaLl em9nix545cPJtkPK19hTaf8CTnk/Idqy4M1nflW3gABKEIXzR72mD6xnCidu8cRjvXI9 OSAC2Po5Vk44cXU1fAsHKQ1QOHjKwEx4BHifPTosey8mPsHRn88LlQC048k/U9f7HzOM mobA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=LiYJGYFo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p3si17128118edr.104.2020.06.26.14.33.23; Fri, 26 Jun 2020 14:33:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=LiYJGYFo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725838AbgFZVdE (ORCPT + 99 others); Fri, 26 Jun 2020 17:33:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725780AbgFZVdC (ORCPT ); Fri, 26 Jun 2020 17:33:02 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EC4FC03E97E for ; Fri, 26 Jun 2020 14:33:02 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id f3so5503641pgr.2 for ; Fri, 26 Jun 2020 14:33:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=isGI70+czOYX8LYvRhZpcPAvKyFNKEPZ2af3yPbAFwI=; b=LiYJGYFoXJP9NdTWRWQnsw8sojKk2XNyauPgbVrUQ4KV6YX9RKsid/d8JtVlvnpxBa kZjOaTyiQ7C5PlTOVs3B8l8qGn6OcJon3YnViItkxbqWEA1SEy38nFZN308uIc2d/U0P UcJCd+T2lawIni5nxisTS95QZKtBi43/FYsys= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=isGI70+czOYX8LYvRhZpcPAvKyFNKEPZ2af3yPbAFwI=; b=LV/yrRPG2J3IlgrnqNS1qHWU/CK3R04ZEaSZGp9VlctvMCMJ9MnjT2Nrdy+y0Uy+4l X+OJfFm/0LTT52Ati+60hD0NFrf5Wu+CwGJVJOyqLRamPtygCjNnuYPjHreJ0/W8lQ9y LFrICCbNM7zJTmxjYQKgAKs09QfiWmTzAMxA1ENweRCSiwb1cl1JlTobtWOoXPECVbXn S+XSWI5iCU/mIWH2NsZSHERc1qlOQ4R9KzjrFEQJvJme6PrM5TpynEOCzaU2aK0fbiHD uH0bgbCMjx0IGu2BXu/M0xQLtF66m6zc+7QXY6WXaqyHmEKIWQkoci/4DcKqQbzctjxn FPVA== X-Gm-Message-State: AOAM53273RpQ/YJUM34AcezRdnGSnHIEFkZqivk/y5Ap8dQWqvdrAisR VG4G4Urb80qC5qs01TJvRj9EHg== X-Received: by 2002:a63:417:: with SMTP id 23mr663893pge.44.1593207181950; Fri, 26 Jun 2020 14:33:01 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id p19sm26713683pff.116.2020.06.26.14.33.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 14:33:01 -0700 (PDT) Date: Fri, 26 Jun 2020 14:33:00 -0700 From: Kees Cook To: Brendan Higgins Cc: jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, arnd@arndb.de, skhan@linuxfoundation.org, alan.maguire@oracle.com, yzaikin@google.com, davidgow@google.com, akpm@linux-foundation.org, rppt@linux.ibm.com, frowand.list@gmail.com, catalin.marinas@arm.com, will@kernel.org, monstr@monstr.eu, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, chris@zankel.net, jcmvbkbc@gmail.com, gregkh@linuxfoundation.org, sboyd@kernel.org, logang@deltatee.com, mcgrof@kernel.org, linux-um@lists.infradead.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-xtensa@linux-xtensa.org Subject: Re: [PATCH v5 08/12] init: main: add KUnit to kernel init Message-ID: <202006261431.BB35444FB6@keescook> References: <20200626210917.358969-1-brendanhiggins@google.com> <20200626210917.358969-9-brendanhiggins@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200626210917.358969-9-brendanhiggins@google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 26, 2020 at 02:09:13PM -0700, Brendan Higgins wrote: > Remove KUnit from init calls entirely, instead call directly from > kernel_init(). > > Co-developed-by: Alan Maguire > Signed-off-by: Alan Maguire > Signed-off-by: Brendan Higgins > Reviewed-by: Stephen Boyd Reviewed-by: Kees Cook -- Kees Cook