Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Song Liu <songliubraving@fb.com>
To:     Andrii Nakryiko <andrii.nakryiko@gmail.com>
CC:     Peter Zijlstra <peterz@infradead.org>, bpf <bpf@vger.kernel.org>,
        Networking <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        "Daniel Borkmann" <daniel@iogearbox.net>,
        Kernel Team <Kernel-team@fb.com>,
        "john fastabend" <john.fastabend@gmail.com>,
        KP Singh <kpsingh@chromium.org>
Subject: Re: [PATCH v2 bpf-next 1/4] perf: export get/put_chain_entry()
Thread-Topic: [PATCH v2 bpf-next 1/4] perf: export get/put_chain_entry()
Thread-Index: AQHWS06t5H2BZnsAuEuKRuZX7jQ17qjqu3gAgACYV4CAABnmAA==
Date:   Fri, 26 Jun 2020 21:38:42 +0000
Message-ID: <ED1F39FC-AE00-4243-8903-9B353DA42C8F@fb.com>
References: <20200626001332.1554603-1-songliubraving@fb.com>
 <20200626001332.1554603-2-songliubraving@fb.com>
 <20200626110046.GB4817@hirez.programming.kicks-ass.net>
 <CAEf4BzbgyBWpHdxe8LdHp+48fazS6JLEdaEd09p40s=+cy4Phw@mail.gmail.com>
In-Reply-To: <CAEf4BzbgyBWpHdxe8LdHp+48fazS6JLEdaEd09p40s=+cy4Phw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <61BE7CCF87B2AA47B834F32C6AD6D635@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c47e36f-190f-41a3-b3bf-08d81a194c2b
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jun 2020 21:38:42.6592
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: g7SQ/EyXtf+0o2hgpaYJMQpL5Y0lw/Ukc90Aw3+9Y5o+T6FMQYrHAd2Ae4O5kIvRDZfvrxDDlzg5fQL/UBQ1Rg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2727
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687
 definitions=2020-06-26_12:2020-06-26,2020-06-26 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 malwarescore=0
 bulkscore=0 cotscore=-2147483648 mlxscore=0 suspectscore=0 adultscore=0
 phishscore=0 clxscore=1015 spamscore=0 mlxlogscore=999 lowpriorityscore=0
 impostorscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2004280000 definitions=main-2006260151
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jun 26, 2020, at 1:06 PM, Andrii Nakryiko <andrii.nakryiko@gmail.com> =
wrote:
>=20
> On Fri, Jun 26, 2020 at 5:10 AM Peter Zijlstra <peterz@infradead.org> wro=
te:
>>=20
>> On Thu, Jun 25, 2020 at 05:13:29PM -0700, Song Liu wrote:
>>> This would be used by bpf stack mapo.
>>=20
>> Would it make sense to sanitize the API a little before exposing it?
>>=20
>> diff --git a/kernel/events/callchain.c b/kernel/events/callchain.c
>> index 334d48b16c36..016894b0d2c2 100644
>> --- a/kernel/events/callchain.c
>> +++ b/kernel/events/callchain.c
>> @@ -159,8 +159,10 @@ static struct perf_callchain_entry *get_callchain_e=
ntry(int *rctx)
>>                return NULL;
>>=20
>>        entries =3D rcu_dereference(callchain_cpus_entries);
>> -       if (!entries)
>> +       if (!entries) {
>> +               put_recursion_context(this_cpu_ptr(callchain_recursion),=
 rctx);
>>                return NULL;
>> +       }
>>=20
>>        cpu =3D smp_processor_id();
>>=20
>> @@ -183,12 +185,9 @@ get_perf_callchain(struct pt_regs *regs, u32 init_n=
r, bool kernel, bool user,
>>        int rctx;
>>=20
>>        entry =3D get_callchain_entry(&rctx);
>> -       if (rctx =3D=3D -1)
>> +       if (!entry || rctx =3D=3D -1)
>>                return NULL;
>>=20
>=20
> isn't rctx =3D=3D -1 check here not necessary anymore? Seems like
> get_callchain_entry() will always return NULL if rctx =3D=3D -1?

Yes, looks like we only need to check entry.=20

Thanks,
Song