Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: BJHnpWhAfyXCaKFpKf2GTxUcbuIREp8G1uf+WeuA0eJi0mLM+xqEUvqc4BKR4QcETytIFK8q1V
 tXM4THXS0zkA==
IronPort-SDR: NSAyYbDiA+tJ5jsIFgTWYxItlBUAdbRRKZJmDvJ7X1geYoQb2irFqU0HDwl7NGBzGNlYk+JXp3
 jnPlv40/pwvw==
Date:   Fri, 26 Jun 2020 14:57:59 -0700
From:   Andi Kleen <ak@linux.intel.com>
To:     Ian Rogers <irogers@google.com>
Cc:     Jiri Olsa <jolsa@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Michael Petlan <mpetlan@redhat.com>,
        Kajol Jain <kjain@linux.ibm.com>,
        John Garry <john.garry@huawei.com>,
        "Paul A. Clarke" <pc@us.ibm.com>,
        Stephane Eranian <eranian@google.com>
Subject: Re: [RFC 00/10] perf tools: Add support to reuse metric
Message-ID: <20200626215759.GG818054@tassilo.jf.intel.com>
References: <20200626194720.2915044-1-jolsa@kernel.org>
 <20200626212522.GF818054@tassilo.jf.intel.com>
 <CAP-5=fVMs4Ok3=gYmzheNTzbBUGGHbCr0cpJSm9TV45aeZb4Ng@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAP-5=fVMs4Ok3=gYmzheNTzbBUGGHbCr0cpJSm9TV45aeZb4Ng@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> The name could be a metric or an event, the logic for each is quite

I would say collisions are unlikely. Event names follow quite structured
patterns.

> different. You could look up an event and when it fails assume it was
> a metric, but I like the simplicity of this approach.

I don't think it's simpler for the user.

> Maybe this
> change could be adopted more widely with something like "perf stat -e
> metric:IPC -a -I 1000" rather than the current "perf stat -M IPC -a -I
> 1000".

I thought about just adding metrics to -e, without metric: of course.

-Andi