Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 27 Jun 2020 15:01:53 +1000
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc:     Jens Axboe <axboe@kernel.dk>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Pavel Begunkov <asml.silence@gmail.com>
Subject: Re: linux-next: Fixes tag needs some work in the block tree
Message-ID: <20200627150153.331c66e7@canb.auug.org.au>
In-Reply-To: <20200627015605.goc2btyq6z3wwb5z@chatter.i7.local>
References: <20200627090740.683308fd@canb.auug.org.au>
        <6920f023-5909-6ebf-606c-dbf467a31c7c@kernel.dk>
        <20200627015605.goc2btyq6z3wwb5z@chatter.i7.local>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/.lqzE9yONqv//iwsCcE6pvs";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--Sig_/.lqzE9yONqv//iwsCcE6pvs
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Konstantin,

On Fri, 26 Jun 2020 21:56:05 -0400 Konstantin Ryabitsev <konstantin@linuxfo=
undation.org> wrote:
>
> On Fri, Jun 26, 2020 at 07:32:15PM -0600, Jens Axboe wrote:
> > On 6/26/20 5:07 PM, Stephen Rothwell wrote: =20
> > > Hi all,
> > >=20
> > > In commit
> > >=20
> > >   cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")
> > >=20
> > > Fixes tag
> > >=20
> > >   Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
> > >=20
> > > has these problem(s):
> > >=20
> > >   - Subject has leading but no trailing parentheses
> > >   - Subject has leading but no trailing quotes
> > >=20
> > > Please do not split Fixes tags over more than one line. =20
> >=20
> > Gah, that's b4 messing it up. I've actually seen this before, but
> > I caught it. If you look at the actual commit, this is what the b4
> > output ends up being for the fixes line:
> >=20
> > [snip]
> > io_kiocb's result and iopoll_completed")
> >=20
> > Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
> >=20
> > even though it's correct in the email. I'm guessing some issue having to
> > do with the longer line? =20
>=20
> Yeah, I'll try to see if there's something I can do here, but it's going=
=20
> to be largely guesswork. Here's the original email:
>=20
> https://lore.kernel.org/lkml/22111b29e298f5f606130fcf4307bda99dbec089.159=
3077359.git.asml.silence@gmail.com/raw
>=20
> The Fixes: footer really does get split into two. It's not that hard to=20
> add logic just for the Fixes tag (since it conveniently follows a set=20
> pattern), but finding a universal fix for split footers will be more=20
> difficult.
>=20
> I'll see what I can do.

But (what am I missing?) the Fixes: tag has been split over 2 lines in
the original message ... on lore and my copy.  There is nothing for b4
to do here, the author needs to do this right.

--=20
Cheers,
Stephen Rothwell

--Sig_/.lqzE9yONqv//iwsCcE6pvs
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl720sEACgkQAVBC80lX
0Gykmgf/UDfTAtLD25u57q78AG7JKwLQ4PaOMcVNfAB7arKFfPMbadbdSsIN458e
jm7jaUqMLBWwLrUXiJNUoRsmzf030LiIIOkngLYzuMd6Ril0cgJq095axMUK/vS5
bmad5nwYZnO7niCltmUeQGjphPfd2mUkvpGrIMEuTDVsAAzZqeG57sFW0PwvplKB
6WAMD2dt88PrVuf6bDmHp3u9XYSYXoB6AeJxFIBOXo7BPS+7au4oea2Fy7CTTNLy
lQGdVY/jo+RFh0KRA6dUIjO1T/02VTYLrVof0bFRNjzmJM/GBBW+bbmI0+3hhdFA
CuLkUEuCiywgS1y0wzMtBaM1T323qw==
=pXT/
-----END PGP SIGNATURE-----

--Sig_/.lqzE9yONqv//iwsCcE6pvs--