Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1124842ybt; Fri, 26 Jun 2020 22:16:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqFu5Hg4La8xmtC3zU84YYihvPppAkmLQL2F3tiPfLffpCFVG/3zXXOKzQcrzli7KS54Bp X-Received: by 2002:aa7:c80d:: with SMTP id a13mr6996925edt.327.1593234991335; Fri, 26 Jun 2020 22:16:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593234991; cv=none; d=google.com; s=arc-20160816; b=kTSNbpkH2qmaYIwPQFVvCMoBgk37lntSAwVSaAIS1k/yWCxu+wgjps1YiDIkHLcpqL wqe+Y4piNficMmXlK7eCOtEhe6vgWferQTy5WbG9K3bkNxRDqGj+jgngK4QSIdy6jHOP XTo7u1eqPDMIqkQ6GQy9KDLDDn/pt9IJBtkzathJUPZeOjiI6bPuR40Hgq8EJMOLjs2x P/QHpPvnF810e8cnpjPmWGnoqSXXeO6E7xQ7K9h+R3UgyKI1ohU07JTsvHRtmElw2ezf SDI2DZRUIyVJAZGKUNlb9HPcxeO4mDdkZ9qBip7HQ7/IgptWmryQlsjxMwyu3Ydgv7x/ mPfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=B7Yo4g2/XHRVv7dQ6rLNnMcYK72cvm1KamY5mKZz7Y4=; b=HKpeOlC8w+YiZ2RvJzEhvsBq55Nk6AUGfm/MwjTIqi+a6epk4TRtS6l1uA3X9KlH+e /2RypAEK1s+I4k4AMoaHRn7WU6WqFkjF/YlsUH0N/J/CdZZQoTn7KVflA4C8AAN9C+8Q EgX7FDCDUIbgJsN+PeYkFDHCzvEb2hY0WihWKdY3H4XtfwSiNGEoMe7eNXgeD5rlQT95 x0eCgp+J2Nuj2mNtR8xn+zJMwNM6nWPsc8FzWVFGJU2dB7FBWoo/Tb/nCi4aOH4fVclO KQuUSu5xGJJG0zwEcRWGpqH8eTn+VPhVD4cAh7hbTe+kXwocQ6ZSOlSYY3FJX2q/8XwJ TKqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uTqA9Q1P; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bc14si12531443edb.368.2020.06.26.22.16.08; Fri, 26 Jun 2020 22:16:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uTqA9Q1P; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725924AbgF0FPN (ORCPT + 99 others); Sat, 27 Jun 2020 01:15:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:39020 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725840AbgF0FPM (ORCPT ); Sat, 27 Jun 2020 01:15:12 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BC6A020720; Sat, 27 Jun 2020 05:15:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593234912; bh=B7Yo4g2/XHRVv7dQ6rLNnMcYK72cvm1KamY5mKZz7Y4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uTqA9Q1Pb+K6/b8f0s37qUZOdGZmNDHQ//8VZFn4qWSvI9Kml9y2woZxbS7oRMyBf HWrKtUZefg2cGXJsi0xKd/e90X67tJg7q8q/p9C2NHLK/p0TuxUlB8u8IwsnC85l9k ZzgB9CsQLOzD22rQPyGzMoWL6shIt1GxF920Cx0E= Date: Sat, 27 Jun 2020 07:15:09 +0200 From: Greg KH To: Christophe JAILLET Cc: richard.gong@linux.intel.com, atull@kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH V3] firmware: stratix10-svc: Fix some error handling code Message-ID: <20200627051509.GC233327@kroah.com> References: <0ecc14c7-b4df-1890-fbe7-91307c2db398@wanadoo.fr> <20200626193720.949431-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200626193720.949431-1-christophe.jaillet@wanadoo.fr> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 26, 2020 at 09:37:20PM +0200, Christophe JAILLET wrote: > Fix several error handling issues: When you have to list a bunch of different things you do in a driver, that's a huge hint this needs to be broken up into multiple patches. Please do that here. thanks, greg k-h