Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1125711ybt; Fri, 26 Jun 2020 22:18:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzXyICpmFsckN6OMj5XqjhSD/lgSNK0Qj9cxqVnHNQly/V1W5Al7njt73MNzfOuc63nnb+k X-Received: by 2002:a50:d09c:: with SMTP id v28mr2100151edd.58.1593235135741; Fri, 26 Jun 2020 22:18:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593235135; cv=none; d=google.com; s=arc-20160816; b=UWfnZ5gTEYVPt2WnUEbuwHbFatW17yweH3eVjP98OBV7xfk8sYtD90YkbiHxRelhAo m7koruPTM11jPivSi4/EoauPqhKjzz/Yu+PT2mzdPl23iL62PihpY6L4Ppj2h9XxhfoQ kxkx3E8xh2w+nNX+DZNFpgcWJvt4rkli6KCY4bgkB9r7ebDz4B8nU70UQZiHH+30NgF4 PplLKD6Jnnd7Js/mh0VASg0CpgLpLwliSNuTDsVbQIiB98IwUxNm+C0iyaCKXAKlj1HJ +Xwd5ykkdfUMgu8lW9mgUPNA9YFuk/asa0XWDkbd39oOXWgWhs5K8eIVGRZfYCwcF/L8 RrsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=vrhA9tIzay29w90r+aIjC+bWKd8FuYSU3ailVBNKF3I=; b=R306XL3b78T1J2e0KZGa90UUX1bZ/dA8nhKmpNmY50C3U3UbFa8Shj5CDhQcwDO35L N/rliKAx/FvnWyM4QlqcX7zLeIjiJpP0UyETfLy0tSoNQWfl0z3/IizJlOOEmVNBtzEm r9vSGqdw3IK8zp5Gk8jlWFGYv1nMWaYIjc1ekY2fWNhbQcr7djrBs3IKyZDvYX+aMIru asLYa3dNvyExMrnQlD6Yh0lYxyvT2corsCDbBFaTERoWxq57YIKAf1C3hMXvB93yuWyg XWqcglDZ+viu5oWS3LfrgQbVyE/mYMrJNqlHiMLiRJNzctfZOAioZdcsQi5B5truMLr5 /IAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="gAHDekf/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h14si9526017edr.586.2020.06.26.22.18.32; Fri, 26 Jun 2020 22:18:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="gAHDekf/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725994AbgF0FQA (ORCPT + 99 others); Sat, 27 Jun 2020 01:16:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:39164 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725840AbgF0FP7 (ORCPT ); Sat, 27 Jun 2020 01:15:59 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2133020720; Sat, 27 Jun 2020 05:15:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593234959; bh=lB7QHcwNHl3AMdjVulKKrNrmLEOsHkSLJPONMrO8A2M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gAHDekf/EuAQJsMsJEhjmKyc/6kfNB+GFTubCBoOpQKES/DLHhrdIVFzziiKIX+Jk mUxc8+tSMtYwbzUwTpxiUrSGAdLYfgo26R4NxBpx0eUE7rDLLlAInTM8mMj6bQCnQB pAiGIf+gzr4YYw3jsZUUFhldmIh2QeR4QxC8y2Pk= Date: Sat, 27 Jun 2020 07:15:56 +0200 From: Greg KH To: Christophe JAILLET Cc: richard.gong@linux.intel.com, atull@kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH V3] firmware: stratix10-svc: Fix some error handling code Message-ID: <20200627051556.GD233327@kroah.com> References: <0ecc14c7-b4df-1890-fbe7-91307c2db398@wanadoo.fr> <20200626193720.949431-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200626193720.949431-1-christophe.jaillet@wanadoo.fr> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 26, 2020 at 09:37:20PM +0200, Christophe JAILLET wrote: > --- > v2: takes Dan's comment into account and fix another resource leak. > v3: merge the previous 4 patches in a single one to ease review No, 4 small patches are _MUCH_ easier to review than one larger one that mixes everything together. Who told you to put them together?