Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1139557ybt; Fri, 26 Jun 2020 22:52:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy1tlh47+Z6izZMUiAukbqgsiQDp8jE9c5zS9dNfQy7Esc6dolQSJRsTSpPTUmZzlpcvfkN X-Received: by 2002:a17:906:dbe5:: with SMTP id yd5mr5620378ejb.328.1593237147416; Fri, 26 Jun 2020 22:52:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593237147; cv=none; d=google.com; s=arc-20160816; b=UR710wlCIWSC4KMPzI8Jr+pRn8nKmZPX9NFLowQ0j0Z36Zu0jaDL0HLnKpb8KftOtP V4OcUWfGoOzYdso6IrEshqMainVMOYrlHL4iagvsrWMWqDe85Px19R4uy4O/TzzbrSay GEBjgRRR3EpDPbUaMWRybVC/gXqDnB0MN06t7GA3vZ/C9SRo1YpdtR4iZjIBi64vmeLn X0NoVOlAIgAoDq3tbheg7hmgS4uiBX0o7UKPeFrDGtfX32sN/pXQUq+qC7ZGS8I19f1E liy6HPgfdDDyf4U33mzfDyQHWk90vyM6KLKX+Jd89Bu+T50SC6v5QUGPxWH/7PyXapSd HsxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=/XK9O5e9WYvpLJ8CUU6lWm9WXLh2aPJdj62lrelY7z0=; b=YGuZHufx2f4nUd/btmH02b37pCs+SsA3bdksvqfJ/L11wVmiy6jxKqGQ3XPyi5HM1V SuUlHFuCa0JoTO41H2R55bMMs/9wOdZ7FGg8T7VnpBQz3PptkIN60wGCgRuoErfLvHv9 49Kj8XmvVzz3HKlWkm0iglr7E9NCgIx2gwwUtQr1o2BycunOY1n206jWUNKRbIDTX3ZA DrIOApDIKE9Tp4PotYNW15z/yu9czK05eRxrQ1Chp8qYfhK7PYziptk8mGcMNhcVydxt 32lKNS4DUvbAtv5ye7P0FZHl6UtiPHm1O6XFr4gyV4ikoVIRiQeXF/Y+uderU9cFOL7E q4TQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="PZbX8WV/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dc14si573130edb.240.2020.06.26.22.51.53; Fri, 26 Jun 2020 22:52:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="PZbX8WV/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725980AbgF0Fvk (ORCPT + 99 others); Sat, 27 Jun 2020 01:51:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725885AbgF0Fvj (ORCPT ); Sat, 27 Jun 2020 01:51:39 -0400 Received: from mail-il1-x142.google.com (mail-il1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 427F6C03E979; Fri, 26 Jun 2020 22:51:39 -0700 (PDT) Received: by mail-il1-x142.google.com with SMTP id c75so10281499ila.8; Fri, 26 Jun 2020 22:51:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/XK9O5e9WYvpLJ8CUU6lWm9WXLh2aPJdj62lrelY7z0=; b=PZbX8WV/OaNA6DgZ6Is7kfIwNjE23/oVVVKhrWXOyaLkvljZiKFQePoBr4dSVTBwSC E5Ham/C1pDzR++vWFqCyS32++gOZAMbZDS/kW+rKqCg0p3qxQvMVFeTM/zgo4uOQ+0dX fh8hQOJiJS5uvlX3uUMpqREYSLfevJbuWyqfoLDtVjVs10d0JqdcC6BPHX4LUs28VTl4 osf2a3EZCj1YCIXf4AFKI8yQuH3L0vAOBtmOYnBZlOFjr/z6YS14c0oPxOeX7i91wXFQ pYM3R4u9W0ySVOKT/fzyficDQ5xuil6YkvUyisGqmOjkhjtA8jc3y4an0/FDNet/PtuQ OvEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/XK9O5e9WYvpLJ8CUU6lWm9WXLh2aPJdj62lrelY7z0=; b=GM1VPccKK7+4bNMx00RnFfWAzjeIdk2Uzm16Q/wnHTa549SvN5C8241F4X0ZWI76jG kMMYUzAYB4tJtC7zYLj2ccLC4yj2T6Jr5EseNPBWmGqwc2Fodd/Qh5c23l0d/866AJsa p3q/3QoVP9SbRhgZjVDic8FOpUpbNlFyaYEzhGa1mO29pLZVaN++k2t5qEUM9+xsCUoC QtBbvqlSpRzU5YyHABvx5bPTMQEatlwKX5bmc8h8zIhRHpiWoVQBU8V76rebhlz6FN7U nQh010pDnHbkQe1zeID8odnt4YQOLoqB+w7lzm7gdCVtEHuztFGQ5S/xKCplej9Oc/Ak FVLg== X-Gm-Message-State: AOAM5318SI3cQ/A0EAbqzvGsP+fsAEFxaHoHgQiE5VpxYlIUWTlFQ4lN Q08XeedwVwqJt8Ms5vI37kPD0IfTPyQXZGKgBUU= X-Received: by 2002:a05:6e02:48e:: with SMTP id b14mr6281351ils.143.1593237098484; Fri, 26 Jun 2020 22:51:38 -0700 (PDT) MIME-Version: 1.0 References: <20200624175116.67911-1-vaibhavgupta40@gmail.com> <20200626.121428.112500348777695663.davem@davemloft.net> In-Reply-To: <20200626.121428.112500348777695663.davem@davemloft.net> From: Vaibhav Gupta Date: Sat, 27 Jun 2020 11:20:03 +0530 Message-ID: Subject: Re: [PATCH v1] bnx2x: use generic power management To: David Miller Cc: Vaibhav Gupta , Bjorn Helgaas , Bjorn Helgaas , bjorn@helgaas.com, Jakub Kicinski , aelior@marvell.com, skalluru@marvell.com, GR-everest-linux-l2@marvell.com, netdev@vger.kernel.org, Linux Kernel Mailing List , linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 27 Jun 2020 at 00:44, David Miller wrote: > > From: Vaibhav Gupta > Date: Wed, 24 Jun 2020 23:21:17 +0530 > > > With legacy PM, drivers themselves were responsible for managing the > > device's power states and takes care of register states. > > > > After upgrading to the generic structure, PCI core will take care of > > required tasks and drivers should do only device-specific operations. > > > > The driver was also calling bnx2x_set_power_state() to set the power state > > of the device by changing the device's registers' value. It is no more > > needed. > > > > Compile-tested only. > > > > Signed-off-by: Vaibhav Gupta > > Applied, thanks. Thanks everyone :) -- Vaibhav Gupta