Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1187236ybt; Sat, 27 Jun 2020 00:32:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwl5DXZ8SCN+RyIa0MkskwUTxDbmto7urfjLgrTMA1tu6jVSSubIQlyOtvteTC/vB9nWaN2 X-Received: by 2002:a05:6402:888:: with SMTP id e8mr7570368edy.210.1593243135063; Sat, 27 Jun 2020 00:32:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593243135; cv=none; d=google.com; s=arc-20160816; b=FTHSb8PIRRecG/GXsMbCCPTmHluNIIWXh4GKNQ3H87QFakPncIN7raAufwhDlTyJuu KIRyb9PosR5slP1Gf7hg423LuoZXnkvNJ2HD3RZ/P9uEYjaxqWiZ+sDgsnhVHhOYf9r6 sutRm94XdYfx9Z4pEN3fgh2TclRYFT13FZhyoWfBAIpRmrZTc5qhkaHqZDRPlXWv7oyZ jYwBJJLme+yqKfhdD07LpH8zlt9P4PXpf9W2oTREgFnGEFXdXaxYhSc+tUW6ePe95HzE tqLNY72a3jbPRxK1jMTMISPdt3e0NlR04+SbbogJeTxIxwyLpI2wTDkUe55r3xZ/DWZY oLiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=tAaVk5E3avl9nYDMEN53wzb99eH/KhImwBjrIL3fcbw=; b=a3rkeTqia/BfOkKTNwKfN1buPFVT9rAGrsVdSyLytBcfDhvQAJqcYwOzoV2xZlU+X8 wKkz9/iE++Bt/e/1CMSvIE5qCRhbHwCO+z+keULHw4oJCsKzIXUeOu80QkC44/nOS4e1 hrUUiJktScNsD1R4qyjb+McjAhCjtM0RwZ/fFNYr6/L1tvfMYe/VwsPl30T41DTJ+ccl dWg1n6q/ou+s6IrY5c07GLckEx3VpVHafoMzO0dLd3gD9LsBWJji7znnn8r7wWxqEMfj NHGUs6a7LaHrO66yLtwAW6SA8q9O1qBL8rTn3VwOXslG6lnJtvQxDbtSoZvBD3OrQ5+4 Hlgg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id do15si28169959ejc.430.2020.06.27.00.31.52; Sat, 27 Jun 2020 00:32:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726132AbgF0Hbd (ORCPT + 99 others); Sat, 27 Jun 2020 03:31:33 -0400 Received: from smtp06.smtpout.orange.fr ([80.12.242.128]:47333 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725885AbgF0Hbd (ORCPT ); Sat, 27 Jun 2020 03:31:33 -0400 Received: from [192.168.42.210] ([93.22.39.58]) by mwinf5d41 with ME id w7XV2200A1FGr9H037XViA; Sat, 27 Jun 2020 09:31:31 +0200 X-ME-Helo: [192.168.42.210] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 27 Jun 2020 09:31:31 +0200 X-ME-IP: 93.22.39.58 Subject: Re: [PATCH V3] firmware: stratix10-svc: Fix some error handling code To: Greg KH Cc: richard.gong@linux.intel.com, atull@kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <0ecc14c7-b4df-1890-fbe7-91307c2db398@wanadoo.fr> <20200626193720.949431-1-christophe.jaillet@wanadoo.fr> <20200627051556.GD233327@kroah.com> From: Marion & Christophe JAILLET Message-ID: Date: Sat, 27 Jun 2020 09:31:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200627051556.GD233327@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 27/06/2020 à 07:15, Greg KH a écrit : > On Fri, Jun 26, 2020 at 09:37:20PM +0200, Christophe JAILLET wrote: >> --- >> v2: takes Dan's comment into account and fix another resource leak. >> v3: merge the previous 4 patches in a single one to ease review > > No, 4 small patches are _MUCH_ easier to review than one larger one that > mixes everything together. Who told you to put them together? The cover letter of v2 serie can be found at [1]. The request for merging them in 1 patch is in [2]. V3, should be the same as v2, but all in one. [1]: https://lkml.org/lkml/2020/4/29/77 [2]: https://lkml.org/lkml/2020/5/5/541 CJ