Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1188478ybt; Sat, 27 Jun 2020 00:34:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzlnWc3qHa2w+p8drL6VNQPJRN3QmZFizPiq9FcNqaSWYZWVKsunsUATsrKVLsaT2Nh8bIt X-Received: by 2002:a17:906:c1d9:: with SMTP id bw25mr6017631ejb.271.1593243279720; Sat, 27 Jun 2020 00:34:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593243279; cv=none; d=google.com; s=arc-20160816; b=xXLxLiFCiGS50JW2W7ffkD6m+vruhwzyylW4uR2Nc2cQg2UD3IcbzLEk0XfJl5FtKe tk8wUWaXxWv7TflZMVCk2E8vwNZWmpsqGWa5YlABMO89PCJNWdXkhoOGya1b59v/m+lZ qpTjw6dbkWR7hjAA2vkkpcdOyjKYwKOePRd6JamNCLC8qtIiD01Ab7G30n3+KPiklu99 ro25wHXWpvRHp7afKSRMMu3QMR4FqbM8fqEN5lmy58HiHWf7I8kl7UT32MYxsvmcXp5R FgZH/x5NSHE9cGFQsy7cLwuc64De8+qEIH9kIvB4SeIR5vWo53Tbd0I/CVwZwkEBsvC5 C1Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vmpoA1D7dyjV06bzwDyN/+k+GU++bNP7VnywwlpIVGc=; b=fdx6lq4lssbcAnC/6WcB71rK9Q52lHxWjzfcx8Td2jnJFO6mfvG4+T9P2gF5Uspmrk +GrJKHoDgmpeAD+9hNGbtczpmEzP85mgvkjdSBSl7684TJRz65F3U33hpsKD5gyoijFm RpG07Wv3DpFfii/Gs4uTf/vkIqPDSAjmYulzprBYQpTT4QRlMgwFKKY6sI3zX1D7EObB RvINmyr0psJXtY2LjNX7J9GWUanZ2Cby7jt5HTtdn5Fu9Br4ShMfV2/u2F64KQAdL5RL f2Qcs7r3ZsT9ZFN/l/upow44TuBrafJJRfh5TpyLlV0PokbHeaFCRXuudn/CqNstR9G0 /TWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=cbYqXmVe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c68si11787950edf.428.2020.06.27.00.34.16; Sat, 27 Jun 2020 00:34:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=cbYqXmVe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726611AbgF0HdT (ORCPT + 99 others); Sat, 27 Jun 2020 03:33:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726547AbgF0HdR (ORCPT ); Sat, 27 Jun 2020 03:33:17 -0400 Received: from casper.infradead.org (unknown [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C94F2C03E979; Sat, 27 Jun 2020 00:33:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=vmpoA1D7dyjV06bzwDyN/+k+GU++bNP7VnywwlpIVGc=; b=cbYqXmVeSoBvWX/9hZmJT+Lpgl l5Y6Vcm2ctIJzcPBTMX3VolpG677Sf4JJWJZfg14gMcYc1m3NFSPX26I/Vdufl8Wj4OJD/jl2Umzw 27pEigOY5nvjxvYMvM49rAPEbxY55yRTlPi3Lbfj1+TngLfjOcWXmlbk3hcRzSGoz6hhvGr0okR7W GCJr60AtGTdEOj8PSSltng1UW/O17eCtnu6LH/wkHVpdPf76uXKO6uYRjV3pBB02z8yKJ9PAQx81q mu+xZlNzRT5mjjmmiZE8tNwZpxaMdqqkKx8I//a0cFfvkQn/kdUEIwH5bGq7AXsO0yq6LLvd29UPA 2/yaXMOg==; Received: from [2001:4bb8:184:76e3:595:ba65:ae56:65a6] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jp5KY-0006qv-AN; Sat, 27 Jun 2020 07:32:56 +0000 From: Christoph Hellwig To: Jens Axboe , Tejun Heo Cc: Dennis Zhou , Li Zefan , Johannes Weiner , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 14/14] blk-cgroup: remove a dead check in blk_throtl_bio Date: Sat, 27 Jun 2020 09:31:59 +0200 Message-Id: <20200627073159.2447325-15-hch@lst.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200627073159.2447325-1-hch@lst.de> References: <20200627073159.2447325-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org bios must have a valid block group by the time they are submitted. Signed-off-by: Christoph Hellwig --- block/blk-throttle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-throttle.c b/block/blk-throttle.c index 9d00f62c05ecdf..ad37043297ed58 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c @@ -2163,7 +2163,7 @@ bool blk_throtl_bio(struct bio *bio) struct request_queue *q = bio->bi_disk->queue; struct blkcg_gq *blkg = bio->bi_blkg; struct throtl_qnode *qn = NULL; - struct throtl_grp *tg = blkg_to_tg(blkg ?: q->root_blkg); + struct throtl_grp *tg = blkg_to_tg(blkg); struct throtl_service_queue *sq; bool rw = bio_data_dir(bio); bool throttled = false; -- 2.26.2