Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1204563ybt; Sat, 27 Jun 2020 01:10:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwU7TxyMFHH49lie28mbXYi1xg+zFK4LpgW3cOEpAbPQryOZZ1dqYqqlJWtaO1Iglggx2SV X-Received: by 2002:a05:6402:1687:: with SMTP id a7mr7322978edv.358.1593245433351; Sat, 27 Jun 2020 01:10:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593245433; cv=none; d=google.com; s=arc-20160816; b=d/NZzQIsFEKblf3Lav23XhVN/UbaY23Oo2/ReG7iYvv2XSSfAXxl3QZjgMdnevA7pL MmByUfwPe1ZgGVxXW6l8aYaWic/VzQNYE7qQ+9Xq83+1o9rS3a9S3zAAi7ww0QKASXiQ iNpz8yFsNw70RNApegAujlJNjHyKuYFmI48NPbuIQDYo40szlSU3v+0GU79uzyTTK50a vDPLRZjKVzP708POXhNd6O6ISimyDEsY47Bj3HzvJ/gmI6FJYRkyFE3J+EuhUMYVmSWC bW8smCvdlvfjUZsCAHJ5gxd2XCNstNKahl27w3eqKM9n8Nbe8RXpb/7sVli35QCxJNue 3XDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature; bh=mMs3gYZpHPvw7n5oRkve+y/cWnhNNHLz+TPT8hcajaU=; b=xgySjN8UNwqSahY451TYRAXFBITPPiAceuWI7CNquPqL7Fp9Y045O2kq/teJMXUuLG qWZSia84RsCU+dzA7F+zHinkf7ibGj8Y2ohmrYSjz1P9EazH2qjpLvxvBVR20S2FS9XU CA4bzGsvCihESgP0CYOhBp2U/FF4Qkhvv2pf/78rYBQ05CxfHECnpXq849OaMecGuife HnQL3moQ/wTmKLj4UOLYLPujYuJqH54nvru2GUQvOW9RL1YM3AC3yTn6Tg409qLO4MMQ bz0nkHFfsHUicFqrRe8U9pLKbd4w2yplPCKAiqRkZNRkwmlVfgpHkGctoe+W72/oiZRX g6ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="EgYf/6s7"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn17si24538884ejc.556.2020.06.27.01.10.09; Sat, 27 Jun 2020 01:10:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="EgYf/6s7"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726212AbgF0IKE (ORCPT + 99 others); Sat, 27 Jun 2020 04:10:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726086AbgF0IKD (ORCPT ); Sat, 27 Jun 2020 04:10:03 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0B97C03E979; Sat, 27 Jun 2020 01:10:02 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id d194so2658529pga.13; Sat, 27 Jun 2020 01:10:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=mMs3gYZpHPvw7n5oRkve+y/cWnhNNHLz+TPT8hcajaU=; b=EgYf/6s7SYl2cpDHK5aBJ9oObbELwUgjBNjVufgUHhT65ouUSRazVsC7Ji7kkYR6R+ kdU8pxS+rKvod5npBCNK+RD5y8zeHYKVRKkTg22Gud7QNs+EoZdqdtWDj1iIdyGADSFB Q5RNc8hNS8SOf0FrSWQ2XZtggTdWicPWfyBdlkz7TQXKUJUqQGZYW1R//2RIhF22Hape ey1M+A120DoApdjrZ/33qTHZ56theKKsJEj305KMTxqXNB+iSxFF4f40W8ymlQwqCo29 REoUc9s3Utxhf3RLlgO1Fk4WeK6w0SprU6m8O2hfQ5WdA6aITTYqJE8OsIkYvL/Cn9Jh APnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=mMs3gYZpHPvw7n5oRkve+y/cWnhNNHLz+TPT8hcajaU=; b=AG9TJQspnVtw9dbWa6pdann2MAu/n+/6d0Tk8qKOKzzja7SFlBGgUmaFFE7Uz4SGpu NhlqshQeqQ9ET94p5Wn6AC3lIVx1Gbf5xslCA+UrAWdIXYpXAd40lniqV7aJoktrrxaq Q5dXCZAlQ/7CaIj32Gjb7cB9bNx0z1Nk1yQ6LpATxF2m71v7111VybLFL/7mdnrOtC+e 6zCdm/RJ47enwzYUNVu/2IozF6DGHci4OypUdRH11Ts05yQD3BSN3wx2hEgTLNeLURR2 vWTVRG0oB+XAZ9QVRuUyB4KnUPlK1d5vG99HiTV1TSJHzFLDL8xylqUxOQpvVlsj6U/9 1dmg== X-Gm-Message-State: AOAM532QNQExkcdrxhpBJoZChUTye+pa3N+bKtYdi2iUHXA4AJs3VTRs dCRgjGBSG1N9g5GsrVWuW8s= X-Received: by 2002:a63:380d:: with SMTP id f13mr2314214pga.16.1593245402252; Sat, 27 Jun 2020 01:10:02 -0700 (PDT) Received: from syed ([106.198.224.34]) by smtp.gmail.com with ESMTPSA id h6sm4195780pfg.25.2020.06.27.01.09.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 27 Jun 2020 01:10:01 -0700 (PDT) Date: Sat, 27 Jun 2020 13:39:42 +0530 From: Syed Nayyar Waris To: linus.walleij@linaro.org Cc: andriy.shevchenko@linux.intel.com, vilhelm.gray@gmail.com, michal.simek@xilinx.com, arnd@arndb.de, rrichter@marvell.com, linus.walleij@linaro.org, bgolaszewski@baylibre.com, yamada.masahiro@socionext.com, rui.zhang@intel.com, daniel.lezcano@linaro.org, amit.kucheria@verdurent.com, linux-arch@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Subject: [PATCH v9 0/4] Introduce the for_each_set_clump macro Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Linus, Since this patchset primarily affects GPIO drivers, would you like to pick it up through your GPIO tree? This patchset introduces a new generic version of for_each_set_clump. The previous version of for_each_set_clump8 used a fixed size 8-bit clump, but the new generic version can work with clump of any size but less than or equal to BITS_PER_LONG. The patchset utilizes the new macro in several GPIO drivers. The earlier 8-bit for_each_set_clump8 facilitated a for-loop syntax that iterates over a memory region entire groups of set bits at a time. For example, suppose you would like to iterate over a 32-bit integer 8 bits at a time, skipping over 8-bit groups with no set bit, where XXXXXXXX represents the current 8-bit group: Example: 10111110 00000000 11111111 00110011 First loop: 10111110 00000000 11111111 XXXXXXXX Second loop: 10111110 00000000 XXXXXXXX 00110011 Third loop: XXXXXXXX 00000000 11111111 00110011 Each iteration of the loop returns the next 8-bit group that has at least one set bit. But with the new for_each_set_clump the clump size can be different from 8 bits. Moreover, the clump can be split at word boundary in situations where word size is not multiple of clump size. Following are examples showing the working of new macro for clump sizes of 24 bits and 6 bits. Example 1: clump size: 24 bits, Number of clumps (or ports): 10 bitmap stores the bit information from where successive clumps are retrieved. /* bitmap memory region */ 0x00aa0000ff000000; /* Most significant bits */ 0xaaaaaa0000ff0000; 0x000000aa000000aa; 0xbbbbabcdeffedcba; /* Least significant bits */ Different iterations of for_each_set_clump:- 'offset' is the bit position and 'clump' is the 24 bit clump from the above bitmap. Iteration first: offset: 0 clump: 0xfedcba Iteration second: offset: 24 clump: 0xabcdef Iteration third: offset: 48 clump: 0xaabbbb Iteration fourth: offset: 96 clump: 0xaa Iteration fifth: offset: 144 clump: 0xff Iteration sixth: offset: 168 clump: 0xaaaaaa Iteration seventh: offset: 216 clump: 0xff Loop breaks because in the end the remaining bits (0x00aa) size was less than clump size of 24 bits. In above example it can be seen that in iteration third, the 24 bit clump that was retrieved was split between bitmap[0] and bitmap[1]. This example also shows that 24 bit zeroes if present in between, were skipped (preserving the previous for_each_set_macro8 behaviour). Example 2: clump size = 6 bits, Number of clumps (or ports) = 3. /* bitmap memory region */ 0x00aa0000ff000000; /* Most significant bits */ 0xaaaaaa0000ff0000; 0x0f00000000000000; 0x0000000000000ac0; /* Least significant bits */ Different iterations of for_each_set_clump: 'offset' is the bit position and 'clump' is the 6 bit clump from the above bitmap. Iteration first: offset: 6 clump: 0x2b Loop breaks because 6 * 3 = 18 bits traversed in bitmap. Here 6 * 3 is clump size * no. of clumps. Changes in v9: - [Patch 4/4]: Remove looping of 'for_each_set_clump' and instead process two halves of a 64-bit bitmap separately or individually. Use normal spin_lock call for second inner lock. And take the spin_lock_init call outside the 'if' condition in the probe function of driver. Changes in v8: - [Patch 2/4]: Minor change: Use '__initdata' for correct section mismatch in 'clump_test_data' array. Changes in v7: - [Patch 2/4]: Minor changes: Use macro 'DECLARE_BITMAP()' and split 'struct' definition and test data. Changes in v6: - [Patch 2/4]: Make 'for loop' inside test_for_each_set_clump more succinct. Changes in v5: - [Patch 4/4]: Minor change: Hardcode value for better code readability. Changes in v4: - [Patch 2/4]: Use 'for' loop in test function of for_each_set_clump. - [Patch 3/4]: Minor change: Inline value for better code readability. - [Patch 4/4]: Minor change: Inline value for better code readability. Changes in v3: - [Patch 3/4]: Change datatype of some variables from u64 to unsigned long in function thunderx_gpio_set_multiple. CHanges in v2: - [Patch 2/4]: Unify different tests for 'for_each_set_clump'. Pass test data as function parameters. - [Patch 2/4]: Remove unnecessary bitmap_zero calls. Syed Nayyar Waris (4): bitops: Introduce the for_each_set_clump macro lib/test_bitmap.c: Add for_each_set_clump test cases gpio: thunderx: Utilize for_each_set_clump macro gpio: xilinx: Utilize generic bitmap_get_value and _set_value. drivers/gpio/gpio-thunderx.c | 11 ++- drivers/gpio/gpio-xilinx.c | 66 +++++++------- include/asm-generic/bitops/find.h | 19 ++++ include/linux/bitmap.h | 61 +++++++++++++ include/linux/bitops.h | 13 +++ lib/find_bit.c | 14 +++ lib/test_bitmap.c | 145 ++++++++++++++++++++++++++++++ 7 files changed, 292 insertions(+), 37 deletions(-) base-commit: b3a9e3b9622ae10064826dccb4f7a52bd88c7407 -- 2.26.2