Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ath10k: Add history for tracking certain events
To:     Rakesh Pillai <pillair@codeaurora.org>, ath10k@lists.infradead.org
References: <1593238973-23237-1-git-send-email-pillair@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
From:   Ben Greear <greearb@candelatech.com>
Message-ID: <926301ed-e27f-0d8f-0177-6484bfffa40c@candelatech.com>
Date:   Sat, 27 Jun 2020 08:28:11 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <1593238973-23237-1-git-send-email-pillair@codeaurora.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 06/26/2020 11:22 PM, Rakesh Pillai wrote:
> For debugging many issues, a history of the
> below mentioned events can help get an idea
> of what exactly was going on just before any
> issue occurred in the system. These event
> history will be collected only when the host
> driver is run in debug mode (i.e. with the
> config ATH10K_DEBUG enabled).

This should be disabled by default unless user specifically pokes some debugfs
value to turn it on so that it does not impact performance.

Thanks,
Ben

>
> Add history for tracking the below events
> - register read
> - register write
> - IRQ trigger
> - IRQ Enable
> - IRQ Disable
> - NAPI poll
> - CE service
> - WMI cmd
> - WMI event
> - WMI tx completion
>
> This will help in debugging any crash or any
> improper behaviour.


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com