Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2095688ybt; Sun, 28 Jun 2020 07:56:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx82I/Iawv8RaKyFTC0pGsjiHmy45/VsVSJeKdnxmZoibeUdX5+sDD9+drjDY5rDU0MI/FL X-Received: by 2002:a17:906:f911:: with SMTP id lc17mr10761761ejb.330.1593356211811; Sun, 28 Jun 2020 07:56:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593356211; cv=none; d=google.com; s=arc-20160816; b=DaANPDMW+a53z0XTFBrbyecVyZev82Gsqu0zzMR8pMCsZY567tZOwibOsxcTdPazVM HxzpeejdSZJWfZOKI776RuiLs697bgRsboSbvkpY3RfI8L0f6Lw18CBUA+h8AqugvCHJ sb5w4VX2GbRLfVzpmUuAw5iI1pWgKWhN70AsFTmgLoB1VkmrqAXZpSkestyXyuM1Bdbp 1S5Mau+yucSnt2uGczRV8MWUcPhZVQFMdkUQ9Jy2Pft9zJ+uxO7eOBQSvW1fHdyY5Y13 Uzgry5qWQmXNsZU/eglvEx9fYOlL3PQr0GaMJCY5LeI1sCbYyQAZ7bAqEY1uoJ8nzYMd 2mCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:to:from:subject:message-id; bh=0ibELsdHsBPOVjr5cbU/a6ZS5XVsbdPJ1ISbQUbU7KE=; b=QeAfe6XWvVnKaOmS5MdBFnZyH5h7nu1AyerCzwURfZEAamoF9GqodNUrEuM3sqhs94 Fc5DOMLetmA4EnTRdm6xrPFrm9uh/IVUyWAqAQr+Zqum3OD+73RAYrE1RUs+CRXvnXWR kJTzAMAw2E+jKX3tyciHfAmZBF4Pm0/tLsaKEN+sNukIH6txUh5REhJAnHfkQ17KhruZ 0ONYrEAUeS9P8sEs7E3SN70QAZ0A+/9+J9TFJOMFwS9CbLdgyJH/2wk8xKINO84AZXc7 wvtux03nC7uhlIkfTmyMSKx7MOpWb2AUEZYsrfMeOcb3aVRRqnU80r6ku+M3n2DshWxo bWOA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cw22si6431346ejb.61.2020.06.28.07.56.29; Sun, 28 Jun 2020 07:56:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726401AbgF1Oxo (ORCPT + 99 others); Sun, 28 Jun 2020 10:53:44 -0400 Received: from smtprelay0032.hostedemail.com ([216.40.44.32]:35450 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726090AbgF1Oxo (ORCPT ); Sun, 28 Jun 2020 10:53:44 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id C1D57180A7A94; Sun, 28 Jun 2020 14:53:43 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,,RULES_HIT:41:355:379:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1381:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:2919:3138:3139:3140:3141:3142:3352:3622:3865:3867:3870:3871:3872:3874:4321:4362:4470:5007:7904:10004:10400:10848:11026:11232:11658:11914:12043:12297:12438:12740:12760:12895:13019:13069:13311:13357:13439:14096:14097:14181:14659:14721:21080:21451:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: son96_2a15f4c26e67 X-Filterd-Recvd-Size: 1599 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf12.hostedemail.com (Postfix) with ESMTPA; Sun, 28 Jun 2020 14:53:42 +0000 (UTC) Message-ID: <09010c9aa795a8dcbd4408ceb2a39ddc57c85037.camel@perches.com> Subject: Re: [REPORT] False positive errors found while using scripts/checkpatch.pl From: Joe Perches To: B K Karthik , Andy Whitcroft , linux-kernel@vger.kernel.org Date: Sun, 28 Jun 2020 07:53:41 -0700 In-Reply-To: <20200628140046.imqmf5vy2vvbwkzo@pesu-pes-edu> References: <20200628140046.imqmf5vy2vvbwkzo@pesu-pes-edu> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.2-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2020-06-28 at 10:00 -0400, B K Karthik wrote: > The following are reported while using checkpatch.pl on > drivers/staging/fbtft/fbtft-bus.c > > ERROR: space prohibited before that close parenthesis ')' > #65: FILE: drivers/staging/fbtft/fbtft-bus.c:65: > +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, ) > > ERROR: space prohibited before that close parenthesis ')' > #67: FILE: drivers/staging/fbtft/fbtft-bus.c:67: > +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, ) > > These are false positives as correcting these issues breaks the build. Thanks, there's no capability to recognize this in checkpatch. checkpatch is not a compiler. Perhaps a reasonable solution is to add a comment around the macro uses that show it's an unusual case.