Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2967818ybt; Mon, 29 Jun 2020 11:42:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvP9ik+qeSG9/KRafQe6YV4t9rOTVhil5fkaAnIiueggffcw7Na9Cuu8DpIAYy65dYnB3X X-Received: by 2002:a05:6402:306a:: with SMTP id bs10mr11497839edb.51.1593456147509; Mon, 29 Jun 2020 11:42:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593456147; cv=none; d=google.com; s=arc-20160816; b=l0FntjeSoizmVvJ5QlP48kMOceNcLlY1VIA9czStek11ppyUePiw5bEmbW8fqPMcym DQ+IrgkQxk1axjWamfglMDu45fwpWFJMr25fXn8UF34VJbFpw2a6aIJUOUq/Ry8K4YOW b1MbVfViHicMZfVT6mQWV3f91XkVXCqOr08Rk2yQuKD52M3YgBCzSiyXKuQ/VSfvId6F JkPVZemCZG9fX5b0meKWxwi/PekogloxImEfl+/Gqj9Mfc1bOSar2VSe+nootJGNrhtc d6NTk5+zDyJ043jgL3Tcd8GhBCtKCsypyuJIUzg2TFYdEsE1h+y+wilWNLq7DjiHFiTo 83MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=KPjg46hc7It6scVCoYw0bOK0pHdVyOL/ZwepEJbZK8g=; b=xb/9mFqk2bFNJZMmMoUCUhnjkxl/mRKP5zzai+kAyupbF7C/vItso8RbOp/EAH/8iG cZ7uOHelQBkUqziKfjscFMPWcxtM6sEzKW2Eu6NGQSuyHAmhQw6jVn6a9mapEUTyEqAg yw/+3lTMJ81CJUaYvXWmnpdwucwq7NVkyEQjONCChvuYlRU5i7scXpJuy9jBjCGD5J32 10Dh1lPZRNCReCF0S4+50iX+p0ZYuDbj+wnLwN+Smgz85n04+PwjWFgFut8z4SqcWc95 C9tKaIMp88QcL3/Unf3u0fHnIxYOQmnbw1oI4VkpG71R+Uc+QJaOBg9IYGRa1wwIqrDe HYDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hv4Xb2fn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c3si216788edn.385.2020.06.29.11.42.04; Mon, 29 Jun 2020 11:42:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hv4Xb2fn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728933AbgF2SlZ (ORCPT + 99 others); Mon, 29 Jun 2020 14:41:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:60640 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728796AbgF2SlV (ORCPT ); Mon, 29 Jun 2020 14:41:21 -0400 Received: from localhost (p54b33454.dip0.t-ipconnect.de [84.179.52.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ACB7D23330; Mon, 29 Jun 2020 08:20:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593418843; bh=oETRBPxtYtxipIP7tlc+E292rD73tY/GD0pESofHmHE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hv4Xb2fnbJvyfdHB8wZrvJezbIXw7C6xj6k7J/4essdp4b7grCD1gPUMJESGnL3Ey 1ISZ7c+xvK3Gj3jnfmfTBslm5gqxQya1g//4E83DWIZwNgS5sZKtbt+or0+P+PIsIz zDrqKeqYSvJ6956wj7DnV70y/k+Jb6pcF9IegBjI= Date: Mon, 29 Jun 2020 10:20:37 +0200 From: Wolfram Sang To: Lee Jones Cc: arnd@arndb.de, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/10] misc: eeprom: eeprom_93cx6: Repair function arg descriptions Message-ID: <20200629082037.GA1063@kunai> References: <20200626130525.389469-1-lee.jones@linaro.org> <20200626130525.389469-7-lee.jones@linaro.org> <20200627203357.GA954@ninjato> <20200629081436.GH177734@dell> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="YiEDa0DAkWCtVeE4" Content-Disposition: inline In-Reply-To: <20200629081436.GH177734@dell> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --YiEDa0DAkWCtVeE4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > > @@ -270,7 +270,7 @@ EXPORT_SYMBOL_GPL(eeprom_93cx6_readb); > > > * @eeprom: Pointer to eeprom structure > > > * @byte: Index from where we should start reading > > > * @data: target pointer where the information will have to be stored > > > - * @words: Number of bytes that should be read. > > > + * @bytes: Number of bytes that should be read. > >=20 > > Now we have 'byte' and 'bytes' here as arguments which is confusing. I > > think renaming 'words' into 'num_bytes' would be even better. >=20 > I await your patch with bated breath. :) ? You are touching it already, why a second patch? --YiEDa0DAkWCtVeE4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl75pFEACgkQFA3kzBSg KbZ+UhAAr9/7V7v960Y8EbQmYPt20ZwDmUSrxcv3w10vVDO1l3vK9mGMUADQGTkd LYJQnnOHFQ76g3cnWgeX4GBN+q9QZZ4/XlhB7hT6kr0d0PU9VngGmnRLdMeCSBHr xxNcVQueXka2skTnI5rXfv0NpXCqFqgQAofWJMI5da+m8fLgYr1fZavRjIOfomaf UtGE4KbCXE5/yveZyINqQWSts3elkJBmDFzsC5XoAj402dNK77dp+y6uSp+Ub0U7 62PxSaTVsk5vlsY6kyM4uJVSzbl3Vf9YFN/i6gLdvDkwFhwRqyhDDtEI1xz0ljww PK0kqol3Gygwh+IuudwrjZtBV3KkSeFGgE75yz+SoVHWLAhzVlPXqptOPi3QV6eE PHnLmO2GFyj+fiV3SuyVJ2Y42+mRbyW/7ElsBa1CNMy2djxdn6qk9VeFXdgAtu5x GvXjgHy0jCU12k69fnForN4X5blL+qwimHM+7SImDsdRBAeOzFGlYpdzoGSgZYOd L32rqooQtCRifiqy7+oiGhs3sZ9XxGnIRaxbSKAAOAF8F3NtDFUhIGewS/txtYg7 ziE1WXPeL9HyBHHG4zhllNLbAu2lvrcdyXuZmZ3vcFNm5vYQPQDvje2Y4xz3Ovc7 81tAaNigqc4a+/UxotydmPzUrVLfgDAFcy9pEJps2UUh7aWe6mY= =pbXc -----END PGP SIGNATURE----- --YiEDa0DAkWCtVeE4--