Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2970992ybt; Mon, 29 Jun 2020 11:47:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdtBaC6hV7gAhr30sfD63Ef68hJZMth5wZ2gTZO2IN+ZVsxg5tFJl3DhZNP2zEKSUfkoNE X-Received: by 2002:a17:906:9244:: with SMTP id c4mr14916020ejx.60.1593456435443; Mon, 29 Jun 2020 11:47:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593456435; cv=none; d=google.com; s=arc-20160816; b=einAnKHi5kxqRar1g+zgQ4uH6QiouYN4OJHbE+v+Cmgcxvnr8no6EGDhkLctj3RoJg 5FaDcJnU8QFnj4EWAa71C6g6Avq+ic8uD5dq3pyJdcoVcMAnRCKFdWtCxwphtnmsaQKK olfMGpAOSKExqAV9jV3Zo89Qciskotzke6iHzI8205+y57dT7L1AI/sCP1Psv4PJPzss gyudL2eH/OuHZAEkO1aSVknDnny+tTpO8yK4OHxixLp+iA9e0rqVdla9P9ii6kg7W2OD 8JUK7WPDSWKmQiLu25miSUn2EN4lvnUPWYhmGEYFjz3LW8Pu6FxKgOD6WzbqnrQDaaHo ATtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :ironport-sdr:dkim-signature:ironport-sdr; bh=qT5RkwRTKW0UaWv2DpFpTq49TJav28tuaQg/9Nc5x1g=; b=D0BdezicEY9tPGLBrQ6PEj3+TXFo5ozpic/MMn//Gpgxs+wswaEamcdUyjx5hTR6V5 izzuO6SJnBnOE3jaqrcNK94FfeSYXRLSmF5d2TFb8vDRvHZyFXaa5490FWvtPtniL31Y Z+2SP+f2u70cjkNlcgG9mk7TlsjJRzCLVAHqYKg9OE92GCA0oCjPVKEUchIaLdhXVQU7 jn6rN/rK5BECqM5zsqVp9CEmZB0sdvLtuGQ8pREecxYkTDwfY5gb7l8YmWG4EzCztI9F jxjgo0i0pHmRGNWmrBmJjrZ83qaMUeUsy1VeUpXlJDz6SnHWEiM/GeDj9nFgPkIe2bg8 3PpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@tq-group.com header.s=key1 header.b=LPesvD1r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t22si198772edr.571.2020.06.29.11.46.52; Mon, 29 Jun 2020 11:47:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@tq-group.com header.s=key1 header.b=LPesvD1r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729044AbgF2Soq (ORCPT + 99 others); Mon, 29 Jun 2020 14:44:46 -0400 Received: from mx1.tq-group.com ([62.157.118.193]:13134 "EHLO mx1.tq-group.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729232AbgF2Soo (ORCPT ); Mon, 29 Jun 2020 14:44:44 -0400 IronPort-SDR: 1FbhWjwLcEdn1Q0su9oP38NdY2BKY6oXeFifTV9dO+033aukPIh430pBrmZ1g0n3zOXxH9lRL1 7tf8AxYnlIkNxvdhh0LbyXMkotSJTW8gUyW3NZsJ0wOlfc0d9Naew0Jg9b03KycF9Ex7VzXslI 4VaHJGdgzY+qPGevaqx8fU3JG896QEFyxxnKKDtT6rJ2Sud/pb3e+8Ja+GDSK+c39aPDUwiuBR mK4m0EjeNNa+jzwZF5DDAztyxBAlCTv9SootrYyj8pd0RL4xVtto9Rr9WCmF7u5eEXl5OU6LRG Wlk= X-IronPort-AV: E=Sophos;i="5.75,294,1589234400"; d="scan'208";a="12880961" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 29 Jun 2020 15:22:03 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Mon, 29 Jun 2020 15:22:03 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Mon, 29 Jun 2020 15:22:03 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1593436923; x=1624972923; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=d765UglviXAqW+GAijNHXP9xNKKGdAwIhk+fTvwY8VY=; b=LPesvD1rXXYhkRpxl1FfikAZIZD/im6ie8wuU/x98l56AY+NiRGXLDhL a9dLbgeIweQlEIZfGaGtaXY2LmOn6EGIE2EHvYxDC/UrWTWpkmkbQkNjs MxSrafFu4JnXnF9BI5WYt8KXgErmM7Teyj+b/kncNubiJZgXrqlGNjL/5 J7ScWseQmjRtHCtTtVT55ZPAYmUib2dJfoUeSgEFnDc3071pK78GHkQGW jlBHlEFex9vaWIaj8Rw2TyC3Xf4+Lcs0P3JMMLGac8h0H2Htj+k0HlIEh UVRl6hex7UG0qRY5DltPSiRRnGFvCCA9Pibg9qdpdsBH1LJGqw8kycPi3 A==; IronPort-SDR: e+L1oTFDLOrjFOUDjEXWydcdezL20EffWxOmHbukB/o/vXOiCuLRGv7XJ+HsiX4z+tLAaf163B CtfaaEHOxpUCdWGOb7oZU2r2oEv7hh9bwOvHBE+i0KynHNXnNpLQpYiF0p8oslv8qv8GnoARSe OpC+3mLqTwFr41W0W2JFQ5LJlzNaF4JwE1gJMsoY4Z3Us09XtGKRf+fdsKWGTY5+1d7lHxQWEC a2Qpd8AaZqIpCd9tfPMS/i488P/znhWF+nnRpWKGpZLKI88JanWcXQvS3WllWlLjjDvIdBA+eF QkE= X-IronPort-AV: E=Sophos;i="5.75,294,1589234400"; d="scan'208";a="12880960" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 29 Jun 2020 15:22:03 +0200 Received: from schifferm-ubuntu4.tq-net.de (schifferm-ubuntu4.tq-net.de [10.117.49.26]) by vtuxmail01.tq-net.de (Postfix) with ESMTPA id 5DB1F280065; Mon, 29 Jun 2020 15:22:03 +0200 (CEST) Message-ID: <570474bcc4055527d85ca8cf84b653f56bef3e23.camel@ew.tq-group.com> Subject: Re: (EXT) Re: [PATCH] mtd: spi-nor: micron-st: enable 4-byte opcodes for n25q512a From: Matthias Schiffer To: Tudor.Ambarus@microchip.com Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, michael.krummsdorf@tq-group.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com Date: Mon, 29 Jun 2020 15:22:01 +0200 In-Reply-To: References: <20200610091616.29555-1-matthias.schiffer@ew.tq-group.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-06-29 at 13:02 +0000, Tudor.Ambarus@microchip.com wrote: > Hi, Matthias, > > On 6/10/20 12:16 PM, Matthias Schiffer wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you > > know the content is safe > > > > From: Michael Krummsdorf > > > > Set SPI_NOR_4B_OPCODES, as the flash supports 4-byte opcodes. > > I remember that we stripped SPI_NOR_4B_OPCODES intentionally for the > n25q > flashes, check https://lkml.org/lkml/2019/12/5/50. > > Cheers, > ta Ah, thank you for the pointer. Looking at a boot log of a more recent kernel again, the SPI-NOR flash on our hardware is actually detected as mt25qu512a and not n25q512a now, so everything should work as expected without this patch.