Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2978055ybt; Mon, 29 Jun 2020 11:59:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxs4D+Gp4prg+70/OaOaWLv/xilAgqCAf8dJzZmHOg2pF19WGYGVlzRrdr0azZatA9SZyjj X-Received: by 2002:a05:6402:1c0f:: with SMTP id ck15mr18323284edb.155.1593457176205; Mon, 29 Jun 2020 11:59:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593457176; cv=none; d=google.com; s=arc-20160816; b=plTRPbzVzlXfctT4TOeq2+AjaJaVSa08+A2gwQDr4LoZdowGrDV90VClWmxxRpl/QF I896eP/PjHqoG6RXFWKIY38POAOeLbnuf74YQYuEq8yWdXsyyjihB1GgkC8nuEEj0vGt G6gsr7+pb/QZoq5theVzmJdD4Bc01qyWOkKJdPn3gZC5iB/IXHah2l4vHHmoeXABWc3d O9vq3gKjaAlIEyz6eprJsNG6s3tcQir/CegMbXCsotzxepCyP8zWTn5QUtCoHJ+asGBp mV6sF53nsoSWCzzwTbuxFvl6Ac3hX3S2FgeNiZcCJmsudALbYjxjrP7KVTVbCxu8Ja0i LurA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :dlp-reaction:dlp-version:dlp-product:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=Qyj+1crU+GGlEALO+4dFVC7dLMuIomA4eXcjOSPQoN8=; b=agrX/zwuJ0quxGL/DzzPVRFd4yHROPqHg+6lwUJ7EpKQOzV6MALCoYggmIUTsziIq7 O9BI+x2+hCjEvKKa/OEZTZZ0lQOthllOAp4X3xZNCIiGHLQW9Gm6Rn46DHeLm+ON7H2J 2h7YOGaCiqOVx9FIIwNtcs+GzDbL/CkHLMXflCsG/EF4kcenDgnrkQ5aonLCgQmXyAny txGnzavu6cZ8EqBQS/LW4h4uE0cwbyhbm/3FbRHNnFzqtyVZqJOAcivMNJ/+HsCApB+e DN0rQ/ul37jkLdOzf664TDiwaPp/jNod6ERfkSvhW/5OHJzy09+Tgo5oiAfI7EwRkZly cpAw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h23si272164ejx.452.2020.06.29.11.59.12; Mon, 29 Jun 2020 11:59:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729964AbgF2S7E convert rfc822-to-8bit (ORCPT + 99 others); Mon, 29 Jun 2020 14:59:04 -0400 Received: from mga09.intel.com ([134.134.136.24]:65099 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726960AbgF2S6y (ORCPT ); Mon, 29 Jun 2020 14:58:54 -0400 IronPort-SDR: eKoD8V2wqTWUE0QfvlcDWBj2fUJGp1JQFAZEWCcOdd9RB6Iz2k79WYN3SDqzCHfZ5x5HJtYUrS TCxYV5wPo5rQ== X-IronPort-AV: E=McAfee;i="6000,8403,9666"; a="147558727" X-IronPort-AV: E=Sophos;i="5.75,295,1589266800"; d="scan'208";a="147558727" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2020 10:18:48 -0700 IronPort-SDR: PfovTJ7ctRVVTVNzrBgATY6YChrZ/17qHIHtYJnPMMZEpZLRlO/kZ9uRGO0xFF6kZv7z2obVoF C6l1q1l38H6w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,295,1589266800"; d="scan'208";a="424885466" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga004.jf.intel.com with ESMTP; 29 Jun 2020 10:18:47 -0700 Received: from orsmsx112.amr.corp.intel.com ([169.254.3.199]) by ORSMSX106.amr.corp.intel.com ([169.254.1.104]) with mapi id 14.03.0439.000; Mon, 29 Jun 2020 10:18:47 -0700 From: "Kirsher, Jeffrey T" To: Bartosz Golaszewski , "David S . Miller" , Jakub Kicinski , John Crispin , Sean Wang , Mark Lee , Matthias Brugger , "Heiner Kallweit" , Andrew Lunn , "Florian Fainelli" , Russell King , "Rob Herring" , Frank Rowand CC: "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , "devicetree@vger.kernel.org" , Bartosz Golaszewski Subject: RE: [PATCH v2 02/10] net: ethernet: ixgbe: don't call devm_mdiobus_free() Thread-Topic: [PATCH v2 02/10] net: ethernet: ixgbe: don't call devm_mdiobus_free() Thread-Index: AQHWTg2KqoUStuk1GEW2zcU3EcxbWKjv1lQw Date: Mon, 29 Jun 2020 17:18:46 +0000 Message-ID: <61CC2BC414934749BD9F5BF3D5D940449874064D@ORSMSX112.amr.corp.intel.com> References: <20200629120346.4382-1-brgl@bgdev.pl> <20200629120346.4382-3-brgl@bgdev.pl> In-Reply-To: <20200629120346.4382-3-brgl@bgdev.pl> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Bartosz Golaszewski > Sent: Monday, June 29, 2020 05:04 > To: Kirsher, Jeffrey T ; David S . Miller > ; Jakub Kicinski ; John Crispin > ; Sean Wang ; Mark Lee > ; Matthias Brugger > ; Heiner Kallweit ; Andrew > Lunn ; Florian Fainelli ; Russell King > ; Rob Herring ; Frank Rowand > > Cc: linux-kernel@vger.kernel.org; netdev@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-mediatek@lists.infradead.org; > devicetree@vger.kernel.org; Bartosz Golaszewski > > Subject: [PATCH v2 02/10] net: ethernet: ixgbe: don't call > devm_mdiobus_free() > > From: Bartosz Golaszewski > > The idea behind devres is that the release callbacks are called if probe fails. As > we now check the return value of ixgbe_mii_bus_init(), we can drop the call > devm_mdiobus_free() in error path as the release callback will be called > automatically. > > Signed-off-by: Bartosz Golaszewski Acked-by: Jeff Kirsher > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 14 +++----------- > 1 file changed, 3 insertions(+), 11 deletions(-)