Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2997305ybt;
        Mon, 29 Jun 2020 12:27:39 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJyXi82A5uu5+e/Lvm0n4wjlnf/epFJTjHjAfo6TVmlyGyhKpva0Co2ntKd7EULgDF+jVW15
X-Received: by 2002:a17:906:2f13:: with SMTP id v19mr6782237eji.282.1593458859361;
        Mon, 29 Jun 2020 12:27:39 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1593458859; cv=none;
        d=google.com; s=arc-20160816;
        b=MR0Tf6FDcTvnfdK3Is0ytuEtoM1ez9v1P52pZxeD4U5RhY0ZYiHFQP3Q1rspgUFqfP
         /e95lvD/FZ2PZXgAL0S+SsSLoWVxJKOsgUZ1J+i2YTQAZpLa3YYnOAvEABRTLqv5Ac9J
         95NnC6n5DbhTU59zTfNGynGMCiUZDHsWseQqd6H6QoeMbLxT1W4+912APVwbxHkk4RQj
         o+/iRmecFcCbj6drDVVio2ME/tp2gVefFJfE6GgqCeAjMJ4CDxBtg8+0XesauffUViND
         QAoF9yi5MgJQuXmilFQl0avdp/gyzVRlwB5IwU5YblrFhR8LpTyuuXJVsTERGlJ3NETS
         x90w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:to:subject:cc;
        bh=vfUlacqPqumAcLV/c3aep1ECOFfwdUJzoe5RzrENPw0=;
        b=zlGwAvnV36EPn2F+vRYOQGDQq8yMnTnyZcukn90XTQfjD4X19AScMeuZzeckQWwoSW
         1j/mnkcjQDmIEcouwTEh2b+JO2msRoCRfzpQ2npHYzd/TksOROlocfke/DGuZKpZZd7W
         FkV4mrLXdO0tM2/FsPzi16SEAYpP8bMkwEPqy1kavm9qlwG5D3cxeNx94KExq+FbcMP4
         7OlU6wCPIUU08dkIyqSEayzW/iSJ+07BMevKwPKHbxlKT6bx0uiuKp75vNMd6hZS5K5I
         QCSEPIdMCkVlgTwWVOCNj+l8qAHFlhr3LgD9wEUrDnfxUm+ptTjGOUJ/+ef2LJLsiaI7
         oGuA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=VnC8bHc+;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id r5si380063ejx.422.2020.06.29.12.27.16;
        Mon, 29 Jun 2020 12:27:39 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=VnC8bHc+;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1732381AbgF2T1K (ORCPT <rfc822;ttoukan.linux@gmail.com>
        + 99 others); Mon, 29 Jun 2020 15:27:10 -0400
Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:10622 "EHLO
        hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1732315AbgF2T1H (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 29 Jun 2020 15:27:07 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5efa226f0000>; Mon, 29 Jun 2020 10:18:39 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Mon, 29 Jun 2020 10:19:28 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Mon, 29 Jun 2020 10:19:28 -0700
Received: from [10.25.103.164] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 29 Jun
 2020 17:19:20 +0000
CC:     <spujar@nvidia.com>, <broonie@kernel.org>, <perex@perex.cz>,
        <tiwai@suse.com>, <robh+dt@kernel.org>, <lgirdwood@gmail.com>,
        <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
        <digetx@gmail.com>, <alsa-devel@alsa-project.org>,
        <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <sharadg@nvidia.com>, <mkumard@nvidia.com>,
        <viswanathl@nvidia.com>, <rlokhande@nvidia.com>,
        <dramesh@nvidia.com>, <atalambedu@nvidia.com>,
        <nwartikar@nvidia.com>, <swarren@nvidia.com>,
        <nicoleotsuka@gmail.com>
Subject: Re: [PATCH v4 15/23] ASoC: soc-core: Identify 'no_pcm' DAI links for
 DPCM
To:     Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
References: <1593233625-14961-1-git-send-email-spujar@nvidia.com>
 <1593233625-14961-16-git-send-email-spujar@nvidia.com>
 <87366e1wkb.wl-kuninori.morimoto.gx@renesas.com>
From:   Sameer Pujar <spujar@nvidia.com>
Message-ID: <83b6cee2-8254-477c-cb65-7e05a9fdbacf@nvidia.com>
Date:   Mon, 29 Jun 2020 22:49:16 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <87366e1wkb.wl-kuninori.morimoto.gx@renesas.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1593451119; bh=vfUlacqPqumAcLV/c3aep1ECOFfwdUJzoe5RzrENPw0=;
        h=X-PGP-Universal:CC:Subject:To:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding:
         Content-Language;
        b=VnC8bHc+ovxigL9GkP1gqYfnwMTUuwzT7kfV2xUkvtLMZAFOCjDe59+nUsfk2zS2q
         fOANMD+Nf7NfUfBAD8FJlNyEh/2ZvHQ4R8UlGsxrWYsZrzVx2XCnqBsSVb7OOB/vqF
         6z/hGWZGIVqJCOJmx2ameHksjLhCaKPeJ4L4T6oAaLUbh1RarDm8UIuXB9BEI4YJKq
         NCPvT8V3c2m4rdYtX4/Z/jpq+z8XztvzNJGI45B3LAJl4KichbWOFWEfFo5tdUOmew
         wX4YoyUEBzqbFJPG0kVQxrQoZ40OJmtBkA7QICsXowl9CkuLQO3Ez7M969NB6KkPfR
         dR8unv5kxhjTw==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 6/29/2020 7:08 AM, Kuninori Morimoto wrote:
> External email: Use caution opening links or attachments
>
>
> Hi Sameer
>
>> PCM devices are created for dai links with 'no-pcm' flag as '0'.
>> Such DAI links have CPU component which implement pcm_construct()
>> and pcm_destruct() callbacks. Based on this, current patch exposes
>> a helper function to identify such components and populate 'no_pcm'
>> flag for DPCM DAI link.
> (snip)
>> +bool soc_component_is_pcm(struct snd_soc_dai_link_component *dlc)
>> +{
>> +     struct snd_soc_component *component;
>> +     struct snd_soc_dai *dai;
>> +
>> +     for_each_component(component) {
>> +             if (!component->driver)
>> +                     continue;
>> +
>> +             for_each_component_dais(component, dai) {
>> +                     if (!dai->name || !dlc->dai_name)
>> +                             continue;
>> +
>> +                     if (strcmp(dai->name, dlc->dai_name))
>> +                             continue;
>
> We can/should NULL poinster check for "dlc->dai_name" on top of
> this function instead of inside loop ?
> And then, we can remove "dai->name" check because next strcmp()
> automatically fail if dai->name was NULL.

Sounds good, will update.
>
> Thank you for your help !!
>
> Best regards
> ---
> Kuninori Morimoto