Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Song Liu <songliubraving@fb.com>
To:     Yonghong Song <yhs@fb.com>
CC:     bpf <bpf@vger.kernel.org>, Networking <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        "Alexei Starovoitov" <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        "Kernel Team" <Kernel-team@fb.com>,
        "john.fastabend@gmail.com" <john.fastabend@gmail.com>,
        "kpsingh@chromium.org" <kpsingh@chromium.org>
Subject: Re: [PATCH v4 bpf-next 4/4] selftests/bpf: add bpf_iter test with
 bpf_get_task_stack()
Thread-Topic: [PATCH v4 bpf-next 4/4] selftests/bpf: add bpf_iter test with
 bpf_get_task_stack()
Thread-Index: AQHWTdoDfCOX11YGIkGMqBxDcia9fajvsh+AgAAevoA=
Date:   Mon, 29 Jun 2020 16:56:52 +0000
Message-ID: <D3BAF0B3-122D-409C-B0DD-600E1EE606C0@fb.com>
References: <20200629055530.3244342-1-songliubraving@fb.com>
 <20200629055530.3244342-5-songliubraving@fb.com>
 <bd62a752-df45-8e65-9f74-e340ef708764@fb.com>
In-Reply-To: <bd62a752-df45-8e65-9f74-e340ef708764@fb.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D65D069ED4CCB34BB8A9545E6242AB29@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ff34af05-3303-4aec-c487-08d81c4d6c04
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2020 16:56:52.2336
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7DWS3t/1AqOiETwg+wBN7+VHT/9FMJQoU9cQ6u4mzq9iGxRPfYPq7WrwvXdXysk13nmG9fDdqM8vVIkA4b0aBQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB4088
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687
 definitions=2020-06-29_18:2020-06-29,2020-06-29 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 mlxscore=0 bulkscore=0
 impostorscore=0 lowpriorityscore=0 cotscore=-2147483648 spamscore=0
 mlxlogscore=999 adultscore=0 clxscore=1015 malwarescore=0 suspectscore=0
 priorityscore=1501 phishscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2004280000 definitions=main-2006290109
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jun 29, 2020, at 8:06 AM, Yonghong Song <yhs@fb.com> wrote:
>=20
>=20
>=20
> On 6/28/20 10:55 PM, Song Liu wrote:
>> The new test is similar to other bpf_iter tests. It dumps all
>> /proc/<pid>/stack to a seq_file. Here is some example output:
>> pid:     2873 num_entries:        3
>> [<0>] worker_thread+0xc6/0x380
>> [<0>] kthread+0x135/0x150
>> [<0>] ret_from_fork+0x22/0x30
>> pid:     2874 num_entries:        9
>> [<0>] __bpf_get_stack+0x15e/0x250
>> [<0>] bpf_prog_22a400774977bb30_dump_task_stack+0x4a/0xb3c
>> [<0>] bpf_iter_run_prog+0x81/0x170
>> [<0>] __task_seq_show+0x58/0x80
>> [<0>] bpf_seq_read+0x1c3/0x3b0
>> [<0>] vfs_read+0x9e/0x170
>> [<0>] ksys_read+0xa7/0xe0
>> [<0>] do_syscall_64+0x4c/0xa0
>> [<0>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
>> Note: To print the output, it is necessary to modify the selftest.
>=20
> I do not know what this sentence means. It seems confusing
> and probably not needed.

It means current do_dummy_read() doesn't check/print the contents of the=20
seq_file:

        /* not check contents, but ensure read() ends without error */
        while ((len =3D read(iter_fd, buf, sizeof(buf))) > 0)
                ;

>=20
>> Signed-off-by: Song Liu <songliubraving@fb.com>
>=20
> Acked-by: Yonghong Song <yhs@fb.com>

Thanks!

[...]