Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3012764ybt; Mon, 29 Jun 2020 12:54:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+7eji48wTZu0iuR9T5eRRCz6RlvWxHO4oZQ2CZMILEnOCu9feIwHGp9X2XUSq3HdIqeiT X-Received: by 2002:a17:907:1051:: with SMTP id oy17mr16000287ejb.394.1593460492944; Mon, 29 Jun 2020 12:54:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593460492; cv=none; d=google.com; s=arc-20160816; b=sxFQT3Ovf2qJu2EVb1CgyJL/W3i07MPt4AAwpI7TEPyDgIZTrOy6iMsA+RLXJ/UGa7 5gILBz/zd3VIo+NjQ5grP1IYnRIR6+B/7ejViAR4nOkGwdbFCYZnYlO2m/zW6foZR6N3 3cSIJSctftvUd5f7EqZRLa77R5H3zUGEYF9+hR0CUwHUOe96cMunMgdcHj35xZUOjk5I oywSuXBpIPzSAjr0rjODEXcPFsi598z6gkzlbbRnBeVESQjK8S+cqjqtavZCLGap5gmO pO5pFVPWELJeVWCkDzpZUy2wxRkaTvnMZNbPMycPKDVkLp/Nwi28KG+B4W/qqwGmQbHQ hd1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=N4V7c3aeDLuwhXVBAMVeI93XDU7dFLU/PzjjNBBA1go=; b=hH1HXCRKV0zW3urQN0Jo5pGwQoFICx9eDPNOk/9jrVWxFGBlkgIrviD4EVdXXaGzVl A7RAWaR96NzXflHtQKLj2rYlqgqcFsT76DDl1HLncmQCQBQ4xG7qJFWOHuz+9oeJhGXK On+0i5AK7MuIMBOwE8oOVndxNl+CVTN/JqN4G573IWOUFk5gdTKEDCZsUPBJO9AtlZqm wQo0g4ovtAzHTlSPqDDiBA9ituG3I7ONvuX3b2m93Z7ml26wL87OR6FBHShhvSNpZMK6 8xHuVlCldKjrnzULeD6v8oR9i36x1pW2/VLqdRq9TtHdkkSYfY0tfu+6GWHbZoCcgfyX PpmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=nNXRBgZr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l18si284237edv.490.2020.06.29.12.54.29; Mon, 29 Jun 2020 12:54:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=nNXRBgZr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387731AbgF2TyX (ORCPT + 99 others); Mon, 29 Jun 2020 15:54:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387465AbgF2Tk0 (ORCPT ); Mon, 29 Jun 2020 15:40:26 -0400 Received: from casper.infradead.org (unknown [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 878D3C03E979; Mon, 29 Jun 2020 12:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=N4V7c3aeDLuwhXVBAMVeI93XDU7dFLU/PzjjNBBA1go=; b=nNXRBgZrqUkYW06bN7kMVbhKQp BlmpXSCdMbqb/Ht5wWHvxJtfrr6svKWFTv8Tt4Ufg7qxppL3ei3dqO9x299z4vDWrKj32a6zAcqSL c4m4m8EqDQLV0obdwyzZum4rarDYDeASDBA573D5k0a3dJQxVCiz704FT+VKkYMJLXypm1xf73cB3 AgGiAVOZh9k2lYQfWMzILfco++St1B3KjzFapwCHMQbwuELGSHYTtoro2+hJ5y8/MWUZ1ZK+LwL5b lBJH3BSbHoqbKdPThJr9UKdZ7VxtYLq5743jYblBgF7pRDOkMgWA5lO9m/s8jN+8qpJjWKBSVdf/p NcNA9Tjw==; Received: from [2001:4bb8:184:76e3:fcca:c8dc:a4bf:12fa] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpzdP-0004KD-Bf; Mon, 29 Jun 2020 19:40:08 +0000 From: Christoph Hellwig To: Jens Axboe Cc: dm-devel@redhat.com, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-xtensa@linux-xtensa.org, drbd-dev@lists.linbit.com, linuxppc-dev@lists.ozlabs.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org Subject: [PATCH 11/20] fs: remove a weird comment in submit_bh_wbc Date: Mon, 29 Jun 2020 21:39:38 +0200 Message-Id: <20200629193947.2705954-12-hch@lst.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200629193947.2705954-1-hch@lst.de> References: <20200629193947.2705954-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org All bios can get remapped if submitted to partitions. No need to comment on that. Signed-off-by: Christoph Hellwig --- fs/buffer.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/fs/buffer.c b/fs/buffer.c index 64fe82ec65ff1f..2725ebbcfdc246 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -3040,12 +3040,7 @@ static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh, if (test_set_buffer_req(bh) && (op == REQ_OP_WRITE)) clear_buffer_write_io_error(bh); - /* - * from here on down, it's all bio -- do the initial mapping, - * submit_bio -> generic_make_request may further map this bio around - */ bio = bio_alloc(GFP_NOIO, 1); - bio->bi_iter.bi_sector = bh->b_blocknr * (bh->b_size >> 9); bio_set_dev(bio, bh->b_bdev); bio->bi_write_hint = write_hint; -- 2.26.2