Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3014704ybt; Mon, 29 Jun 2020 12:58:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxpOOxg1mvWMafzmAq6R61Uqn+kSmowIFOUpTG/3wxqrtv1ZGm9i2kqeGBsjzMDUDhAlsu6 X-Received: by 2002:a05:6402:6c4:: with SMTP id n4mr20023458edy.353.1593460695614; Mon, 29 Jun 2020 12:58:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593460695; cv=none; d=google.com; s=arc-20160816; b=ptC/yTQLgkf9aIXkZFMLG9kl2lxyaM8tHkWgNPhO6PhwYgyzpMu+tm07/N8Uc3DfVM AMGimM1kjuvFpMTZ7BOES3xoddCs3sF3N0Yx0XlyfRl1jMAeBVbvG1SXCzKVJgSXkGwl MaaYEvqkuT6fC1Eis5SNyu6PMjyx0Le5I5Tz6kFodFYDAeoMXkGx4p/m06+eSgJGLTiE wN9DOkJzHrU4oTUU0+HBnlCrFv+rSGT57iIGBwzg0shdaRGCKLsgu6tz6OE2J4PM4EEk MauOUmNu4tVhbsMpFlOm4H/62SX9WnGa3oExmGfJT0nh8dyz24V7/CPAGAND7+5RHYaB 9Edw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=X55oxz7tLyraJtO6J73SeiCeLFG0e/OsMA07n6z4Iv8=; b=b1Inpa864FdfVL2+N+oEGpo3Wc26zoR6MUUzI4EVlneAVMQ4bPkNtA/mOJXnb4Ex72 QKmMZmOnbLj/pVOxNpgnqoLSoh3MhaV/aRa8s3c3DJxD4bVZ9vqD/2VGq/0jZl43/54Z 9Q8v7z2scDEBbdn+Fr+YrJ1KeqFfqneInHsaUvmJYZXwLs0ym4QCj9UMRpVSwpjNkMxy i0xi2bLy0kX485srDMjuw91M9e42Vb2ktPX+gJlncXU7JaXOZZtmE2wGjyz1mYD31PQa 0V9U9cJEi/Mwc+ERqsMGTLJNyhX8PaEtPtFn7R/LZmtokFmcdtZo0Cdef8FNYRyt5CyT nxRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2a1Lm5gb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h17si346390ejd.655.2020.06.29.12.57.51; Mon, 29 Jun 2020 12:58:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2a1Lm5gb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388403AbgF2Tzw (ORCPT + 99 others); Mon, 29 Jun 2020 15:55:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:47692 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387650AbgF2TkY (ORCPT ); Mon, 29 Jun 2020 15:40:24 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2065D24863; Mon, 29 Jun 2020 15:26:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593444363; bh=gpPPAYVd9LaEX4dHMQnOKycL70VUVrdmJMyRwEa7Y8c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2a1Lm5gb/1+Je9BZjngt4+bOcuxUx4+n9YcSkcMZBemPMgAsVyp/m+u2B1Pd/Dvvk aQ5PMa7tFKSSiJOS3QJN3qHCplTjHG7aib2IUYCqFvrgbFtL0DRwmi4ciTDxBMeccC HeV3ZA4Mo+uKA4x+KiyRkSYBcy5Hvw/Pg3E4q2ds= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tang Bin , Zhang Shengju , Greg Kroah-Hartman Subject: [PATCH 5.4 040/178] usb: host: ehci-exynos: Fix error check in exynos_ehci_probe() Date: Mon, 29 Jun 2020 11:23:05 -0400 Message-Id: <20200629152523.2494198-41-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629152523.2494198-1-sashal@kernel.org> References: <20200629152523.2494198-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.50-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-5.4.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 5.4.50-rc1 X-KernelTest-Deadline: 2020-07-01T15:25+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tang Bin commit 44ed240d62736ad29943ec01e41e194b96f7c5e9 upstream. If the function platform_get_irq() failed, the negative value returned will not be detected here. So fix error handling in exynos_ehci_probe(). And when get irq failed, the function platform_get_irq() logs an error message, so remove redundant message here. Fixes: 1bcc5aa87f04 ("USB: Add initial S5P EHCI driver") Cc: stable Signed-off-by: Zhang Shengju Signed-off-by: Tang Bin Link: https://lore.kernel.org/r/20200602114708.28620-1-tangbin@cmss.chinamobile.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/host/ehci-exynos.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c index 01debfd03d4a0..84d59a611511e 100644 --- a/drivers/usb/host/ehci-exynos.c +++ b/drivers/usb/host/ehci-exynos.c @@ -203,9 +203,8 @@ static int exynos_ehci_probe(struct platform_device *pdev) hcd->rsrc_len = resource_size(res); irq = platform_get_irq(pdev, 0); - if (!irq) { - dev_err(&pdev->dev, "Failed to get IRQ\n"); - err = -ENODEV; + if (irq < 0) { + err = irq; goto fail_io; } -- 2.25.1