Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3015762ybt; Mon, 29 Jun 2020 13:00:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBydyBKaJaesRO8Q3Zcaq7NjOSKL0HuPAFaWu//cBW7xRoe28JfvuE4mcOlFxfeeVeaaPU X-Received: by 2002:a05:6402:1597:: with SMTP id c23mr18610421edv.243.1593460808908; Mon, 29 Jun 2020 13:00:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593460808; cv=none; d=google.com; s=arc-20160816; b=r7I6Y4a5AEXtwEz4G3FAerA6IwQhjitchrPjt5+IQwivGoC9izXkU1I9eaMpWyI8t3 p16hEzNYIi3ywQAgqZBY6rcdQAtO3kgzjqWOpZnfd936dofNESp9OzcTIvM6qpp78XoY 3a/RAzCn5+vAHVQhkQzk5EJye2v5pcskZEnZwh+gwvGjNR8x5pCD362nMZGmA5uOkz6V v4dTbKXupNLEq3bx9c9NtwGBCaxmgCb+3ReCCpn6+33mf11IH96Gy/le7uwGmgRxkPok AbB1Iigd6WEe/ptqoddbewVFAtICDjpIuWgBo7/DUax46S6dGVP5J8ifkM6uKtLsUId1 gckw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=bzOBRM8KG98YXW+joK9v+5/nHbpbFUUOPs/AIijdZMc=; b=VSfScjZ7jEWtXeqeWJRoRF9vOYhvFPz9GBPKLWUmUNYLpaIEaQY7/wV1AxJ6LuD8oZ jEahXXVWBUuRP0LWs2jDxyZjywsjLBzX/nRNR7ZGPhoPlOG4U7W0ObuFtP62kodE0yiM xPGToMAoiDn0jIpiVQYDKTv5Bmn9ljB8VxJz/u8kJU/5Xrtsnu2gJEuB8S/qRrCM4vSs oAJ5TSUueWZJMCyVWJLk0+NqdeLog9E1XFF2VmaTsybl2MnyXhy/oPJdY2auKuc3eb9n rnl6NBoh1OuiMUr4fbsDsehpbio9iP2AvmxifaTeKSZCggzOTykFkHkmsVVh+ZLIaHhU G0TA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kh4dyUVx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i26si303080edv.525.2020.06.29.12.59.46; Mon, 29 Jun 2020 13:00:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kh4dyUVx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388284AbgF2T7X (ORCPT + 99 others); Mon, 29 Jun 2020 15:59:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:47666 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732365AbgF2TkR (ORCPT ); Mon, 29 Jun 2020 15:40:17 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1C888248E3; Mon, 29 Jun 2020 15:27:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593444437; bh=mX4wMNn1g/7Ny6Rr+PpoHehJ4ZbRoJVgpWsTKJ0Vw7c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kh4dyUVxQhu+IWwsCaoisTKggySvfuDKxMHGYIoKxfYYWGUdodg+bjrNzWZgPkpBM 78oSrZ8AZSBlpsDf7WUGFJRHK2uYqRHDN0beTQ6+c/oeDXRqOOTHrVpDcSV9+95olS v03IK6D2wXwNGk+bPd75zMape+nIBLlD980Bi0ZI= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Juri Lelli , syzbot+5ac8bac25f95e8b221e7@syzkaller.appspotmail.com, Peter Zijlstra , Ingo Molnar , Daniel Wagner , Sasha Levin Subject: [PATCH 5.4 115/178] sched/deadline: Initialize ->dl_boosted Date: Mon, 29 Jun 2020 11:24:20 -0400 Message-Id: <20200629152523.2494198-116-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629152523.2494198-1-sashal@kernel.org> References: <20200629152523.2494198-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.50-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-5.4.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 5.4.50-rc1 X-KernelTest-Deadline: 2020-07-01T15:25+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Juri Lelli [ Upstream commit ce9bc3b27f2a21a7969b41ffb04df8cf61bd1592 ] syzbot reported the following warning triggered via SYSC_sched_setattr(): WARNING: CPU: 0 PID: 6973 at kernel/sched/deadline.c:593 setup_new_dl_entity /kernel/sched/deadline.c:594 [inline] WARNING: CPU: 0 PID: 6973 at kernel/sched/deadline.c:593 enqueue_dl_entity /kernel/sched/deadline.c:1370 [inline] WARNING: CPU: 0 PID: 6973 at kernel/sched/deadline.c:593 enqueue_task_dl+0x1c17/0x2ba0 /kernel/sched/deadline.c:1441 This happens because the ->dl_boosted flag is currently not initialized by __dl_clear_params() (unlike the other flags) and setup_new_dl_entity() rightfully complains about it. Initialize dl_boosted to 0. Fixes: 2d3d891d3344 ("sched/deadline: Add SCHED_DEADLINE inheritance logic") Reported-by: syzbot+5ac8bac25f95e8b221e7@syzkaller.appspotmail.com Signed-off-by: Juri Lelli Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Ingo Molnar Tested-by: Daniel Wagner Link: https://lkml.kernel.org/r/20200617072919.818409-1-juri.lelli@redhat.com Signed-off-by: Sasha Levin --- kernel/sched/deadline.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index 08bdee0480b3e..4cb00538a207b 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -2693,6 +2693,7 @@ void __dl_clear_params(struct task_struct *p) dl_se->dl_bw = 0; dl_se->dl_density = 0; + dl_se->dl_boosted = 0; dl_se->dl_throttled = 0; dl_se->dl_yielded = 0; dl_se->dl_non_contending = 0; -- 2.25.1