Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3020603ybt; Mon, 29 Jun 2020 13:06:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzN2R6SeuZGa6kmuVUKMEMmVmu/Jr63Hsl/dOgPpg9vC/ZxNW1rQTsoqzBzrr0036o93WPb X-Received: by 2002:a17:906:284e:: with SMTP id s14mr14348402ejc.498.1593461182630; Mon, 29 Jun 2020 13:06:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593461182; cv=none; d=google.com; s=arc-20160816; b=Y/v1JEkTfSEUO7she4ifi2J7X9+dMinDuK1w/PyHnuI1vycYtmCOPoSDW78ZKvUTTd iEU7/WAGpcB+U305FurEjrSKPACPQU0kQ5AkxX/RQ/e4vxH53s/jz3QJRs5QqUyci7W8 mex9K5p713OfO1afOfk+YPsSJ9f3VWNv9k1KFzjOXZ3qZVxQfcuCc3pa384Izou8/NvK MXbuC7Es1Dp0yu07pNFlOXZZBribdvQURBo2I73yU/q871LrWXAjaZnn43/FmeIJ8auT 8sncwiL/lIFXFTl23XxcxOYx3mLkXljJLS74CKThBdKVF4Z1GCOh3q3/VzFF3SmMTCkp GumQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ZEc28hPpgp9pfPsXNz+C5lxReQn9vkP2u/PZPRoCA+8=; b=Q1i9mZms29hGrsfulNJ8OgGmzcSL2ie+HudqHAJTtOF5exgilNLWK2dSJCCrbJuuyH wbKShgB1IHdijMstVAEgrsCD6XL9IbsnY0InFYDyAUL10j4r4aH8kCyMuRMhBEqQK4wO VBK6JlP8LPHXlQZKATyKJDkbJ+DlsxjkXABvH6VBuWugORXT+odzYJ3YpEWdEGigxnyZ E+yyW0Ez/yNNR8uRcG30BqJ2hGQHsMrli/cx+d/oDlsw3HrnoAps5IBYYgOjyNgbyoJ2 jwy9bRAIhkkyFuy4pHX646kqSq2BdUdXtsN/mIZ6fcsdmFb1713dZI9OUG9JjWQcsvJj ppBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vM+4u+gI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l3si383632eja.81.2020.06.29.13.05.59; Mon, 29 Jun 2020 13:06:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vM+4u+gI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388773AbgF2UDv (ORCPT + 99 others); Mon, 29 Jun 2020 16:03:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:40598 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732993AbgF2Tac (ORCPT ); Mon, 29 Jun 2020 15:30:32 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A6B89252F8; Mon, 29 Jun 2020 15:38:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593445125; bh=PCMb1FSQDXT+Fl2v4voDD/LCRJKIFXWVpLWwX+ZrLm0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vM+4u+gIcBxbm9h4pB9hDhm7mJSnLspaSRHRmZP++tLypsIEimKyqs2hFqsG/s/p1 chzF+EyzEbYYTnoZc7BxYVXg4D/zkc5lIzlDDsu3GpAxZnBHZW0bwgVDScKYFiRdIz 5fwdd+5PeAE0x19AIXO/bIZTqs0n71r3s/ByjbDY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Joakim Tjernlund , Oliver Neukum , Greg Kroah-Hartman Subject: [PATCH 4.14 32/78] cdc-acm: Add DISABLE_ECHO quirk for Microchip/SMSC chip Date: Mon, 29 Jun 2020 11:37:20 -0400 Message-Id: <20200629153806.2494953-33-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629153806.2494953-1-sashal@kernel.org> References: <20200629153806.2494953-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.186-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-4.14.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 4.14.186-rc1 X-KernelTest-Deadline: 2020-07-01T15:38+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joakim Tjernlund commit 03894573f2913181ee5aae0089f333b2131f2d4b upstream. USB_DEVICE(0x0424, 0x274e) can send data before cdc_acm is ready, causing garbage chars on the TTY causing stray input to the shell and/or login prompt. Signed-off-by: Joakim Tjernlund Cc: stable@vger.kernel.org Acked-by: Oliver Neukum Link: https://lore.kernel.org/r/20200605105418.22263-1-joakim.tjernlund@infinera.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/class/cdc-acm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 4067f079b08da..0de467c8593db 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -1734,6 +1734,8 @@ static int acm_pre_reset(struct usb_interface *intf) static const struct usb_device_id acm_ids[] = { /* quirky and broken devices */ + { USB_DEVICE(0x0424, 0x274e), /* Microchip Technology, Inc. (formerly SMSC) */ + .driver_info = DISABLE_ECHO, }, /* DISABLE ECHO in termios flag */ { USB_DEVICE(0x076d, 0x0006), /* Denso Cradle CU-321 */ .driver_info = NO_UNION_NORMAL, },/* has no union descriptor */ { USB_DEVICE(0x17ef, 0x7000), /* Lenovo USB modem */ -- 2.25.1