Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3020995ybt; Mon, 29 Jun 2020 13:07:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwbnE18PkghV7mcMUxdHLxgVybjLCsNMF9u026BYmuFv84HC5dSA7ELK9gd4ZieuZToI7wA X-Received: by 2002:a17:906:6b0c:: with SMTP id q12mr11991134ejr.525.1593461220747; Mon, 29 Jun 2020 13:07:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593461220; cv=none; d=google.com; s=arc-20160816; b=qf92k8v7CWyEmrUPnryRAmqh9S9nmVbXuxC0BO5EDTTpkdQFY9JvvZvhbMued1qT4Q phrb0BWjWAOyVp5wEZ5sAEdpMCA/+bmEpNarVi6CPOsO99uRQF5ki7FZb54brD5Erj5X PEHCsJOv+nzt3GAFLouRluwSTh55jaZ8gktwGOoUrIA4X7d/oxdB6kNxpVPyt+3F5fhi fEG8FuYc8DkWf8Cy05tYn0mO5PEF3c893bdN7QO7yZrtKk3TlKxOEc9JEmH5Nz2bG4M7 8Q5ZqFL41YwbZ+3R+BI4oxbChwYF9ZPAY8eGvadSYPQpHgCRg1IVE4AoZOqOWPpP8HDd rrXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TsMSZ7twWnXDXz1zTegi3bqLxFFt1XX6YWK9LBlpelg=; b=ZUEFlKu0Nfrx86M/Ln7Jy53LCHhj15coa3cMDdcL4d8V06LfYHJ5NqdK6xUAFXuib8 jwgfWbJwio3tLV/Lenq1iMepY3t0AXy/UOhzaPozBX7IqAb0zKyM5Mv37eHTCx5UGJu6 3e1qcUo7lCnKWbwE5HKpnJ+NwKEHaZ186LKukUTl+RgP8eXQaMvFx3ZA+mCVOCG7ksVr SLQT+BJWb8MmhtRgvEK0AsbBGly9TpYMDpC3SgFCJ3VEOlquL4bu0DayUKzUW2k5rCgX i/RFbWsQtMOzBslJS7rO6LAeGKgpkJi4V2Mh4+gC0BP+WQpETlJW7O+u5w/B79driW2D iWbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="CL4NGA/H"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id by12si331059edb.99.2020.06.29.13.06.37; Mon, 29 Jun 2020 13:07:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="CL4NGA/H"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387495AbgF2UGA (ORCPT + 99 others); Mon, 29 Jun 2020 16:06:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:40564 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732968AbgF2Ta2 (ORCPT ); Mon, 29 Jun 2020 15:30:28 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B4A01252FB; Mon, 29 Jun 2020 15:38:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593445127; bh=5a4vMiA89yhb7XOQaVEtSlAjPYdcO6kAdT0WJKVbJVs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CL4NGA/H4iu9of8W2N0iGxcM/a5yFDbsi6osvQVzx7Yiiu3suw7XFPqYVxW8j7/Wz mWbBAdpMvhutIJGwIgo53mVHKZ+05dYx4RDT51wkmHYpNB+dpxOyI/cujNSLi3Jq+V xFu+v28/81MtpjBmrXPY7Lboy5BoxkrjzdKf9hoI= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Julian Scheel , Takashi Iwai , Sasha Levin Subject: [PATCH 4.14 34/78] ALSA: usb-audio: uac1: Invalidate ctl on interrupt Date: Mon, 29 Jun 2020 11:37:22 -0400 Message-Id: <20200629153806.2494953-35-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629153806.2494953-1-sashal@kernel.org> References: <20200629153806.2494953-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.186-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-4.14.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 4.14.186-rc1 X-KernelTest-Deadline: 2020-07-01T15:38+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julian Scheel [ Upstream commit b2500b584cfd228d67e1e43daf27c8af865b499e ] When an interrupt occurs, the value of at least one of the belonging controls should have changed. To make sure they get re-read from device on the next read, invalidate the cache. This was correctly implemented for uac2 already, but missing for uac1. Signed-off-by: Julian Scheel Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/usb/mixer.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c index dbbc5609b453b..33deb5ec8b7a1 100644 --- a/sound/usb/mixer.c +++ b/sound/usb/mixer.c @@ -2403,9 +2403,14 @@ void snd_usb_mixer_notify_id(struct usb_mixer_interface *mixer, int unitid) { struct usb_mixer_elem_list *list; - for (list = mixer->id_elems[unitid]; list; list = list->next_id_elem) + for (list = mixer->id_elems[unitid]; list; list = list->next_id_elem) { + struct usb_mixer_elem_info *info = + (struct usb_mixer_elem_info *)list; + /* invalidate cache, so the value is read from the device */ + info->cached = 0; snd_ctl_notify(mixer->chip->card, SNDRV_CTL_EVENT_MASK_VALUE, &list->kctl->id); + } } static void snd_usb_mixer_dump_cval(struct snd_info_buffer *buffer, -- 2.25.1