Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751019AbWC2WHS (ORCPT ); Wed, 29 Mar 2006 17:07:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751023AbWC2WHS (ORCPT ); Wed, 29 Mar 2006 17:07:18 -0500 Received: from mx1.redhat.com ([66.187.233.31]:5773 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1751019AbWC2WHQ (ORCPT ); Wed, 29 Mar 2006 17:07:16 -0500 Date: Wed, 29 Mar 2006 17:07:01 -0500 From: Dave Jones To: Paul Mackerras Cc: Linux Kernel Mailing List , Michael Ellerman Subject: Re: [PATCH] powerpc: Move pSeries firmware feature setup into platforms/pseries Message-ID: <20060329220701.GE452@redhat.com> Mail-Followup-To: Dave Jones , Paul Mackerras , Linux Kernel Mailing List , Michael Ellerman References: <200603230714.k2N7EmH1021685@hera.kernel.org> <20060329195212.GA19236@redhat.com> <17451.866.287446.68155@cargo.ozlabs.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17451.866.287446.68155@cargo.ozlabs.ibm.com> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 894 Lines: 25 On Thu, Mar 30, 2006 at 09:00:02AM +1100, Paul Mackerras wrote: > Dave Jones writes: > > > This (or one of the other firmware patches, I've not narrowed it down that close) > > breaks ppc64 oprofile. > > > > modpost now complains with.. > > > > kernel/arch/powerpc/oprofile/oprofile.ko needs unknown symbol ppc64_firmware_features > > That got renamed to powerpc_firmware_features. I don't see any > occurrences of ppc64_firmware_features left anywhere in the tree. Are > you sure you don't just need to make clean and rebuild? See firmware_has_feature() in include/asm-powerpc/firmware.h Dave -- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/